Ticket #16567: 16567.domainvalidatortestit.patch

test/unit/org/openstreetmap/josm/data/validation/routines/DomainValidatorTestIT.java

@@ -16 +16 @@
  */
 package org.openstreetmap.josm.data.validation.routines;
 
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
 
 import java.io.BufferedReader;
 import java.io.Closeable;
@@ -142 +142 @@
                                 }
                             }
                         } else {
-                            System.err.println("Expected to find HTML info for "+ asciiTld);
+                            Logging.error("Expected to find HTML info for "+ asciiTld);
                         }
                     }
                     ianaTlds.add(asciiTld);
@@ -174 +174 @@
             }
         }
         // Check if internal tables contain any additional entries
-        assertTrue(isInIanaList("INFRASTRUCTURE_TLDS", ianaTlds));
-        assertTrue(isInIanaList("COUNTRY_CODE_TLDS", ianaTlds));
-        assertTrue(isInIanaList("GENERIC_TLDS", ianaTlds));
+        assertTrue(isInIanaList("INFRASTRUCTURE_TLDS", ianaTlds), String.join(System.lineSeparator(), Logging.getLastErrorAndWarnings()));
+        assertTrue(isInIanaList("COUNTRY_CODE_TLDS", ianaTlds), String.join(System.lineSeparator(), Logging.getLastErrorAndWarnings()));
+        assertTrue(isInIanaList("GENERIC_TLDS", ianaTlds), String.join(System.lineSeparator(), Logging.getLastErrorAndWarnings()));
         // Don't check local TLDS assertTrue(isInIanaList("LOCAL_TLDS", ianaTlds));
     }
 
@@ -349 +349 @@
         boolean ok = true;
         for (int i = 0; i < array.length; i++) {
             if (!ianaTlds.contains(array[i])) {
-                System.out.println(name + " contains unexpected value: " + array[i]);
+                Logging.error(name + " contains unexpected value: " + array[i]);
                 ok = false;
             }
         }
@@ -387 +387 @@
             final String nextEntry = array[i+1];
             final int cmp = entry.compareTo(nextEntry);
             if (cmp > 0) { // out of order
-                System.out.println("Out of order entry: " + entry + " < " + nextEntry + " in " + name);
+                Logging.error("Out of order entry: " + entry + " < " + nextEntry + " in " + name);
                 sorted = false;
             } else if (cmp == 0) {
                 strictlySorted = false;
-                System.out.println("Duplicated entry: " + entry + " in " + name);
+                Logging.error("Duplicated entry: " + entry + " in " + name);
             }
             if (!isLowerCase(entry)) {
-                System.out.println("Non lowerCase entry: " + entry + " in " + name);
+                Logging.error("Non lowerCase entry: " + entry + " in " + name);
                 lowerCase = false;
             }
         }