Ticket #16472: 16472.coverity_fixes.patch

src/org/openstreetmap/josm/gui/util/imagery/CameraPlane.java

@@ -182 +182 @@
         setRotation(vec.getPolarAngle(), vec.getAzimuthalAngle());
     }
 
-    public Vector3D getRotation() {
+    public synchronized Vector3D getRotation() {
         return this.rotation;
     }
 

src/org/openstreetmap/josm/gui/util/imagery/Vector3D.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.gui.util.imagery;
 
+import org.openstreetmap.josm.tools.Utils;
+
 /**
  * A basic 3D vector class (immutable)
  * @author Taylor Smock (documentation, spherical conversions)
@@ -236 +238 @@
     public boolean equals(Object o) {
         if (o instanceof Vector3D) {
             Vector3D other = (Vector3D) o;
-            return this.x == other.x && this.y == other.y && this.z == other.z;
+            return Utils.equalsEpsilon(this.x, other.x) && Utils.equalsEpsilon(this.y, other.y) && Utils.equalsEpsilon(this.z, other.z);
         }
         return false;
     }