Changeset 9999 in josm for trunk/src/org/openstreetmap/josm/actions

Timestamp:

2016-03-15T09:15:57+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - do not copy collection contents from one to another with a loop

Location:

trunk/src/org/openstreetmap/josm/actions

Files:

• OrthogonalizeAction.java (modified) (1 diff)
• SelectNonBranchingWaySequences.java (modified) (1 diff)
• SplitWayAction.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/OrthogonalizeAction.java

@@ -305 +305 @@
         final Set<Node> allNodes = new HashSet<>();
         for (WayData w : wayDataList) {
-            for (Node n : w.wayNodes) {
-                allNodes.add(n);
-            }
+            allNodes.addAll(w.wayNodes);
         }
 

trunk/src/org/openstreetmap/josm/actions/SelectNonBranchingWaySequences.java

@@ -147 +147 @@
 
         boolean selectionChanged = false;
-        Collection<OsmPrimitive> selection = new LinkedList<>();
-        for (OsmPrimitive primitive : currentSelection) {
-            selection.add(primitive);
-        }
+        Collection<OsmPrimitive> selection = new LinkedList<>(currentSelection);
 
         do {

trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java

@@ -586 +586 @@
         newWays.remove(wayToKeep);
 
+        newSelection.addAll(newWays);
         for (Way wayToAdd : newWays) {
             commandList.add(new AddCommand(layer, wayToAdd));
-            newSelection.add(wayToAdd);
         }