Context Navigation

mappaint

Timestamp:

2015-12-02T00:05:09+01:00 (9 years ago)

Author:

Don-vip

Message:

sonar - Immutable Field

Location:

trunk/src/org/openstreetmap/josm/gui/mappaint

Files:

-              r8958
+              r9078
     public static class BoxProviderResult {
         private Rectangle box;
         private boolean temporary;
+        private final Rectangle box;
+        private final boolean temporary;
         public BoxProviderResult(Rectangle box, boolean temporary) {
 …
     public static class SimpleBoxProvider implements BoxProvider {
         private Rectangle box;
+        private final Rectangle box;
         /**

r8855	r9078
24	24
25	25	public class ElemStyles {
26		private List<StyleSource> styleSources;
	26	private final List<StyleSource> styleSources;
27	27	private boolean drawMultipolygon;
28	28

-              r8973
+              r9078
     public static class StaticLabelCompositionStrategy extends LabelCompositionStrategy {
         private String defaultLabel;
+        private final String defaultLabel;
         public StaticLabelCompositionStrategy(String defaultLabel) {
 …
     public static class TagLookupCompositionStrategy extends LabelCompositionStrategy {
         private String defaultLabelTag;
+        private final String defaultLabelTag;
         public TagLookupCompositionStrategy(String defaultLabelTag) {

r8846	r9078
12	12	public class LineTextElemStyle extends ElemStyle {
13	13
14		private TextElement text;
	14	private final TextElement text;
15	15
16	16	protected LineTextElemStyle(Cascade c, TextElement text) {

r8870	r9078
31	31
32	32	private transient StyleSource style;
33		private JCheckBoxMenuItem button;
	33	private final JCheckBoxMenuItem button;
34	34
35	35	MapPaintAction(StyleSource style) {

r8937	r9078
343	343	public static class MapPaintStyleLoader extends PleaseWaitRunnable {
344	344	private boolean canceled;
345		private Collection<StyleSource> sources;
	345	private final Collection<StyleSource> sources;
346	346
347	347	public MapPaintStyleLoader(Collection<StyleSource> sources) {

r8846	r9078
16	16	public class MultiCascade implements StyleKeys {
17	17
18		private Map<String, Cascade> layers;
	18	private final Map<String, Cascade> layers;
19	19	public Range range;
20	20

r8575	r9078
47	47	*/
48	48	public static class StyleList implements Iterable<ElemStyle> {
49		private List<ElemStyle> lst;
	49	private final List<ElemStyle> lst;
50	50
51	51	/**

r8419	r9078
33	33	public abstract class StyleSource extends SourceEntry {
34	34
35		private List<Throwable> errors = new ArrayList<>();
	35	private final List<Throwable> errors = new ArrayList<>();
36	36	public File zipIcons;
37	37

-              r9059
+              r9078
     public static class CondOperator implements Expression {
         private Expression condition, firstOption, secondOption;
+        private final Expression condition, firstOption, secondOption;
         /**
 …
     public static class AndOperator implements Expression {
         private List<Expression> args;
+        private final List<Expression> args;
         /**
 …
     public static class OrOperator implements Expression {
         private List<Expression> args;
+        private final List<Expression> args;
         /**
 …
     public static class LengthFunction implements Expression {
         private Expression arg;
+        private final Expression arg;
         /**

r9059	r9078
122	122	*/
123	123	private class MatchingReferrerFinder extends AbstractVisitor {
124		private Environment e;
	124	private final Environment e;
125	125
126	126	/**

-              r8846
+              r9078
     private boolean inDoc, inRule, inCondition, inLine, inLineMod, inIcon, inArea, inScaleMax, inScaleMin;
     private boolean hadLine, hadLineMod, hadIcon, hadArea;
     private RuleElem rule = new RuleElem();
     private XmlStyleSource style;
+    private final RuleElem rule = new RuleElem();
+    private final XmlStyleSource style;
     static class RuleElem {
         private XmlCondition cond = new XmlCondition();
+        private final XmlCondition cond = new XmlCondition();
         private Collection<XmlCondition> conditions;
         private double scaleMax;
         private double scaleMin;
         private LinePrototype line = new LinePrototype();
         private LinemodPrototype linemod = new LinemodPrototype();
         private AreaPrototype area = new AreaPrototype();
+        private final LinePrototype line = new LinePrototype();
+        private final LinemodPrototype linemod = new LinemodPrototype();
+        private final AreaPrototype area = new AreaPrototype();
         private IconPrototype icon = new IconPrototype();
         public void init() {

Note: See TracChangeset for help on using the changeset viewer.