Changeset 9062 in josm for trunk/src/org/openstreetmap/josm/plugins

Timestamp:

2015-11-25T01:21:14+01:00 (8 years ago)

Author:

Don-vip

Message:

Sonar - squid:S1941 - Variables should not be declared before they are relevant

Location:

trunk/src/org/openstreetmap/josm/plugins

Files:

• PluginHandler.java (modified) (2 diffs)
• ReadRemotePluginInformationTask.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -380 +380 @@
         if (message == null) return false;
 
+        UpdatePluginsMessagePanel pnlMessage = new UpdatePluginsMessagePanel();
+        pnlMessage.setMessage(message);
+        pnlMessage.initDontShowAgain(togglePreferenceKey);
+
+        // check whether automatic update at startup was disabled
+        //
+        String policy = Main.pref.get(togglePreferenceKey, "ask").trim().toLowerCase(Locale.ENGLISH);
+        switch(policy) {
+        case "never":
+            if ("pluginmanager.version-based-update.policy".equals(togglePreferenceKey)) {
+                Main.info(tr("Skipping plugin update after JOSM upgrade. Automatic update at startup is disabled."));
+            } else if ("pluginmanager.time-based-update.policy".equals(togglePreferenceKey)) {
+                Main.info(tr("Skipping plugin update after elapsed update interval. Automatic update at startup is disabled."));
+            }
+            return false;
+
+        case "always":
+            if ("pluginmanager.version-based-update.policy".equals(togglePreferenceKey)) {
+                Main.info(tr("Running plugin update after JOSM upgrade. Automatic update at startup is enabled."));
+            } else if ("pluginmanager.time-based-update.policy".equals(togglePreferenceKey)) {
+                Main.info(tr("Running plugin update after elapsed update interval. Automatic update at startup is disabled."));
+            }
+            return true;
+
+        case "ask":
+            break;
+
+        default:
+            Main.warn(tr("Unexpected value ''{0}'' for preference ''{1}''. Assuming value ''ask''.", policy, togglePreferenceKey));
+        }
+
         ButtonSpec[] options = new ButtonSpec[] {
                 new ButtonSpec(
@@ -394 +425 @@
                 )
         };
-
-        UpdatePluginsMessagePanel pnlMessage = new UpdatePluginsMessagePanel();
-        pnlMessage.setMessage(message);
-        pnlMessage.initDontShowAgain(togglePreferenceKey);
-
-        // check whether automatic update at startup was disabled
-        //
-        String policy = Main.pref.get(togglePreferenceKey, "ask").trim().toLowerCase(Locale.ENGLISH);
-        switch(policy) {
-        case "never":
-            if ("pluginmanager.version-based-update.policy".equals(togglePreferenceKey)) {
-                Main.info(tr("Skipping plugin update after JOSM upgrade. Automatic update at startup is disabled."));
-            } else if ("pluginmanager.time-based-update.policy".equals(togglePreferenceKey)) {
-                Main.info(tr("Skipping plugin update after elapsed update interval. Automatic update at startup is disabled."));
-            }
-            return false;
-
-        case "always":
-            if ("pluginmanager.version-based-update.policy".equals(togglePreferenceKey)) {
-                Main.info(tr("Running plugin update after JOSM upgrade. Automatic update at startup is enabled."));
-            } else if ("pluginmanager.time-based-update.policy".equals(togglePreferenceKey)) {
-                Main.info(tr("Running plugin update after elapsed update interval. Automatic update at startup is disabled."));
-            }
-            return true;
-
-        case "ask":
-            break;
-
-        default:
-            Main.warn(tr("Unexpected value ''{0}'' for preference ''{1}''. Assuming value ''ask''.", policy, togglePreferenceKey));
-        }
 
         int ret = HelpAwareOptionPane.showOptionDialog(

trunk/src/org/openstreetmap/josm/plugins/ReadRemotePluginInformationTask.java

@@ -315 +315 @@
         if (sites == null) return;
         getProgressMonitor().setTicksCount(sites.size() * 3);
-        File pluginDir = Main.pref.getPluginsDirectory();
 
         // collect old cache files and remove if no longer in use
@@ -334 +333 @@
         }
 
+        File pluginDir = Main.pref.getPluginsDirectory();
         for (String site: sites) {
             String printsite = site.replaceAll("%<(.*)>", "");