Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/plugins

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

Location:

trunk/src/org/openstreetmap/josm/plugins

Files:

• PluginHandler.java (modified) (1 diff)
• PluginListParser.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -1390 +1390 @@
             pl.remove(pi.name);
             pl.add(pi.name + " (" + (pi.localversion != null && !pi.localversion.isEmpty()
-                    ? pi.localversion : "unknown") + ")");
+                    ? pi.localversion : "unknown") + ')');
         }
         Collections.sort(pl);

trunk/src/org/openstreetmap/josm/plugins/PluginListParser.java

@@ -70 +70 @@
                     while (line.length() > 70) {
                         manifest.append(line.substring(0, 70)).append('\n');
-                        line = " " + line.substring(70);
+                        line = ' ' + line.substring(70);
                     }
                     manifest.append(line).append('\n');