Changeset 8840 in josm for trunk/src/org/openstreetmap/josm/gui/history

Timestamp:

2015-10-09T02:12:45+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S3052 - Fields should not be initialized to default values

Location:

trunk/src/org/openstreetmap/josm/gui/history

Files:

• DiffTableModel.java (modified) (1 diff)
• HistoryLoadTask.java (modified) (1 diff)
• NodeListViewer.java (modified) (1 diff)
• TwoColumnDiff.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/history/DiffTableModel.java

@@ -15 +15 @@
 class DiffTableModel extends AbstractTableModel {
     private transient List<TwoColumnDiff.Item> rows = new ArrayList<>();
-    private boolean reversed = false;
+    private boolean reversed;
 
     public void setRows(List<TwoColumnDiff.Item> rows, boolean reversed) {

trunk/src/org/openstreetmap/josm/gui/history/HistoryLoadTask.java

@@ -50 +50 @@
 public class HistoryLoadTask extends PleaseWaitRunnable {
 
-    private boolean canceled = false;
-    private Exception lastException  = null;
+    private boolean canceled;
+    private Exception lastException;
     private Set<PrimitiveId> toLoad;
     private HistoryDataSet loadedData;
-    private OsmServerHistoryReader reader = null;
+    private OsmServerHistoryReader reader;
 
     /**

trunk/src/org/openstreetmap/josm/gui/history/NodeListViewer.java

@@ -89 +89 @@
     protected TableModelListener newReversedChangeListener(final JTable table, final NodeListTableColumnModel columnModel) {
         return new TableModelListener() {
-            private Boolean reversed = null;
+            private Boolean reversed;
             private final String nonReversedText = tr("Nodes") + (table.getFont().canDisplay('\u25bc') ? " \u25bc" : " (1-n)");
             private final String reversedText = tr("Nodes") + (table.getFont().canDisplay('\u25b2') ? " \u25b2" : " (n-1)");

trunk/src/org/openstreetmap/josm/gui/history/TwoColumnDiff.java

@@ -62 +62 @@
     private Object[] reference;
     private Object[] current;
-    boolean referenceReversed = false;
+    boolean referenceReversed;
 
     TwoColumnDiff(Object[] reference, Object[] current) {