Changeset 8404 in josm for trunk/src/org/openstreetmap/josm/gui/preferences/server

Timestamp:

2015-05-21T01:18:35+02:00 (9 years ago)

Author:

Don-vip

Message:

When doing a String.toLowerCase()/toUpperCase() call, use a Locale. This avoids problems with certain locales, i.e. Lithuanian or Turkish. See PMD UseLocaleWithCaseConversions rule and String.toLowerCase() javadoc.

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/server/ProxyPreferencesPanel.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/server/ProxyPreferencesPanel.java

@@ -16 +16 @@
 import java.net.ProxySelector;
 import java.util.EnumMap;
+import java.util.Locale;
 import java.util.Map;
 
@@ -74 +75 @@
         public static ProxyPolicy fromName(String policyName) {
             if (policyName == null) return null;
-            policyName = policyName.trim().toLowerCase();
+            policyName = policyName.trim().toLowerCase(Locale.ENGLISH);
             for(ProxyPolicy pp: values()) {
                 if (pp.getName().equals(policyName))