Changeset 8356 in josm

Timestamp:

2015-05-15T22:50:00+02:00 (9 years ago)

Author:

Don-vip

Message:

remove public mutable array Main.commandLineArgs

Location:

trunk

Files:

• src/org/openstreetmap/josm/Main.java (modified) (2 diffs)
• src/org/openstreetmap/josm/actions/RestartAction.java (modified) (2 diffs)
• src/org/openstreetmap/josm/actions/ShowStatusReportAction.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/MainApplication.java (modified) (5 diffs)
• test/unit/org/openstreetmap/josm/tools/BugReportExceptionHandlerTest.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/Main.java

@@ -160 +160 @@
      * Command-line arguments used to run the application.
      */
-    public static String[] commandLineArgs;
+    protected static final List<String> COMMAND_LINE_ARGS = new ArrayList<>();
 
     /**
@@ -1645 +1645 @@
 
     /**
+     * Returns the command-line arguments used to run the application.
+     * @return the command-line arguments used to run the application
+     * @since 8356
+     */
+    public static List<String> getCommandLineArgs() {
+        return Collections.unmodifiableList(COMMAND_LINE_ARGS);
+    }
+
+    /**
      * Returns the JOSM website URL.
      * @return the josm website URL

trunk/src/org/openstreetmap/josm/actions/RestartAction.java

@@ -11 +11 @@
 import java.lang.management.ManagementFactory;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 
@@ -137 +136 @@
                 }
                 // finally add program arguments
-                cmd.addAll(Arrays.asList(Main.commandLineArgs));
+                cmd.addAll(Main.getCommandLineArgs());
             }
             Main.info("Restart "+cmd);

trunk/src/org/openstreetmap/josm/actions/ShowStatusReportAction.java

@@ -132 +132 @@
             // Ignore exception
         }
-        if (Main.commandLineArgs.length > 0) {
-            text.append("Program arguments: "+ Arrays.toString(Main.commandLineArgs));
+        List<String> commandLineArgs = Main.getCommandLineArgs();
+        if (!commandLineArgs.isEmpty()) {
+            text.append("Program arguments: "+ Arrays.toString(commandLineArgs.toArray()));
             text.append("\n");
         }

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -16 +16 @@
 import java.io.InputStream;
 import java.net.Authenticator;
+import java.net.Inet6Address;
 import java.net.InetAddress;
-import java.net.Inet6Address;
 import java.net.ProxySelector;
 import java.net.URL;
@@ -202 +202 @@
         ;
 
-        private String name;
-        private boolean requiresArgument;
+        private final String name;
+        private final boolean requiresArg;
 
         private Option(boolean requiresArgument) {
             this.name = name().toLowerCase().replace("_", "-");
-            this.requiresArgument = requiresArgument;
+            this.requiresArg = requiresArgument;
         }
 
@@ -223 +223 @@
          */
         public boolean requiresArgument() {
-            return requiresArgument;
+            return requiresArg;
         }
 
@@ -336 +336 @@
         Main.platform.preStartupHook();
 
-        Main.commandLineArgs = Utils.copyArray(argArray);
+        Main.COMMAND_LINE_ARGS.addAll(Arrays.asList(argArray));
 
         if (args.containsKey(Option.VERSION)) {
@@ -569 +569 @@
         }
     }
-    
+
     private static class GuiFinalizationWorker implements Runnable {
 

trunk/test/unit/org/openstreetmap/josm/tools/BugReportExceptionHandlerTest.java

@@ -28 +28 @@
     @Before
     public void setUp() {
-        Main.commandLineArgs = new String[0];
         JOSMFixture.createUnitTestFixture().init();
     }