Changeset 8318 in josm for trunk/src/org/openstreetmap/josm/gui/help

Timestamp:

2015-05-03T18:34:33+02:00 (9 years ago)

Author:

Don-vip

Message:

fix various Sonar issues:

• squid:S1068: Unused private fields should be removed
• squid:S1155: Collection.isEmpty() should be used to test for emptiness
• squid:S1185: Overriding methods should do more than simply call the same method in the super class
• squid:S1694: An abstract class should have both abstract and concrete methods
• squid:S1905: Redundant casts should not be used
• squid:S2065: Fields in non-serializable classes should not be "transient"
• squid:S2583: Conditions should not unconditionally evaluate to "TRUE" or to "FALSE"
• squid:ModifiersOrderCheck: Modifiers should be declared in the correct order

File:

• trunk/src/org/openstreetmap/josm/gui/help/HelpBrowserHistory.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/help/HelpBrowserHistory.java

@@ -57 +57 @@
         } else if (historyPos == history.size() -1) {
             // do nothing just append
-        } else if (historyPos ==0 && history.size() > 0) {
+        } else if (historyPos ==0 && !history.isEmpty()) {
             history = new ArrayList<>(Collections.singletonList(history.get(0)));
         } else if (historyPos < history.size() -1 && historyPos > 0) {