Changeset 7706 in josm

Timestamp:

2014-11-04T15:38:17+01:00 (9 years ago)

Author:

stoecker

Message:

don't crash when data image url is broken

File:

• trunk/src/org/openstreetmap/josm/tools/ImageProvider.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/tools/ImageProvider.java

@@ -683 +683 @@
                     }
                 }
-                if (mediatype != null && mediatype.contains("image/svg+xml")) {
+                if ("image/svg+xml".equals(mediatype)) {
                     String s = new String(bytes, StandardCharsets.UTF_8);
                     URI uri = getSvgUniverse().loadSVG(new StringReader(s), URLEncoder.encode(s, "UTF-8"));
@@ -697 +697 @@
                         // This can be removed if someday Oracle fixes https://bugs.openjdk.java.net/browse/JDK-6788458
                         // hg.openjdk.java.net/jdk7u/jdk7u/jdk/file/828c4fedd29f/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java#l656
-                        return new ImageResource(read(new ByteArrayInputStream(bytes), false, true));
+                        Image img = read(new ByteArrayInputStream(bytes), false, true);
+                        return img == null ? null : new ImageResource(img);
                     } catch (IOException e) {
                         Main.warn("IOException while reading image: "+e.getMessage());