Changeset 7020 in josm

Timestamp:

2014-04-29T01:09:09+02:00 (10 years ago)

Author:

Don-vip

Message:

see #8465 - fix remaining compilation warnings

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/gpx/GpxData.java (modified) (2 diffs)
• gui/download/BookmarkSelection.java (modified) (1 diff)
• gui/preferences/ToolbarPreferences.java (modified) (4 diffs)
• gui/preferences/display/LafPreference.java (modified) (1 diff)
• gui/preferences/display/LanguagePreference.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/gpx/GpxData.java

@@ -30 +30 @@
     public final Collection<WayPoint> waypoints = new LinkedList<>();
 
-    @SuppressWarnings("unchecked")
     public void mergeFrom(GpxData other) {
         if (storageFile == null && other.storageFile != null) {
@@ -41 +40 @@
             String k = ent.getKey();
             if (k.equals(META_LINKS) && attr.containsKey(META_LINKS)) {
-                ((Collection<GpxLink>) attr.get(META_LINKS)).addAll(
-                        (Collection<GpxLink>) ent.getValue());
+                @SuppressWarnings("unchecked")
+                Collection<GpxLink> my = (Collection<GpxLink>) attr.get(META_LINKS);
+                @SuppressWarnings("unchecked")
+                Collection<GpxLink> their = (Collection<GpxLink>) ent.getValue();
+                my.addAll(their);
             } else {
                 attr.put(k, ent.getValue());

trunk/src/org/openstreetmap/josm/gui/download/BookmarkSelection.java

@@ -202 +202 @@
             b.setArea(currentArea);
             if (b.getName() != null && !b.getName().isEmpty()) {
-                ((DefaultListModel)bookmarks.getModel()).addElement(b);
+                ((DefaultListModel<BookmarkList.Bookmark>)bookmarks.getModel()).addElement(b);
                 bookmarks.save();
             }

trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java

@@ -619 +619 @@
             });
 
-            ListCellRenderer renderer = new DefaultListCellRenderer(){
-                @Override public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus) {
+            ListCellRenderer<ActionDefinition> renderer = new ListCellRenderer<ActionDefinition>() {
+                final DefaultListCellRenderer def = new DefaultListCellRenderer();
+                @Override
+                public Component getListCellRendererComponent(JList<? extends ActionDefinition> list,
+                        ActionDefinition value, int index, boolean isSelected, boolean cellHasFocus) {
                     String s;
                     Icon i;
@@ -631 +634 @@
                         s = tr("Separator");
                     }
-                    JLabel l = (JLabel)super.getListCellRendererComponent(list, s, index, isSelected, cellHasFocus);
+                    JLabel l = (JLabel)def.getListCellRendererComponent(list, s, index, isSelected, cellHasFocus);
                     l.setIcon(i);
                     return l;
@@ -654 +657 @@
             selectedList.setTransferHandler(new TransferHandler() {
                 @Override
+                @SuppressWarnings("unchecked")
                 protected Transferable createTransferable(JComponent c) {
                     List<ActionDefinition> actions = new ArrayList<>();
@@ -686 +690 @@
                     try {
                         int dropIndex = selectedList.locationToIndex(selectedList.getMousePosition(true));
+                        @SuppressWarnings("unchecked")
                         List<ActionDefinition> draggedData = (List<ActionDefinition>) t.getTransferData(ACTION_FLAVOR);
 

trunk/src/org/openstreetmap/josm/gui/preferences/display/LafPreference.java

@@ -84 +84 @@
         }
 
-        final ListCellRenderer oldRenderer = lafCombo.getRenderer();
-        lafCombo.setRenderer(new DefaultListCellRenderer(){
-            @Override public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus) {
-                return oldRenderer.getListCellRendererComponent(list, ((LookAndFeelInfo)value).getName(), index, isSelected, cellHasFocus);
+        lafCombo.setRenderer(new ListCellRenderer<LookAndFeelInfo>(){
+            final DefaultListCellRenderer def = new DefaultListCellRenderer();
+            @Override
+            public Component getListCellRendererComponent(JList<? extends LookAndFeelInfo> list, LookAndFeelInfo value, 
+                    int index, boolean isSelected, boolean cellHasFocus) {
+                return def.getListCellRendererComponent(list, value.getName(), index, isSelected, cellHasFocus);
             }
         });

trunk/src/org/openstreetmap/josm/gui/preferences/display/LanguagePreference.java

@@ -53 +53 @@
         model.selectLanguage(Main.pref.get("language"));
         langCombo = new JosmComboBox<>(model);
-        langCombo.setRenderer(new LanguageCellRenderer(langCombo.getRenderer()));
+        langCombo.setRenderer(new LanguageCellRenderer());
 
         LafPreference lafPreference = gui.getSetting(LafPreference.class);
@@ -109 +109 @@
     }
 
-    private static class LanguageCellRenderer extends DefaultListCellRenderer {
-        private ListCellRenderer dispatch;
-        public LanguageCellRenderer(ListCellRenderer dispatch) {
-            this.dispatch = dispatch;
+    private static class LanguageCellRenderer implements ListCellRenderer<Locale> {
+        private final DefaultListCellRenderer dispatch;
+        public LanguageCellRenderer() {
+            this.dispatch = new DefaultListCellRenderer();
         }
         @Override
-        public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected,
-                boolean cellHasFocus) {
-            Locale l = (Locale) value;
+        public Component getListCellRendererComponent(JList<? extends Locale> list, Locale l, 
+                int index, boolean isSelected, boolean cellHasFocus) {
             return dispatch.getListCellRendererComponent(list,
                     l == null ? tr("Default (Auto determined)") : l.getDisplayName(l),