Changeset 6258 in josm for trunk/src/org/openstreetmap/josm/gui/io

Timestamp:

2013-09-25T02:56:42+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/Findbugs - Performance - Inefficient use of keySet iterator instead of entrySet iterator

File:

• trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -22 +22 @@
 import java.util.List;
 import java.util.Map;
+import java.util.Map.Entry;
 
 import javax.swing.AbstractAction;
@@ -312 +313 @@
     public void setDefaultChangesetTags(Map<String, String> tags) {
         pnlTagSettings.setDefaultTags(tags);
-         for (String key: tags.keySet()) {
-            if (key.equals("comment")) {
-                changesetCommentModel.setComment(tags.get(key));
+         for (Entry<String, String> entry: tags.entrySet()) {
+            if ("comment".equals(entry.getKey())) {
+                changesetCommentModel.setComment(entry.getValue());
             }
         }