Changeset 4614 in josm

Timestamp:

2011-11-27T11:32:47+01:00 (12 years ago)

Author:

bastiK

Message:

see #7088 - Preferences NullPointerException (more checks to find the cause of the error)

File:

• trunk/src/org/openstreetmap/josm/data/Preferences.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -890 +890 @@
 
                 valueCopy = new ArrayList<String>(value);
+                if (valueCopy.contains(null)) throw new RuntimeException("Error: Null as list element in preference setting (key '"+key+"')");
                 collectionProperties.put(key, Collections.unmodifiableList(valueCopy));
                 try {
@@ -1000 +1001 @@
 
                 valueCopy = new ArrayList<List<String>>(value.size());
+                if (valueCopy.contains(null)) throw new RuntimeException("Error: Null as list element in preference setting (key '"+key+"')");
                 for (Collection<String> lst : value) {
-                    valueCopy.add(Collections.unmodifiableList(new ArrayList<String>(lst)));
+                    List<String> lstCopy = new ArrayList<String>(lst);
+                    if (lstCopy.contains(null)) throw new RuntimeException("Error: Null as inner list element in preference setting (key '"+key+"')");
+                    valueCopy.add(Collections.unmodifiableList(lstCopy));
                 }
                 arrayProperties.put(key, Collections.unmodifiableList(valueCopy));
@@ -1093 +1097 @@
 
                 valueCopy = new ArrayList<Map<String, String>>(value.size());
+                if (valueCopy.contains(null)) throw new RuntimeException("Error: Null as list element in preference setting (key '"+key+"')");
                 for (Map<String, String> map : value) {
-                    valueCopy.add(Collections.unmodifiableMap(new LinkedHashMap<String,String>(map)));
+                    Map<String, String> mapCopy = new LinkedHashMap<String,String>(map);
+                    if (mapCopy.keySet().contains(null)) throw new RuntimeException("Error: Null as map key in preference setting (key '"+key+"')");
+                    if (mapCopy.values().contains(null)) throw new RuntimeException("Error: Null as map value in preference setting (key '"+key+"')");
+                    valueCopy.add(Collections.unmodifiableMap(mapCopy));
                 }
                 listOfStructsProperties.put(key, Collections.unmodifiableList(valueCopy));