Changeset 4354 in josm

Timestamp:

Aug 27, 2011 2:42:10 PM (21 months ago)

Author:

stoecker

Message:

see #6731 - reduce space required for SideButtons, moved arrow creation into SideButton class

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• SideButton.java (modified) (5 diffs)
• dialogs/SelectionListDialog.java (modified) (10 diffs)
• dialogs/ToggleDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/SideButton.java

@@ -4 +4 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
+import java.awt.Color;
+import java.awt.BorderLayout;
 import java.awt.Image;
 import java.awt.Insets;
@@ -9 +11 @@
 
 import javax.swing.Action;
+import javax.swing.BorderFactory;
 import javax.swing.Icon;
 import javax.swing.ImageIcon;
 import javax.swing.JButton;
+import javax.swing.SwingConstants;
+import javax.swing.plaf.basic.BasicArrowButton;
 
 import org.openstreetmap.josm.Main;
@@ -46 +51 @@
         {
             Image im = ((ImageIcon) i).getImage();
-            setIcon(new ImageIcon(im.getScaledInstance(20 , 20, Image.SCALE_SMOOTH)));
+            setIcon(new ImageIcon(im.getScaledInstance(20, 20, Image.SCALE_SMOOTH)));
         }
     }
@@ -52 +57 @@
     public static ImageIcon makeIcon(String imagename) {
         Image im = ImageProvider.get("dialogs", imagename).getImage();
-        return new ImageIcon(im.getScaledInstance(20 , 20, Image.SCALE_SMOOTH));
+        return new ImageIcon(im.getScaledInstance(20, 20, Image.SCALE_SMOOTH));
     }
 
@@ -90 +95 @@
     private void doStyle()
     {
-        setMargin(new Insets(1,1,1,1));
+        setLayout(new BorderLayout());
         setIconTextGap(2);
+        setMargin(new Insets(-1,0,-1,0));
+    }
+
+    public void createArrow(ActionListener listener) {
+        setMargin(new Insets(0,0,0,0));
+        BasicArrowButton arrowButton = new BasicArrowButton(SwingConstants.SOUTH, null, null, Color.BLACK, null);
+        arrowButton.setBorder(BorderFactory.createEmptyBorder());
+        add(arrowButton, BorderLayout.EAST);
+        arrowButton.addActionListener(listener);
     }
 }

trunk/src/org/openstreetmap/josm/gui/dialogs/SelectionListDialog.java

@@ -5 +5 @@
 import static org.openstreetmap.josm.tools.I18n.trn;
 
-import java.awt.BorderLayout;
-import java.awt.Color;
 import java.awt.Component;
-import java.awt.GridLayout;
 import java.awt.Rectangle;
 import java.awt.event.ActionEvent;
@@ -16 +13 @@
 import java.awt.event.MouseEvent;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
@@ -27 +25 @@
 import javax.swing.AbstractAction;
 import javax.swing.AbstractListModel;
-import javax.swing.BorderFactory;
 import javax.swing.DefaultListSelectionModel;
 import javax.swing.JButton;
 import javax.swing.JList;
 import javax.swing.JMenuItem;
-import javax.swing.JPanel;
 import javax.swing.JPopupMenu;
-import javax.swing.JScrollPane;
 import javax.swing.ListSelectionModel;
-import javax.swing.SwingConstants;
 import javax.swing.SwingUtilities;
 import javax.swing.event.ListDataEvent;
@@ -42 +36 @@
 import javax.swing.event.ListSelectionEvent;
 import javax.swing.event.ListSelectionListener;
-import javax.swing.plaf.basic.BasicArrowButton;
 
 import org.openstreetmap.josm.Main;
@@ -98 +91 @@
 
     /**
-     * Builds the panel with the list of selected OSM primitives
-     *
-     * @return the panel with the list of selected OSM primitives
-     */
-    protected JPanel buildListPanel() {
-        JPanel pnl = new JPanel(new BorderLayout());
+     * Builds the content panel for this dialog
+     */
+    protected void buildContentPanel() {
         DefaultListSelectionModel selectionModel  = new DefaultListSelectionModel();
         model = new SelectionListModel(selectionModel);
@@ -111 +101 @@
         lstPrimitives.setCellRenderer(new OsmPrimitivRenderer());
         lstPrimitives.setTransferHandler(null); // Fix #6290. Drag & Drop is not supported anyway and Copy/Paste is better propagated to main window
-        pnl.add(new JScrollPane(lstPrimitives), BorderLayout.CENTER);
-
-        return pnl;
-    }
-
-    /**
-     * Builds the row of action buttons at the bottom of this dialog
-     *
-     * @return the panel
-     */
-    protected JPanel buildActionPanel() {
-        JPanel pnl = new  JPanel(new GridLayout(1,2));
 
         // the select action
-        final JButton selectButton = new SideButton(actSelect = new SelectAction());
+        final SideButton selectButton = new SideButton(actSelect = new SelectAction());
         lstPrimitives.getSelectionModel().addListSelectionListener(actSelect);
-        pnl.add(selectButton);
-        BasicArrowButton selectionHistoryMenuButton = createArrowButton(selectButton);
-        selectionHistoryMenuButton.addActionListener(new ActionListener() {
+        selectButton.createArrow(new ActionListener() {
             public void actionPerformed(ActionEvent e) {
                 SelectionHistoryPopup.launch(selectButton, model.getSelectionHistory());
@@ -136 +112 @@
 
         // the search button
-        final JButton searchButton = new SideButton(actSearch = new SearchAction());
-        pnl.add(searchButton);
-
-        BasicArrowButton searchHistoryMenuButton = createArrowButton(searchButton);
-        searchHistoryMenuButton.addActionListener(new ActionListener() {
+        final SideButton searchButton = new SideButton(actSearch = new SearchAction());
+        searchButton.createArrow(new ActionListener() {
             public void actionPerformed(ActionEvent e) {
                 SearchPopupMenu.launch(searchButton);
@@ -146 +119 @@
         });
 
-        return pnl;
-    }
-
-    /**
-     * Builds the content panel for this dialog
-     *
-     * @return the content panel
-     */
-    protected JPanel buildContentPanel() {
-        JPanel pnl = new JPanel(new BorderLayout());
-        pnl.add(buildListPanel(), BorderLayout.CENTER);
-        pnl.add(buildActionPanel(), BorderLayout.SOUTH);
-        return pnl;
+        createLayout(lstPrimitives, true, Arrays.asList(new SideButton[] {
+            selectButton, searchButton
+        }));
     }
 
@@ -168 +131 @@
         );
 
-        add(buildContentPanel(), BorderLayout.CENTER);
+        buildContentPanel();
         model.addListDataListener(new TitleUpdater());
         actZoomToJOSMSelection = new ZoomToJOSMSelectionAction();
@@ -213 +176 @@
         DatasetEventManager.getInstance().removeDatasetListener(model);
     }
-
-    private BasicArrowButton createArrowButton(JButton parentButton) {
-        BasicArrowButton arrowButton = new BasicArrowButton(SwingConstants.SOUTH, null, null, Color.BLACK, null);
-        arrowButton.setBorder(BorderFactory.createEmptyBorder());
-        parentButton.setLayout(new BorderLayout());
-        parentButton.add(arrowButton, BorderLayout.EAST);
-        return arrowButton;
-    }
-
 
     /**

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -671 +671 @@
             add(data, BorderLayout.CENTER);
         if(buttons != null && buttons.size() != 0) {
-            JPanel buttonsPanel = new JPanel();
-            buttonsPanel.setLayout(Main.pref.getBoolean("dialog.align.left", false)
+            JPanel buttonsPanel = new JPanel(Main.pref.getBoolean("dialog.align.left", false)
                 ? new FlowLayout(FlowLayout.LEFT) : new GridLayout(1,buttons.size()));
             for(SideButton button : buttons)