Changeset 3129 in josm

Timestamp:

13.03.2010 15:34:25 (2 years ago)

Author:

jttt

Message:

Memory optimizations

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/OsmPrimitive.java (modified) (10 diffs)
• io/OsmReader.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java

@@ -55 +55 @@
     private static final int FLAG_TAGGED = 1 << 6;
     private static final int FLAG_DIRECTION_REVERSED = 1 << 7;
+    private static final int FLAG_HIGHLIGHTED = 1 << 8;
+    private static final int FLAG_INCOMPLETE = 1 << 9;
 
     /**
@@ -119 +121 @@
     /* mappaint data */
     public ElemStyle mappaintStyle = null;
-    public Integer mappaintDrawnCode = 0;
+    public int mappaintDrawnCode = 0;
 
     /* This should not be called from outside. Fixing the UI to add relevant
@@ -168 +170 @@
     }
 
-    private volatile byte flags = FLAG_VISIBLE;   // visible per default
+    private volatile short flags = FLAG_VISIBLE;   // visible per default
 
     /**
@@ -175 +177 @@
      */
     private User user = null;
-
-    /**
-     * If set to true, this object is incomplete, which means only the id
-     * and type is known (type is the objects instance class)
-     */
-    private boolean incomplete = false;
 
     /**
@@ -333 +329 @@
      */
     public boolean isUsable() {
-        return !isDeleted() && !isIncomplete() && !isDisabled();
-    }
-
-    public boolean isDrawable()
-    {
-        return !isDeleted() && !isIncomplete() && !isFiltered();
+        return (flags & (FLAG_DELETED + FLAG_INCOMPLETE + FLAG_DISABLED)) == 0;
+    }
+
+    public boolean isDrawable() {
+        return (flags & (FLAG_DELETED + FLAG_INCOMPLETE + FLAG_FILTERED)) == 0;
     }
 
@@ -470 +465 @@
         return timestamp == 0;
     }
-
-    /**
-     * If set to true, this object is highlighted. Currently this is only used to
-     * show which ways/nodes will connect
-     */
-    private volatile boolean highlighted = false;
 
     private int timestamp;
@@ -1270 +1259 @@
     }
 
+    /**
+     * If set to true, this object is incomplete, which means only the id
+     * and type is known (type is the objects instance class)
+     */
     private void setIncomplete(boolean incomplete) {
-        if (dataSet != null && incomplete != this.incomplete) {
+        if (dataSet != null && incomplete != this.isIncomplete()) {
             if (incomplete) {
                 dataSet.firePrimitivesRemoved(Collections.singletonList(this), true);
@@ -1278 +1271 @@
             }
         }
-        this.incomplete = incomplete;
+        if (incomplete) {
+            flags |= FLAG_INCOMPLETE;
+        } else {
+            flags &= ~FLAG_INCOMPLETE;
+        }
     }
 
     public boolean isIncomplete() {
-        return incomplete;
+        return (flags & FLAG_INCOMPLETE) != 0;
     }
 
@@ -1290 +1287 @@
 
     public void setHighlighted(boolean highlighted) {
-        if (this.highlighted != highlighted) {
-            this.highlighted = highlighted;
+        if (isHighlighted() != highlighted) {
+            if (highlighted) {
+                flags |= FLAG_HIGHLIGHTED;
+            } else {
+                flags &= ~FLAG_HIGHLIGHTED;
+            }
             if (dataSet != null) {
                 dataSet.fireHighlightingChanged(this);
@@ -1299 +1300 @@
 
     public boolean isHighlighted() {
-        return highlighted;
+        return (flags & FLAG_HIGHLIGHTED) != 0;
     }
 }

trunk/src/org/openstreetmap/josm/io/OsmReader.java

@@ -32 +32 @@
 import org.openstreetmap.josm.data.osm.RelationMember;
 import org.openstreetmap.josm.data.osm.SimplePrimitiveId;
+import org.openstreetmap.josm.data.osm.Storage;
 import org.openstreetmap.josm.data.osm.User;
 import org.openstreetmap.josm.data.osm.Way;
@@ -119 +120 @@
         private long currentExternalId;
         private String generator;
+        private Storage<String> internedStrings = new Storage<String>();
+
+        // Memory optimization - see #2312
+        private String intern(String s) {
+            String result = internedStrings.get(s);
+            if (result == null) {
+                internedStrings.put(s);
+                return s;
+            } else
+                return result;
+        }
 
         @Override public void startElement(String namespaceURI, String localName, String qName, Attributes atts) throws SAXException {
+
             if (qName.equals("osm")) {
                 if (atts == null) {
@@ -258 +271 @@
                 String key = atts.getValue("k");
                 String value = atts.getValue("v");
-                currentPrimitive.put(key, value);
+                currentPrimitive.put(intern(key), intern(value));
+
             } else {
                 System.out.println(tr("Undefined element ''{0}'' found in input stream. Skipping.", qName));