Changeset 12734 in josm

Timestamp:

2017-09-05T10:46:58+02:00 (7 years ago)

Author:

Don-vip

Message:

see #15182 - see #15229 - remove GUI dependence in NoteData

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/NoteData.java (modified) (3 diffs)
• gui/dialogs/NotesDialog.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/data/osm/NoteData.java

@@ -15 +15 @@
 import org.openstreetmap.josm.data.notes.NoteComment;
 import org.openstreetmap.josm.gui.JosmUserIdentityManager;
-import org.openstreetmap.josm.gui.MainApplication;
-import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.tools.ListenerList;
 import org.openstreetmap.josm.tools.Logging;
@@ -101 +99 @@
     public void setSelectedNote(Note note) {
         selectedNote = note;
-        MapFrame map = MainApplication.getMap();
-        if (map != null) {
-            map.noteDialog.selectionChanged();
-        }
         listeners.fireEvent(l -> l.selectedNoteChanged(this));
     }
@@ -236 +230 @@
 
     private void dataUpdated() {
-        if (MainApplication.isDisplayingMapView()) {
-            MainApplication.getMap().noteDialog.setNotes(getSortedNotes());
-        }
         listeners.fireEvent(l -> l.noteDataUpdated(this));
     }

trunk/src/org/openstreetmap/josm/gui/dialogs/NotesDialog.java

@@ -36 +36 @@
 import org.openstreetmap.josm.data.notes.NoteComment;
 import org.openstreetmap.josm.data.osm.NoteData;
+import org.openstreetmap.josm.data.osm.NoteData.NoteDataUpdateListener;
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.MapFrame;
@@ -55 +56 @@
  * @since 7608 (creation)
  */
-public class NotesDialog extends ToggleDialog implements LayerChangeListener {
+public class NotesDialog extends ToggleDialog implements LayerChangeListener, NoteDataUpdateListener {
 
     private NoteTableModel model;
@@ -155 +156 @@
             model.setData(noteData.getNotes());
             setNotes(noteData.getSortedNotes());
+            noteData.addNoteDataUpdateListener(this);
         }
     }
@@ -161 +163 @@
     public void layerRemoving(LayerRemoveEvent e) {
         if (e.getRemovedLayer() instanceof NoteLayer) {
+            noteData.removeNoteDataUpdateListener(this);
             noteData = null;
             model.clearData();
@@ -173 +176 @@
     public void layerOrderChanged(LayerOrderChangeEvent e) {
         // ignored
+    }
+
+    @Override
+    public void noteDataUpdated(NoteData data) {
+        setNotes(data.getSortedNotes());
+    }
+
+    @Override
+    public void selectedNoteChanged(NoteData noteData) {
+        selectionChanged();
     }