Changeset 12642 in josm

Timestamp:

2017-08-25T03:29:37+02:00 (7 years ago)

Author:

Don-vip

Message:

see #15182 - deprecate Main.main.panel. Replacement: gui.MainApplication.getMainPanel()

Location:

trunk

Files:

• src/org/openstreetmap/josm/Main.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/ImageryMenu.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/MainApplication.java (modified) (4 diffs)
• src/org/openstreetmap/josm/gui/datatransfer/OsmTransferHandler.java (modified) (3 diffs)
• test/unit/org/openstreetmap/josm/JOSMFixture.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/gui/MainApplicationTest.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/Main.java

@@ -150 +150 @@
     /**
      * The main panel.
+     * @deprecated Use {@link MainApplication#getMainPanel} instead
      * @since 12125
      */
+    @Deprecated
     public MainPanel panel;
 

trunk/src/org/openstreetmap/josm/gui/ImageryMenu.java

@@ -198 +198 @@
         JMenu subMenu = Main.main.menu.imagerySubMenu;
         int heightUnrolled = 30*(getItemCount()+subMenu.getItemCount());
-        if (heightUnrolled < Main.main.panel.getHeight()) {
+        if (heightUnrolled < MainApplication.getMainPanel().getHeight()) {
             // add all items of submenu if they will fit on screen
             int n = subMenu.getItemCount();

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -136 +136 @@
 
     /**
-     * The same panel as {@link Main#panel}, required to be static for {@link MapFrameListener} handling.
+     * The main panel, required to be static for {@link MapFrameListener} handling.
      */
     static MainPanel mainPanel;
@@ -165 +165 @@
 
     /**
+     * Provides access to the layers displayed in the main view.
+     */
+    private static final MainLayerManager layerManager = new MainLayerManager();
+
+    /**
      * The commands undo/redo handler.
      * @since 12641 (as a replacement to {@code Main.main.undoRedo})
      */
-    public static final UndoRedoHandler undoRedo = new UndoRedoHandler();
-
-    /**
-     * Provides access to the layers displayed in the main view.
-     */
-    private static final MainLayerManager layerManager = new MainLayerManager();
+    public static final UndoRedoHandler undoRedo = new UndoRedoHandler(); // Must be declared after layerManager
 
     /**
@@ -271 +271 @@
 
     @Override
+    @SuppressWarnings("deprecation")
     protected void initializeMainWindow() {
         if (mainFrame != null) {
-            panel = mainFrame.getPanel();
+            mainPanel = mainFrame.getPanel();
+            panel = mainPanel;
             mainFrame.initialize();
             menu = mainFrame.getMenu();
         } else {
             // required for running some tests.
-            panel = new MainPanel(layerManager);
+            mainPanel = new MainPanel(layerManager);
+            panel = mainPanel;
             menu = new MainMenu();
         }
-        panel.addMapFrameListener((o, n) -> redoUndoListener.commandChanged(0, 0));
-        panel.reAddListeners();
+        mainPanel.addMapFrameListener((o, n) -> redoUndoListener.commandChanged(0, 0));
+        mainPanel.reAddListeners();
     }
 
@@ -365 +368 @@
     public static MapFrame getMap() {
         return map;
+    }
+
+    /**
+     * Returns the main panel.
+     * @return the main panel
+     * @since 12642 (as a replacement to {@code Main.main.panel})
+     */
+    public static MainPanel getMainPanel() {
+        return mainPanel;
     }
 

trunk/src/org/openstreetmap/josm/gui/datatransfer/OsmTransferHandler.java

@@ -10 +10 @@
 import java.util.Collections;
 
-import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.coor.EastNorth;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.datatransfer.importers.AbstractOsmDataPaster;
 import org.openstreetmap.josm.gui.datatransfer.importers.FilePaster;
@@ -72 +72 @@
      */
     public void pasteOn(OsmDataLayer editLayer, EastNorth mPosition, Transferable transferable) {
-        importData(new TransferSupport(Main.main.panel, transferable), editLayer, mPosition);
+        importData(new TransferSupport(MainApplication.getMainPanel(), transferable), editLayer, mPosition);
     }
 
@@ -81 +81 @@
     public void pasteTags(Collection<? extends OsmPrimitive> primitives) {
         Transferable transferable = ClipboardUtils.getClipboardContent();
-        importTags(new TransferSupport(Main.main.panel, transferable), primitives);
+        importTags(new TransferSupport(MainApplication.getMainPanel(), transferable), primitives);
     }
 

trunk/test/unit/org/openstreetmap/josm/JOSMFixture.java

@@ -140 +140 @@
     }
 
+    @SuppressWarnings("deprecation")
     private void setupGUI() {
         JOSMTestRules.cleanLayerEnvironment();
@@ -154 +155 @@
             if (Main.main.panel == null) {
                 initMainPanel(false);
-                Main.main.panel = MainApplicationTest.getMainPanel();
+                Main.main.panel = MainApplication.getMainPanel();
             }
             Main.main.panel.reAddListeners();

trunk/test/unit/org/openstreetmap/josm/gui/MainApplicationTest.java

@@ -80 +80 @@
      * @param reAddListeners {@code true} to re-add listeners
      */
+    @SuppressWarnings("deprecation")
     public static void initMainPanel(boolean reAddListeners) {
         if (MainApplication.mainPanel == null) {
@@ -90 +91 @@
             Main.main.panel = MainApplication.mainPanel;
         }
-    }
-
-    /**
-     * Returns {@link MainApplication#mainPanel} (not public).
-     * @return {@link MainApplication#mainPanel}
-     */
-    public static MainPanel getMainPanel() {
-        return MainApplication.mainPanel;
     }