Changeset 11453 in josm for trunk/src/org/openstreetmap/josm/data/imagery

Timestamp:

2017-01-12T01:38:04+01:00 (7 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:BED_BOGUS_EXCEPTION_DECLARATION - Correctness - Non derivable method declares throwing an exception that isn't thrown

Location:

trunk/src/org/openstreetmap/josm/data/imagery

Files:

• GetCapabilitiesParseHelper.java (modified) (2 diffs)
• TMSCachedTileLoader.java (modified) (2 diffs)
• WMSCachedTileLoader.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/imagery/GetCapabilitiesParseHelper.java

@@ -2 +2 @@
 package org.openstreetmap.josm.data.imagery;
 
-import java.io.IOException;
 import java.io.InputStream;
 import java.net.MalformedURLException;
@@ -75 +74 @@
      * @param in InputStream with pointing to GetCapabilities XML stream
      * @return safe XMLStreamReader, that is not validating external entities, nor loads DTD's
-     * @throws IOException if any I/O error occurs
      * @throws XMLStreamException if any XML stream error occurs
      */
-    public static XMLStreamReader getReader(InputStream in) throws IOException, XMLStreamException {
+    public static XMLStreamReader getReader(InputStream in) throws XMLStreamException {
         XMLInputFactory factory = XMLInputFactory.newFactory();
         // do not try to load external entities, nor validate the XML

trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoader.java

@@ -2 +2 @@
 package org.openstreetmap.josm.data.imagery;
 
-import java.io.IOException;
 import java.util.Map;
 import java.util.concurrent.ThreadPoolExecutor;
@@ -60 +59 @@
      * @param readTimeout       to remote resource
      * @param headers           HTTP headers to be sent along with request
-     * @throws IOException      when cache initialization fails
      */
     public TMSCachedTileLoader(TileLoaderListener listener, ICacheAccess<String, BufferedImageCacheEntry> cache,
-            int connectTimeout, int readTimeout, Map<String, String> headers) throws IOException {
+            int connectTimeout, int readTimeout, Map<String, String> headers) {
         CheckParameterUtil.ensureParameterNotNull(cache, "cache");
         this.cache = cache;

trunk/src/org/openstreetmap/josm/data/imagery/WMSCachedTileLoader.java

@@ -2 +2 @@
 package org.openstreetmap.josm.data.imagery;
 
-import java.io.IOException;
 import java.util.Map;
 
@@ -25 +24 @@
      */
     public static final IntegerProperty THREAD_LIMIT = new IntegerProperty("imagery.wms.loader.maxjobs", 3);
+
     /**
      * Creates a TileLoader with separate WMS downloader.
@@ -33 +33 @@
      * @param readTimeout from tile source
      * @param headers to be sent with requests
-     * @throws IOException when there is a problem creating cache repository
      */
     public WMSCachedTileLoader(TileLoaderListener listener, ICacheAccess<String, BufferedImageCacheEntry> cache,
-            int connectTimeout, int readTimeout, Map<String, String> headers) throws IOException {
+            int connectTimeout, int readTimeout, Map<String, String> headers) {
 
         super(listener, cache, connectTimeout, readTimeout, headers);