show changeset's source tag in history view

[maizzerna]

Since lately JOSM shows the edit comment in the history view. Good! However at the same time the source tag for changesets is encouraged to be used in the upload dialog. That leads to moving the source of an edit into this tag. So you cannot see the source in the history view. So, the history view should also show the source tag.

[Don-vip]

In 6827/josm:

fix #9659 - show changeset source in history dialog

[maizzerna]

Thank you Don-Vip! It shows now (latest version), but it is hardly distinguishable from the changeset "comment". You do not even know if there is a source tag or if it is all "comment". That especially applies if the "comment" fills its last line nearly completely. This could create funny sentences then.

What about this?

c: added new bollards to Churchstreet
s: survey

Tooltips for C and S with the full tag key ("comment", "source").

[Don-vip]

In 6836/josm:

fix #9659 - prefix changeset and source by "c:" or "s:" to distinguish them in history dialog

[maizzerna]

nice!!! thank you!

One small imperfection: the space for the source tag is always reserved (in fact even the tooltip shows up over the apparently empty space) if one of both (left or right) changesets has a source tag. The space should be made free if possible without much effort. Example:

 c: blaaaa blubb blaaaa blubb blaaaa       c: blubbblaa blubab blubbblaa
    blaaaa blubb blaaaa blubb blaaaa       s: eyeballed
    blaaaa blubb bla                            

 -----------------------------------       -----------------------------------
           Name        Value                          Name        Value       
             ...                                        ...

should be like this (without an empty line):

 c: blaaaa blubb blaaaa blubb blaaaa       c: blubbblaa blubab blubbblaa
    blaaaa blubb blaaaa blubb blaaaa       s: eyeballed
    blaaaa blubb bla                            
 -----------------------------------       -----------------------------------
           Name        Value                          Name        Value       
             ...                                        ...

[Don-vip]

Not so easy to fix as it may cause tables to be misaligned. Sorry, I'll let things like it.

[simon04]

In 6864/josm:

see #9659 - History dialog: improve i18n strings

[simon04]

Typographically, I'm not too happy with the lower-case "c" and "s" letters. What about having no label for the changeset comment, and writing "Source" for "s"? Not easy to come up with a perfect solution, I guess … :-)

[Don-vip]

In 6865/josm:

fix #9659 - better display of changeset source in history dialog