[PATCH] display bicycle=yes; foot=designated; highway=path in default paint style [path]

[mkoniecz]

[bicycle=designated; foot=designated; highway=path] is displayed as green and purple dashes

I suggest that

[bicycle=yes; foot=designated; highway=path] would be displayed with long green dashes and very short purple ones

and

[bicycle=designated; foot=yes; highway=path] would be displayed with long purple dashes and very short green ones

[mkoniecz]

Example of way that would be affected: ​http://www.openstreetmap.org/browse/way/239836501

Repository Root: ​http://josm.openstreetmap.de/svn
Build-Date: 2013-11-09 02:35:12
Last Changed Author: Don-vip
Revision: 6381
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: ​http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-11-08 14:41:01 +0100 (Fri, 08 Nov 2013)
Last Changed Rev: 6381

Identification: JOSM/1.5 (6381 en_GB) Windows 7 32-Bit
Memory Usage: 247 MB / 247 MB (69 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (29854)
Plugin: notes (v0.6)

[Klumbumbus]

The code for this would be (add it in elemstyle after line 599):

way[highway=cycleway][foot=yes],
way[highway=path][bicycle=designated][foot=yes],
way[highway=path][bicycle=official][foot=yes] {
    width: 1;
    realwidth: 2;
    color: bicycle#b100ff;
    dashes: 21,7;
    dashes-background-color: foot#00ff00;
}
way[highway=footway][bicycle=yes],
way[highway=path][bicycle=yes][foot=designated],
way[highway=path][bicycle=yes][foot=official] {
    width: 1;
    realwidth: 2;
    color: foot#00ff00;
    dashes: 21,7;
    dashes-background-color: bicycle#b100ff;
}

The result looks like in the picture:

[skyper]

Replying to Klumbumbus:

The code for this would be (add it in elemstyle after the block way[highway=path][bicycle=designated][foot=designated],
way[highway=path][bicycle=official][foot=official] which ends at the moment at line 599):

Thanks, but is it possible for you to supply a proper patch ? See wiki:DevelopersGuide/PatchGuide. Minimum would be an unified diff. Cheers

[Klumbumbus]

OK. I created a patch file. I hope this is correct, I didn't know about diff and patch before. Can you please check, if everything is ok with the patch file (I edited the first two lines manually)? What happens if someone edits the elemstyle.mapcss before this patch is executed? (The patchfile is not correct then anymore.)

[bastiK]

In 7172/josm:

applied #9258 - display bicycle=yes; foot=designated; highway=path in default paint style (patch by Klumbumbus)

[bastiK]

Replying to Klumbumbus:

OK. I created a patch file. I hope this is correct, I didn't know about diff and patch before.

Thanks, patch file was correct.

Can you please check, if everything is ok with the patch file (I edited the first two lines manually)? What happens if someone edits the elemstyle.mapcss before this patch is executed? (The patchfile is not correct then anymore.)

The patch software will try to apply it anyway. This works well, unless the same lines in the source file are changed.

[Klumbumbus]

Replying to bastiK:

The patch software will try to apply it anyway. This works well, unless the same lines in the source file are changed.

Fine. Thanks.