Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#9258 closed enhancement (fixed)

[PATCH] display bicycle=yes; foot=designated; highway=path in default paint style [path]

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 14.05
Component: Internal mappaint style Version:
Keywords: Cc:

Description

[bicycle=designated; foot=designated; highway=path] is displayed as green and purple dashes

I suggest that

[bicycle=yes; foot=designated; highway=path] would be displayed with long green dashes and very short purple ones

and

[bicycle=designated; foot=yes; highway=path] would be displayed with long purple dashes and very short green ones

Attachments (2)

dashes footway cycleway.png (6.4 KB) - added by Klumbumbus 5 years ago.
dashes cycleway footway.patch (848 bytes) - added by Klumbumbus 5 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 6 years ago by skyper

Component: Core imageryInternal mappaint style

comment:2 Changed 6 years ago by Don-vip

Summary: display [bicycle=yes; foot=designated; highway=path] in default paint styledisplay bicycle=yes; foot=designated; highway=path in default paint style

comment:3 Changed 6 years ago by mkoniecz

Example of way that would be affected: http://www.openstreetmap.org/browse/way/239836501

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-11-09 02:35:12
Last Changed Author: Don-vip
Revision: 6381
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-11-08 14:41:01 +0100 (Fri, 08 Nov 2013)
Last Changed Rev: 6381

Identification: JOSM/1.5 (6381 en_GB) Windows 7 32-Bit
Memory Usage: 247 MB / 247 MB (69 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (29854)
Plugin: notes (v0.6)

Changed 5 years ago by Klumbumbus

Attachment: dashes footway cycleway.png added

comment:4 Changed 5 years ago by Klumbumbus

The code for this would be (add it in elemstyle after line 599):

way[highway=cycleway][foot=yes],
way[highway=path][bicycle=designated][foot=yes],
way[highway=path][bicycle=official][foot=yes] {
    width: 1;
    realwidth: 2;
    color: bicycle#b100ff;
    dashes: 21,7;
    dashes-background-color: foot#00ff00;
}
way[highway=footway][bicycle=yes],
way[highway=path][bicycle=yes][foot=designated],
way[highway=path][bicycle=yes][foot=official] {
    width: 1;
    realwidth: 2;
    color: foot#00ff00;
    dashes: 21,7;
    dashes-background-color: bicycle#b100ff;
}

The result looks like in the picture:

Version 0, edited 5 years ago by Klumbumbus (next)

comment:5 Changed 5 years ago by anonymous

Summary: display bicycle=yes; foot=designated; highway=path in default paint styledisplay bicycle=yes; foot=designated; highway=path in default paint style [path]

comment:6 in reply to:  4 Changed 5 years ago by skyper

Replying to Klumbumbus:

The code for this would be (add it in elemstyle after the block way[highway=path][bicycle=designated][foot=designated],
way[highway=path][bicycle=official][foot=official]
which ends at the moment at line 599):

Thanks, but is it possible for you to supply a proper patch ? See wiki:DevelopersGuide/PatchGuide. Minimum would be an unified diff. Cheers

Changed 5 years ago by Klumbumbus

comment:7 Changed 5 years ago by Klumbumbus

OK. I created a patch file. I hope this is correct, I didn't know about diff and patch before. Can you please check, if everything is ok with the patch file (I edited the first two lines manually)? What happens if someone edits the elemstyle.mapcss before this patch is executed? (The patchfile is not correct then anymore.)

comment:8 Changed 5 years ago by Klumbumbus

Summary: display bicycle=yes; foot=designated; highway=path in default paint style [path][PATCH] display bicycle=yes; foot=designated; highway=path in default paint style [path]

comment:9 Changed 5 years ago by bastiK

Resolution: fixed
Status: newclosed

In 7172/josm:

applied #9258 - display bicycle=yes; foot=designated; highway=path in default paint style (patch by Klumbumbus)

comment:10 in reply to:  7 ; Changed 5 years ago by bastiK

Replying to Klumbumbus:

OK. I created a patch file. I hope this is correct, I didn't know about diff and patch before.

Thanks, patch file was correct.

Can you please check, if everything is ok with the patch file (I edited the first two lines manually)? What happens if someone edits the elemstyle.mapcss before this patch is executed? (The patchfile is not correct then anymore.)

The patch software will try to apply it anyway. This works well, unless the same lines in the source file are changed.

comment:11 in reply to:  10 Changed 5 years ago by Klumbumbus

Replying to bastiK:

The patch software will try to apply it anyway. This works well, unless the same lines in the source file are changed.

Fine. Thanks.

comment:12 Changed 5 years ago by Don-vip

Milestone: 14.05

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.