Modify

Opened 12 years ago

Closed 4 years ago

#8076 closed enhancement (fixed)

presets: merge "Towers" and "Communication Towers"

Reported by: skyper Owned by: team
Priority: normal Milestone: 20.09
Component: External preset Version:
Keywords: tower mast Cc: derstefan, iav, geozeisig, Alexander-II, stoecker

Description

We have two new presets:

They seem to have much in commen and there are some objects already in both. So I propose to merge these two presets.

Attachments (3)

Presets_TowerPreset.zip (4.9 KB ) - added by skyper 11 years ago.
merged Tower preset
Presets_Towers.zip (7.4 KB ) - added by Klumbumbus 4 years ago.
Presets_Communication_Towers.zip (4.1 KB ) - added by Klumbumbus 4 years ago.

Download all attachments as: .zip

Change History (21)

comment:1 by iav, 12 years ago

Generaly I just want to add one type to Jens Winbladh preset, but can't do it until xml hosted in wiki.

comment:2 by skyper, 11 years ago

I did try to merge them. Please, have a look at the attachment.

I am too tired to publish and we should remove the other two presets in advance.

by skyper, 11 years ago

Attachment: Presets_TowerPreset.zip added

merged Tower preset

comment:3 by iav, 11 years ago

I propose to change name="Transmitter (steel mast)" to "Antenna (steel mast)".

And add lightning tower:

                <item name="Lighting tower" dk.name="Forsvars tårn" ru.name="Осветительная вышка" icon="com_tower.png" type="node,closedway">
                        <link href="http://wiki.openstreetmap.org/wiki/Tag:man_made=tower"/>
                        <label text="Lighting tower" dk.name="Forsvars tårn" ru.name="Осветительная вышка" />
                        <key key="man_made" value="tower"/>
                        <key key="tower:type" value="lighting"/>
                        <text key="name" text="Name" dk.text="Navn" default="" delete_if_empty="true"/>
                        <space/>
                        <text key="ref" text="Ref" dk.text="Ref" default="" delete_if_empty="true"/>
                        <space/>
                        <text key="operator" text="Operator" dk.text="Operatør" default="" delete_if_empty="true"/>
                        <text key="height" text="Height" dk.text="Højde" default="" delete_if_empty="true"/>
                </item>
Last edited 10 years ago by Don-vip (previous) (diff)

in reply to:  3 comment:4 by skyper, 11 years ago

Replying to iav:

I propose to change name="Transmitter (steel mast)" to "Antenna (steel mast)".

+1

And add lightning tower:

Sorry, I did remove it as I did not find it in the wiki and was not sure about the differences to a lighthouse.

The key technology should be changed into a "multiselection" instead of a "combo"

Last edited 11 years ago by skyper (previous) (diff)

comment:5 by iav, 11 years ago

Lighting towers that not a lighthouses:
http://www.shayanbargh.com/images/DecoraviteLight/stadium-light-03.JPG
http://www.shayanbargh.com/images/DecoraviteLight/high_mast_tower_light3.jpg
Good landmarks.

http://taginfo.openstreetmap.org/keys/tower:type#values
currently 603 usage, but I suppose they will be much more if they be included into the presets

in reply to:  5 comment:6 by skyper, 11 years ago

Replying to iav:

Lighting towers that not a lighthouses:
http://www.shayanbargh.com/images/DecoraviteLight/stadium-light-03.JPG
http://www.shayanbargh.com/images/DecoraviteLight/high_mast_tower_light3.jpg
Good landmarks.

These are no lightning towers !

Maybe light towers but probably man_made=mast is better suited or lamp or even highway=street_lamp

This is about a lightning tower, but introducing this type of tower we definitely need a tag for small ones (e.g. no towers!), too.

Have a look at https://en.wikipedia.org/wiki/Lightning_rod.

http://taginfo.openstreetmap.org/keys/tower:type#values
currently 603 usage, but I suppose they will be much more if they be included into the presets

We need to change them if needed !

comment:7 by iav, 11 years ago

You are right, light towers, not lightning. Sorry, just my bad english knowledge.

But we need to differentiate highway light poles (not landmarks), and much higher masts or poles placed at stadiums and industrial areas - where they are landmarks, and, often, the one landmarks for a huge territory

Sure it's not a highway=lamps, at least because there no highway. But what it should be exactly?
I simply choose a man_made=tower, because it seems to me as good fit to http://wiki.openstreetmap.org/wiki/Tag:man_made=tower, and have some 100's usages.

in reply to:  7 comment:8 by skyper, 11 years ago

Replying to iav:

You are right, light towers, not lightning. Sorry, just my bad english knowledge.

Please, fix your preset and have a look at the so far tagged objects. Maybe some other user is using your preset.

But we need to differentiate highway light poles (not landmarks), and much higher masts or poles placed at stadiums and industrial areas - where they are landmarks, and, often, the one landmarks for a huge territory

+1

Sure it's not a highway=lamps, at least because there no highway. But what it should be exactly?
I simply choose a man_made=tower, because it seems to me as good fit to http://wiki.openstreetmap.org/wiki/Tag:man_made=tower, and have some 100's usages.

Did not think these are towers but masts, something like this:

man_made=mast
mast:type=light
light:type=*
light:colour=*

came to my mind.

The more I read + think about it the less am sure about this issue.

  • First, we need to define tower, mast and antenna.
    • As far as I understand wikipedia in English all free-standing structures are towers. Masts are tied with some guy wire/rope what we use antenna for, where as antenna would be only the part that is actually transmitting and/or receiving. This can lead that we have a communication tower with an observation deck with restaurant and on top a mast with several antennas for different types of communication. Have a look at Partially_guyed_tower.

As am also not a native speaker the best is probably to open a thread at tagging@.

comment:9 by Don-vip, 10 years ago

Ticket #7954 has been marked as a duplicate of this ticket.

comment:10 by skyper, 9 years ago

Despite the two external presets, the major tags like man_made=antenna/mast/pole deserve a place in the internal presets.

comment:11 by Don-vip, 6 years ago

Keywords: tower added

comment:12 by skyper, 4 years ago

Maybe, it is time to include tower and mast with more details in defaultpresets. See #10759 for mast.

comment:13 by skyper, 4 years ago

Cc: geozeisig Alexander-II added
Keywords: mast added

I added a complete preset for all kind of masts and towers, see Presets/MastAndTower (@geozeisig: Thanks for the icons).

Think we can deprecate the other two external presets. Opinions ?!

comment:14 by skyper, 4 years ago

Cc: stoecker added

@Dirk:
Are there any numbers about external tagging presets' popularity?

in reply to:  14 comment:15 by stoecker, 4 years ago

Replying to skyper:

@Dirk:
Are there any numbers about external tagging presets' popularity?

No. We only have a tracking for (activated) maps and plugins.

comment:16 by Klumbumbus, 4 years ago

Milestone: 20.09

Mast, tower and communication tower are now in the internal preset and we have the new combined external preset from skyper too. Lets remove the two old external presets mentioned in the ticket description in 3 months.

comment:17 by Klumbumbus, 4 years ago

Here are the two presets as zip for archiving. I'll delete the two pages tomorrow.

by Klumbumbus, 4 years ago

Attachment: Presets_Towers.zip added

by Klumbumbus, 4 years ago

comment:18 by Klumbumbus, 4 years ago

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.