compile error

[bastiK]

src/org/openstreetmap/josm/gui/MainApplication.java:29: package org.jdesktop.swinghelper.debug does not exist

[bastiK]

In [4721/josm]:

use builder pattern for ImageProvider (see #7192)

[jttt]

In [4722/josm]:

Fix #7192 compile error

[jttt]

Local build is fixed, I'm not sure about remote build, does it still use it's own script?

[bastiK]

Replying to jttt:

Local build is fixed,

I still get runtime error

I'm not sure about remote build, does it still use it's own script?

Yes. Is debug.jar supposed to get distributed as part of the release?

[bastiK]

Can we just copy ​this class? It doesn't seem to have any dependencies.

[jttt]

Well, I don't really like that every dependency is copied into source tree, it's already quite a mess with all those externals. On the other hand, build scripts obviously can't copy referenced classes into one big josm-custom.jar and this is only one class so I'll copy it.

[jttt]

In [4728/josm]:

Fix #7192: compile error

[stoecker]

Replying to jttt:

Well, I don't really like that every dependency is copied into source tree, it's already quite a mess with all those externals. On the other hand, build scripts obviously can't copy referenced classes into one big josm-custom.jar and this is only one class so I'll copy it.

They can do so. But they can't evaluate what is really needed, which is possible when code is in SVN and compiled. The release version should be as small as possible and thus drops everything which is not really required.

[jttt]

ProGuard can also optimize jar file by removing unused class (and optionally also methods and do other optimizations) and it works on compiled classes. There is already ant task in build.xml - dist-optimized - that should create similar jar as is done on server for official builds.

[stoecker]

Maybe we switch to ant in future. But currently I don't think it is necessary.

There is also one additional reason for using sources instead of jar files. I can see what a java file does, I can't do so for a jar file.