Opened 13 years ago
Closed 4 years ago
#6836 closed defect (duplicate)
unglue way: only keep memberships of turn restriction if selected way is part of.
| Reported by: | skyper | Owned by: | team |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Core | Version: | |
| Keywords: | unglue turn relation from via to | Cc: | simon04 |
Description (last modified by )
If I unglue a way at a node with role=via in turn restrictions its memberships are copied to the new node which breaks all turn relations (warning needed) and is wrong if the selected and unglued way is not part of the relation.
Please do not copy the node's memberships if the way is not part of the relation and warn if it is because user has to solve the problem manually.
Thanks
Attachments (2)
Change History (19)
comment:1 by , 11 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 11 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
Closed as duplicate of #4635.
comment:3 by , 5 years ago
| Keywords: | from via to added |
|---|---|
| Resolution: | duplicate |
| Status: | closed → reopened |
| Type: | enhancement → defect |
#4635 was about split, which works correctly. Unglue has indeed a problem.
by , 5 years ago
comment:4 by , 4 years ago
I wonder how you can unglue such a node without breaking the turn restrictions?
comment:5 by , 4 years ago
| Owner: | changed from to |
|---|---|
| Status: | reopened → needinfo |
comment:6 by , 4 years ago
Ah, in your example one can unglue way 453764535 as it is not part of a restriction relation.
I think the popup introduced #8838 is the solution for this problem, right?
Fixed?
follow-up: 9 comment:7 by , 4 years ago
No the popup should not be shown for w453764535 as it has nothing to do with the relations and the only solution is to not copy but keep the memberships on the existing node to not break the relations. Issue is similar or even the same as in #18670 but with a different type with own treatment.
For the other ways the situation is fixed.
comment:8 by , 4 years ago
| Owner: | changed from to |
|---|---|
| Status: | needinfo → new |
comment:9 by , 4 years ago
Replying to skyper:
No the popup should not be shown for
w453764535
Sorry, the popup should only show the tag part. E.g. delete all tags from node first and then unglue should not show a popup.
follow-up: 11 comment:10 by , 4 years ago
| Cc: | added |
|---|
I agree. In what situation do we actually want to add the membership to the new (or both) nodes? Was introduced for #8838.
Up to now I can only think of type=site relations which would not be broken.
comment:11 by , 4 years ago
Replying to GerdP:
I agree. In what situation do we actually want to add the membership to the new (or both) nodes? Was introduced for #8838.
Up to now I can only think of type=site relations which would not be broken.
I know relations for TMC Points, Old german import scheme and TMC Point, plus node relations.
I am not sure about enforcement.
comment:12 by , 4 years ago
OK, so we cannot remove that option. The current code shows the dialog before it is known that none of the relations will be changed. Not easy to change that.
follow-up: 14 comment:13 by , 4 years ago
Not easy to change that.
Unless we simply say that the dialog should ignore memberships where the role is "via".
comment:14 by , 4 years ago
Replying to GerdP:
OK, so we cannot remove that option. The current code shows the dialog before it is known that none of the relations will be changed. Not easy to change that.
No, please, do not remove the code!
Replying to GerdP:
Not easy to change that.
Unless we simply say that the dialog should ignore memberships where the role is "via".
That is the way to go, handle known types, properly, either by role or relation type or even both.
by , 4 years ago
| Attachment: | 6836.patch added |
|---|
comment:15 by , 4 years ago
The patch changes the code which check the selected node(s) so that memberships in type=restriction or type=connectivity relations are ignored as well as memberships where the role is "via". If any membership is found which doesn't match these criteria the dialog "Where should the memberships of this node be put?" is shown.
There are probably more relation types and roles, but I think those should be handled in new tickets.
comment:17 by , 4 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
This is really annoying.