Modify

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#6370 closed defect (fixed)

Reverter plugin is broken after core changes

Reported by: akks Owned by: Upliner
Priority: major Milestone:
Component: Plugin reverter Version:
Keywords: Cc:

Description

Now Reverter plugin throws NullPointerException instead of downloading changeset.
The same plugin version works ok at with JOSM rev 3965 (no not know, what exct revision broke it)

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-05-21 01:31:32
Last Changed Author: bastiK
Revision: 4091
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-05-20 11:39:10 +0200 (Fri, 20 May 2011)
Last Changed Rev: 4091

Identification: JOSM/1.5 (4091 ru)
Memory Usage: 47 MB / 989 MB (16 MB allocated, but free)
Java version: 1.6.0_23, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Windows XP
Dataset consistency test: No problems found

Plugin: reverter (25578)

java.lang.NullPointerException

at org.openstreetmap.josm.gui.progress.PleaseWaitProgressMonitor.close(PleaseWaitProgressMonitor.java:151)
at reverter.RevertChangesetAction$1.checkAndDownloadMissing(RevertChangesetAction.java:68)
at reverter.RevertChangesetAction$1.realRun(RevertChangesetAction.java:86)
at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:83)
at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:129)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

Attachments (0)

Change History (8)

comment:1 by akks, 13 years ago

4080 works, 4085 does not. Sorry, I have no more time these days..

Last edited 13 years ago by akks (previous) (diff)

comment:2 by akks, 13 years ago

Unfortunately, it's our 4081 - MultiFetchServerObjectReader changed its behaviour (?). Do not know, how to repair.

Version 1, edited 13 years ago by akks (previous) (next) (diff)

comment:3 by akks, 13 years ago

Reverter works OK if I use 4081 revision and MultiFetchServerObjectReader.java from 4080.
Stop working exactly after updating MultiFetchServerObjectReader.java to 4081.

comment:4 by bastiK, 13 years ago

Resolution: fixed
Status: newclosed

Method signatures in MultiFetchServerObjectReader slightly changed, so plugin needed recompile [o26047]. NPE is a little strange, but should work now.

comment:5 by akks, 13 years ago

All works OK. There is also plugin TrustOSM that use MultiFetchServerObjectReader, but I do not know, is it working - it does not even compile due to some character encoding problem. After adding utf8 it cannot be built too. I added ticket for authors to notice the possible problem.

comment:6 by skyper, 13 years ago

Resolution: fixed
Status: closedreopened

I can not revert node 1221699249 or 1221699431 of changeset 7826133.

I get no message but the node is not moved back to previous position.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-06-02 01:31:20
Last Changed Author: stoecker
Revision: 4114
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-06-01 22:23:11 +0200 (Wed, 01 Jun 2011)
Last Changed Rev: 4114

GET http://api.openstreetmap.org/api/capabilities... OK
Communications with http://api.openstreetmap.org/api established using protocol version 0.6.
loading plugin 'reverter' (version 26047)
Successfully loaded Bing attribution data.
GET http://api.openstreetmap.org/api/0.6/nodes?nodes=1221699431
GET http://api.openstreetmap.org/api/0.6/changeset/7826133
GET http://api.openstreetmap.org/api/0.6/changeset/7826133/download
GET http://api.openstreetmap.org/api/0.6/node/1221699431/1

Last edited 13 years ago by skyper (previous) (diff)

comment:7 by Upliner, 13 years ago

Resolution: fixed
Status: reopenedclosed

Fixed again by recompilation: [o26093]

in reply to:  7 comment:8 by skyper, 13 years ago

Replying to Upliner:

Fixed again by recompilation: [o26093]

Thanks a lot for the fast fix.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Upliner.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.