Opened 14 years ago
Closed 11 years ago
#4077 closed defect (fixed)
[patch] Unsaved changes pops up when closing josm after undoing all changes
| Reported by: | Daeron | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | Core | Version: | latest |
| Keywords: | Cc: | dieterdreist, jstein |
Description (last modified by )
If there are some modifications made to the data, and all of them are undone, josm still pops up a dialog asking about "unsaved changes" when closing josm. However, if the same layer is deleted, the dialog doesn't appear.
Attachments (2)
Change History (9)
comment:1 Changed 12 years ago by
comment:3 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | Usaved changes pops up when closing josm after undoing all changes → Unsaved changes pops up when closing josm after undoing all changes |
comment:5 Changed 12 years ago by
| Cc: | dieterdreist jstein added |
|---|
Changed 11 years ago by
| Attachment: | 4077.patch added |
|---|
Changed 11 years ago by
| Attachment: | new-layer-modify.patch added |
|---|
comment:6 Changed 11 years ago by
| Summary: | Unsaved changes pops up when closing josm after undoing all changes → [patch] Unsaved changes pops up when closing josm after undoing all changes |
|---|
Patch attached (4077.patch), which hides the "Unsaved changes" dialog if JOSM is to be closed and the data of the layer isn't modified. Works like the delete action in the layer dialog. Unfortunately, the issue with the asterisk in the window title still remains.
There was another problem, which I fixed with patch new-layer-modify.patch: if only new primitives were created in a layer, the data in this layer wasn't marked as modified. I changed this, so that the addition of new primitives marks them as modified. Because I'm new to JOSM development, could some long-term dev review this approach, please?
Ticket #6509 has been marked as a duplicate of this ticket.