id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
24034	Add {apikey} support for TIGER Roads 2023	CAM-Gerlach	team	"First off, thanks for all your work to create and maintain JOSM as such an awesome tool! As one of the open source maintainers of a community-developed GUI application myself (and a silly programming language), I can only imagine how much time and effort has gone  into the ≈two decades of JOSM development to build and maintain an indispensable part of OSM. Cheers!

The imagery wiki data needed an update to add the latest TIGER Roads 2023 QA overlay (as the latest listed currently is 2022), that iD has had for quite a while now. I verified the URL and existing parameters work in JSOM locally (minus {{{ apikey }}}, which I had to temporarily hardcoded to the iD value), and added the updated TIGER Roads 2023 to the [https://josm.openstreetmap.de/wiki/Maps/USA%20Country Maps of USA Country] wiki page based off the previous years data with the necessary updates, cross-checking it against the previous year's config and matching parameters in iD (e.g. bounds, etc). 

However, given it uses {{{ apikey }}} since #18726 , I figured it needs an update the JOSM web service to retrieve the keys, which (understandably) I'm not able to do. And indeed, I get an error dialog (attached) when attempting to add the new, wiki-derived TIGER Roads 2023 imagery from the Imagery menu to the layer stack in JOSM. Unfortunately, the exception text is frustratingly uncopyable (might want to flip whatever flag in the dialog object controls that for easier debugging :) ) but I've manually transcribed it here as well as attaching an image:

{{{
java.lang.IllegalArgumentException: java.lang.NullPointerException: Cannot invoke ""String.length()"" because <parameter2> is null
}}}

To my Java- and JOSM-codebase-naïve eye it seems generally consistent with an error either retrieving or inserting {{{ apikey }}} due to it not being  being sent from the server (or, that imagery ID not being present in some internal data structure).

I've been able to add/update other wiki imagery just fine as well as use the imagery from the same URL except with hardcoded API key (locally, not added to wiki ofc). Additionally, I've carefully checked for any other issues in the XML I added, specifically deltas from the previous I copy-pasted and updated that worked fine, but found nothing.

Therefore, opening this ticket so hopefully whoever is able to can make the appropriate change(s) can be made to get this working. Thanks!"	defect	new	normal		Core imagery			api key apikey mapkey	stoecker