id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
23465	Remove custom checkstyle plugin	taylor.smock	team	"source:trunk/tools/checkstyle/src/org/openstreetmap/josm/TopLevelJavadocCheck.java is duplicating functionality from [https://checkstyle.sourceforge.io/checks/javadoc/missingjavadoctype.html#MissingJavadocType MissingJavadocType]. Our custom class is from #14794 (closed 2017-10-16). The check that makes it redundant was added in checkstyle 8.20 (released 2019-04-28).

The additional locations are found with the new check (it looks for all public classes by default):
{{{
[checkstyle] [WARN] src/org/openstreetmap/josm/actions/JoinAreasAction.java:105:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/actions/JoinAreasAction.java:237:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/data/osm/Filter.java:95:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/conflict/pair/AbstractListMergeModel.java:834:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/dialogs/relation/sort/WayConnectionType.java:35:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/io/CustomConfigurator.java:378:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/io/SaveLayersModel.java:24:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/layer/ImageryLayer.java:195:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/layer/JumpToMarkerActions.java:126:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/layer/JumpToMarkerActions.java:142:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/layer/markerlayer/MarkerLayer.java:622:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/mappaint/StyleSetting.java:121:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/mappaint/mapcss/ExpressionFactory.java:42:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/mappaint/mapcss/ExpressionFactory.java:47:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java:242:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/preferences/map/TaggingPresetPreference.java:191:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/preferences/projection/CustomProjectionChoice.java:141:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/gui/util/MultikeyShortcutAction.java:16:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/io/session/SessionReader.java:450:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/tools/template_engine/Tokenizer.java:16:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] src/org/openstreetmap/josm/tools/template_engine/Tokenizer.java:49:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/PluginServer.java:27:1: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/PluginServer.java:28:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/PluginServer.java:228:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/AssertionsInEDT.java:24:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/FakeImagery.java:116:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/HTTPS.java:33:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/LayerManager.java:27:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/Logging.java:16:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/MapPaintStyles.java:28:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/MeasurementSystem.java:44:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/OsmApi.java:33:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/OsmApi.java:42:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/ProjectionNadGrids.java:30:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/ResetUniquePrimitiveIdCounters.java:39:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/TaggingPresets.java:34:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/TestUser.java:35:5: Missing a Javadoc comment. [MissingJavadocType]
[checkstyle] [WARN] test/unit/org/openstreetmap/josm/testutils/annotations/Timezone.java:23:5: Missing a Javadoc comment. [MissingJavadocType]
}}}"	defect	closed	normal	24.02	Core		fixed