id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
22343	Warn about junction=roundabout with oneway=no	Famlam	team	"==== What steps will reproduce the problem?
1. Validate attached example. The northern part of the cycleway is bi-directional (`oneway=no`). Such a case cannot fulfill the requirements of `junction=roundabout` (With bi-directional traffic, there must be a ""yield"" for one of the traffic flows or there will be a conflict between incoming/outgoing traffic and traffic remaining on the roundabout, so the roundabout would never have the complete right of way as required for a `junction=roundabout`). In this example, the Dutch traffic rules require that counter-clockwise traffic must yield for the traffic coming from the sides). 
In addition, it conflicts with the implied `oneway=yes`.

==== What is the expected result?
Warn about `junction=roundabout` being used with `oneway=no`. Propose to use `junction=circular` instead

==== What happens instead?
No warning

==== Please provide any additional information below. Attach a screenshot if possible.
Proposed rule:
{{{
#!rule
way[junction=roundabout][oneway?!] {
  throwWarning: tr(""{0} together with {1}"", ""{0.tag}"", ""{1.tag}"");
  group: tr(""suspicious tag combination"");
  suggestAlternative: ""junction=circular"";
}
}}}


{{{
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-08-29 16:59:00 +0200 (Mon, 29 Aug 2022)
Build-Date:2022-08-30 01:30:57
Revision:18543
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18543 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19044)
Memory Usage: 868 MB / 1820 MB (633 MB allocated, but free)
Java version: 1.8.0_341-b10, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: nl_NL
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35924)
+ SimplifyArea (35978)
+ imagery_offset_db (35978)
+ pbf (35978)
+ pt_assistant (1ff2e15)
+ reverter (36011)
+ tageditor (36011)
+ turnlanes-tagging (v0.0.5)
+ undelete (36011)
+ utilsplugin2 (36011)

Tagging presets:
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Presets/NL-Fiets.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ https://raw.githubusercontent.com/Famlam/OsmMapcssValidationNL/main/netherlands.validator.mapcss

Last errors/warnings:
- 00008.803 E: Lokaliseren van afbeelding 'bus.png' mislukt
}}}
"	enhancement	new	normal		Core validator			template_report circular roundabout oneway