id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
21197	[PATCH] plugins `build-common.xml` should use `plugin.version` if it is defined	taylor.smock	Don-vip	"I noticed this when we updated `auto_tools` today (see https://github.com/JOSM/auto-tools/releases/tag/v1.3.4 and compare that version to the one on https://josm.openstreetmap.de/wiki/Plugins (`79`)).

{{{#!diff
diff --git a/plugins/build-common.xml b/plugins/build-common.xml
index 0c20dacb0..f8392f1c2 100644
--- a/plugins/build-common.xml
+++ b/plugins/build-common.xml
@@ -180,7 +180,8 @@
         </delete>
         <manifest file=""${manifest}"" mode=""update"">
             <attribute name=""Plugin-Mainversion"" value=""${plugin.main.version}""/>
-            <attribute name=""Plugin-Version"" value=""${version.entry.commit.revision}""/>
+            <attribute name=""Plugin-Version"" value=""${version.entry.commit.revision}"" unless:set=""plugin.version""/>
+            <attribute name=""Plugin-Version"" value=""${plugin.version}"" if:set=""plugin.version""/>
             <attribute name=""Plugin-Class"" value=""${plugin.class}"" />
             <attribute name=""Plugin-Description"" value=""${plugin.description}"" />
             <attribute name=""Plugin-Date"" value=""${version.entry.commit.date}"" />
}}}"	defect	closed	normal		Plugin		fixed