Add contrast/gamma/... on image viewer

[StephaneP]

Hi!

Sometimes street images can be too dark. It would be nice if the filters available on the aerial images could be available on the images viewer too. This, with an option to keep the setting when switching from one image to another.

Example with some filters (gamma, shadows highlight...) from ​Jpegview (GPL) :

[anonymous]

This would be awesome to have, although I wish that eventually there's a way to save those changes pwith the imagery provider

[StephaneP]

Nice!

[skyper]

+1, yes, nice.

Why not include single colors (RGB), too?
Are there plans to save the settings in order to reuse it for the next images or the next session?

[simon04]

The color filter sets the corresponding color on the data layer which influences its rendering. There is no such concept for photos. To be honest, I don't see why this would be useful. Would you take a picture of a rainbow flag and view it in blue only? Or take a picture of a lake and transform it to a volcano red? ;-)

[skyper]

Please, take color blindness into you thoughts. Contrast alone does not work in all cases and, yes, I would like to work with bluish images if I could see more details.

[simon04]

I haven't found a single ticket concerning "accessibility" or "blindness". I don't want to spend a lot of time on features that might make JOSM more accessible without any bigger picture or user feedback first.

[simon04]

In 17740/josm:

fix #20659 - Add contrast/gamma/... on image viewer

[simon04]

In 17741/josm:

see #20659 - Extract LayerVisibilityAction.ColorSelector.getColors

[StephaneP]

I'm testing Josm 17755. My comments:

• I like that!! Thanks!
• Colorfulness doesn't change the image colors
• pressing the alt key close the window. Is it a normal behaviour?
• We can't move the window. IMHO it's not a big deal on a large screen.

More important: There is no easy way to enable/disable these corrections. Is it possible to add a control on the image viewer, to enable/disable them?

[Klumbumbus]

Replying to StephaneP:

• pressing the alt key close the window. Is it a normal behaviour?

Yes, it is the same with all other "popup dialogs".

[Klumbumbus]

Replying to StephaneP:

• Colorfulness doesn't change the image colors

For me as well.

[StephaneP]

Hi!

When the image is modified with one of the settings, pan and zoom becomes very slow.

[simon04]

In 17828/josm:

see #20659 - Image viewer: apply filters when loading, not when rendering

This fixes:

• ineffective colorfulness filter
• performance when panning/zooming

[StephaneP]

Replying to simon04:
Thank you simon04 !

I have one question : does these filters could slow down Josm when we scroll fast thru an image sequence like I described on #20799?

[simon04]

They should not as implementations of org.openstreetmap.josm.tools.ImageProcessor#process return the original image unless their value/slider has been changed.

[Don-vip]

In 18018/josm:

fix #21104 - see #20659 - Image viewer: fix tooltips and icon size, hide layer-specific visibility checkbox