Convert building:roof:shape to roof:shape [PATCH]

[mkoniecz]

What steps will reproduce the problem?

1. Create area with building:roof:shape
2. Run validator

What is the expected result?

Autofix request into roof:shape

What happens instead?

Nothing

Please provide any additional information below. Attach a screenshot if possible.

Wiki page: ​https://wiki.openstreetmap.org/wiki/Key:building:roof:shape

discussion on tagging: ​https://lists.openstreetmap.org/pipermail/tagging/2021-January/thread.html#58944 ( ​https://lists.openstreetmap.org/pipermail/tagging/2021-January/058944.html )

it is used 98k times, roof:shape is used 3348k times.

equivalent iD ticket: ​https://github.com/openstreetmap/id-tagging-schema/issues/117

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-01-09 17:11:18 +0100 (Sat, 09 Jan 2021)
Revision:17451
Build-Date:2021-01-10 02:30:49
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17451 en_GB) Linux Ubuntu 20.04.1 LTS
Memory Usage: 318 MB / 976 MB (182 MB allocated, but free)
Java version: 11.0.9.1+1-Ubuntu-0ubuntu1.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.9.1+1-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
Environment variable LANG: en_GB.UTF-8
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ reverter (35640)
+ todo (30306)

[mkoniecz]

From 17d263dc20f1f1877b4133053e9972a2e2ece0da Mon Sep 17 00:00:00 2001
From: Mateusz Konieczny <matkoniecz@gmail.com>
Date: Wed, 17 Feb 2021 09:16:48 +0100
Subject: [PATCH] building:roof:shape -> roof:shape #12205

---
 resources/data/validator/deprecated.mapcss | 7 +++++++
 resources/data/validator/ignoretags.cfg    | 1 +
 2 files changed, 8 insertions(+)

diff --git a/resources/data/validator/deprecated.mapcss b/resources/data/validator/deprecated.mapcss
index e5420bad8..d729084e1 100644
--- a/resources/data/validator/deprecated.mapcss
+++ b/resources/data/validator/deprecated.mapcss
@@ -2034,6 +2034,13 @@ way[bicycle:oneway] {
   fixChangeKey: "building:min_height => min_height";
   group: tr("deprecated tagging");
 }
+/* #12205 */
+*[building:roof:shape] {
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "roof:shape";
+  group: tr("deprecated tagging");
+  fixChangeKey: "building:roof:shape => roof:shape";
+}
 
 /* #11232 */
 way[highway][construction=yes][highway!=construction] {
diff --git a/resources/data/validator/ignoretags.cfg b/resources/data/validator/ignoretags.cfg
index 1ffc7a33f..c4f99241d 100644
--- a/resources/data/validator/ignoretags.cfg
+++ b/resources/data/validator/ignoretags.cfg
@@ -703,6 +703,7 @@ E:kp
 E:pk
 K:amenity=embassy
 K:shoulder=none
+E:building:roof:shape
 ;
 ; Tags not yet decided (to remove from this section when added or moved up when deprecated) 
 ; see josm tickets: 17770 15309 15774 16315 16658 16793
-- 
2.30.0

[skyper]

Ping

[Klumbumbus]

In 17942/josm:

fix #20434 - Deprecate building:roof:shape in favor of roof:shape (patch by mkoniecz)

[Klumbumbus]

(From your patch I fixed the ticket number in the comment an changed {0.tag} to {0.key}.)

[mkoniecz]

Thanks!

[anonymous]

Replying to simon04: