Tagging presets: Possibility to set "match" negative

[skyper]

I need an option to exclude generic presets from Tags/Memberships panel and only show specific ones if objects contain certain tags. See wiki:Presets/MastAndTower for a real life example and ticket:6157:josm_6157_Preset_Debug.zip​ for a condensed one.

What steps will reproduce the problem?

1. Have a general preset and a specific preset for the same main tag with both including same secondary tags
2. Add main tag to object
3. Add secondary tag to object

What is the expected result?

• After 2. the general preset is linked to from Tags/Memberships panel
• After 3. only the specific preset is linked

What happens instead?

After 3. generic and specific presets both are linked

Please provide any additional information below. Attach a screenshot if possible.

I could live with match="false" for now but I wonder how I could add a tag not present in the preset to match negative.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-30 07:18:28 +0200 (Mon, 30 Mar 2020)
Revision:16220
Build-Date:2020-03-30 23:25:33
URL:https://josm.openstreetmap.de/svn/trunk

[simon04]

For relation <role>s, we use member_expression to test for matches. Would a similar attribute be helpful for a preset <item> as well?

[skyper]

Well for keys within the preset match="negKey/negKeyValue" or similar should work and looks much easier.

Overall a complete search expression is much more flexible and would cover the case that the key is not present in the preset.

[simon04]

I guess the crucial part of the example is the following:

<item name="General preset Tower">
  <key key="man_made" value="tower"/>
</item>
<item name="Small communication tower">
  <key key="man_made" value="tower"/>
  <key key="tower:type" value="communication"/>
</item>

For a node man_made=tower tower:type=communication only the second preset should match?

Where/how would you specify match="negKey/negKeyValue"?

[skyper]

Replying to simon04:

I guess the crucial part of the example is the following:

<item name="General preset Tower">
  <key key="man_made" value="tower"/>
</item>
<item name="Small communication tower">
  <key key="man_made" value="tower"/>
  <key key="tower:type" value="communication"/>
</item>

For a node man_made=tower tower:type=communication only the second preset should match?

Yes, this is without the key in the first item and the general approach.

Where/how would you specify match="negKey/negKeyValue"?

My preset looks like this:

<item name="General preset Tower">
  <key key="man_made" value="tower"/>
  <multiselect key="tower:type" text="Type of tower" values_searchable="true" values_sort="false" rows="11" match="negKey">
    <list_entry value="bell_tower" display_value="Bell tower" icon="Tower_bell_tower.svg" />
    <list_entry value="communication" display_value="Small communication tower" icon="Tower_cantilever_communication.svg" />
    <list_entry value="cooling" display_value="Cooling" icon="Tower_cooling.svg" />
  </multiselect>
</item>
<item name="Small communication tower">
  <key key="man_made" value="tower"/>
  <key key="tower:type" value="communication"/>
</item>

[skyper]

Replying to simon04:

For relation <role>s, we use member_expression to test for matches. Would a similar attribute be helpful for a preset <item> as well?

Definitely! Never used it, but it looks like the need extension also for preset links

I just noticed the problem is already present in defaultspresets, meanwhile. Have a look at a bus stop with bus=yes. The "Access Restriction" preset is linked.

[simon04]

In 17662/josm:

fix #19012 - Tagging presets: additional matching criteria via <item match_expression="...">

[skyper]

Thanks, so defaultpresets can profit from this for now, as my presets have to wait at least a few months, see #20667.

[skyper]

Add to documentation: Tagging Presets (diff)

[skyper]

Does this work? See #20843.