Modify

Opened 4 years ago

Closed 4 years ago

#18886 closed enhancement (fixed)

OsmReader: refactor/simplify/improve

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 20.03
Component: Core Version:
Keywords: yourkit performance Cc:

Description


Attachments (0)

Change History (8)

comment:1 by simon04, 4 years ago

First finding: parsing https://download.geofabrik.de/europe/montenegro-latest.osm.bz2 spends 15s in org.openstreetmap.josm.data.osm.Node#updateDirectionFlags (nodes only) out of a total 149s for org.openstreetmap.josm.io.OsmReader#parse

comment:2 by simon04, 4 years ago

In 16077/josm:

see #18886 - Node.updateDirectionFlags: override to improve performance

comment:3 by simon04, 4 years ago

In 16080/josm:

see #18886 - AbstractReader.parseTimestamp: use LRU cache

Version 0, edited 4 years ago by simon04 (next)

comment:4 by Don-vip, 4 years ago

Owner: set to simon04
Status: assignednew

comment:5 by Don-vip, 4 years ago

While you're looking at JOSM performance, do you understand why the JOSM performance tests no longer work?
https://josm.openstreetmap.de/jenkins/job/JOSM-Performance/

They are broken for several months/years but I failed to understand why.

EDIT: the last successful build was with r13170: https://josm.openstreetmap.de/jenkins/job/JOSM-Performance/175/

EDIT2: I found again my call for help: https://josm.openstreetmap.de/ticket/15310#comment:43

Last edited 4 years ago by Don-vip (previous) (diff)

in reply to:  2 comment:6 by simon04, 4 years ago

Replying to simon04:

In 16077/josm:

see #18886 - Node.updateDirectionFlags: override to improve performance

Verified: reversing https://www.openstreetmap.org/way/246449783 still shows dialog for direction-dependent railway signals.

comment:7 by simon04, 4 years ago

Status: newassigned

comment:8 by simon04, 4 years ago

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.