id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
17786	Complain about misusing building key to describ building state (building=damaged, building=collapsed)	mkoniecz	team	"==== What steps will reproduce the problem?
1. Create closed way with `building=damaged` or `building=collapsed` tag
2. Run validator

==== What is the expected result?
Validator complains that `building` key should be used to store building type - for example building constructed as a church should have `building=church`

==== What happens instead?
Presets do not contain property value - Value 'collapsed' for key 'building' not in presets. (1)

==== Please provide any additional information below. Attach a screenshot if possible.
I am willing to implement a patch. I am unsure what, if anything, should be proposed as an alternative tagging.

{{{
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-06-03 22:39:22 +0200 (Mon, 03 Jun 2019)
Build-Date:2019-06-03 20:47:14
Revision:15158
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15158 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 481 MB / 869 MB (156 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1366x768
Maximum Screen Size: 1366x768
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35027)
+ buildings_tools (34982)
+ continuosDownload (82)
+ ejml (34908)
+ geotools (34908)
+ imagery_offset_db (34908)
+ jts (34908)
+ log4j (34908)
+ measurement (34977)
+ reverter (34999)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: Invalid jar file ''<josm.userdata>/plugins/reverter.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.userdata>/plugins/PicLayer.jar.new'' (exists: false, canRead: false)
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- E: Bad Request - org.openstreetmap.josm.gui.widgets.HtmlPanel[,0,0,0x0,invalid,layout=java.awt.BorderLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]
}}}
"	enhancement	new	normal		Core validator			template_report