Modify

Opened 5 years ago

Last modified 17 months ago

#17562 new enhancement

Changing/creating the preset for embassies, consulate and liaison

Reported by: Anakil Owned by: team
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: office diplomatic embassy consulate liaison Cc:

Description (last modified by Don-vip)

Hello,

I create this ticket as I'm not sure if I can change it myself or if only admin can change the default internal presets of JOSM. I did the same demand for ID editor so I re-use the text below.

I think that the validator could also suggest a change (as the old tagging scheme is being deprecated in favor of the new one. If i must do a ticket elsewhere, please tell me ! :-)


Since the new method of tagging embassies and consulate with office=diplomatic - WIKI link) has been approved end of last year (look at the accepted proposal), it should be useful to support this in ID editor preset. The old tag "amenity=embassy" is now in the process of being deprecated.

I think that the only existing preset is the embassy preset, and it should be changed as follow:

  • embassy : "office=diplomatic"+"diplomatic=embassy" (with the secondary tag "embassy=*" that get multiple possibilities if the mapper want to add further details - look here for the values.

Then, we need to create two other new presets :

  • One for consulate : office=diplomatic + diplomatic = consulate (+ consulate=* )
  • One for liaison : office=diplomatic + diplomatic = liaison (+ liaison=* ).

And of course, the others secondary tags common for the three categories :

  • diplomatic:services:non-immigrant_visas=[yes/no]
  • diplomatic:services:immigrant_visas=[yes/no]
  • diplomatic:services:citizen_services=[yes/no];
  • name=*
  • country=* (the two-character ISO 3166-1 alpha-2 code for the sending country or organization)
  • target=* (the two-character ISO 3166-1 alpha-2 code for the receiving (accrediting) country or organization)

For more information, the description is quite detailed on the wiki page.

Attachments (0)

Change History (7)

comment:1 by Anakil, 5 years ago

Description: modified (diff)

in reply to:  description comment:2 by Don-vip, 5 years ago

Description: modified (diff)

Thanks!

Replying to Anakil:

I'm not sure if I can change it myself or if only admin can change the default internal presets of JOSM.

What you can do by yourself for JOSM:

All other stuff (internal presets, map paint styles, validator checks) only JOSM developers can do.

comment:3 by Don-vip, 5 years ago

Keywords: office diplomatic embassy consulate liaison added

comment:4 by anonymous, 5 years ago

Ticket #17806 has been marked as a duplicate of this ticket.

comment:5 by anonymous, 5 years ago

Please do not motivate pointless retagging of much more popular tags.

comment:6 by k127, 5 years ago

Hi, I appended[1] the external preset list with Diplomatic and consular missions: [2].
Please consider this a starting point for later integration. Any contrib and feedback very welcome.

[1] https://josm.openstreetmap.de/wiki/PresetsSource?sfp_email=&sfph_mail=&action=diff&version=87&old_version=86&sfp_email=&sfph_mail=
[2] https://gitlab.com/k127/josm-presets/blob/master/diplomatic.xml

Version 0, edited 5 years ago by k127 (next)

comment:7 by skyper, 17 months ago

The major tags have been changed in r17468, see #20338.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to Anakil.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.