#17333 closed enhancement (fixed)
[Patch] Show last used tags in Add Tag Dialog
Reported by: | GerdP | Owned by: | GerdP |
---|---|---|---|
Priority: | normal | Milestone: | 19.03 |
Component: | Core | Version: | |
Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Create new data layer, add a node and press Alt+A to add a tag
- Add e.g. barrier=bollard and press Enter
- Press Alt+S to edit the tag value and change bollard to block
- Add a new node and press Alt+A
What is the expected result?
The dialog should show barrier=block as first entry
What happens instead?
barrier=bollard is top
Please provide any additional information below. Attach a screenshot if possible.
Build-Date:2019-02-14 11:29:59 Revision:14786 Is-Local-Build:true Identification: JOSM/1.5 (14786 SVN en) Windows 10 64-Bit OS Build number: Windows 10 Home 1803 (17134) Memory Usage: 614 MB / 1753 MB (254 MB allocated, but free) Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Screen: \Display0 1920x1080 Maximum Screen Size: 1920x1080 VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:51784, -ea, -Dfile.encoding=UTF-8] Program arguments: [--debug] Dataset consistency test: No problems found Plugins: + OpeningHoursEditor (34867) + apache-commons (34506) + buildings_tools (34867) + continuosDownload (82) + download_along (34869) + ejml (34389) + geotools (34513) + jaxb (34678) + jts (34524) + o5m (34867) + opendata (34867) + pbf (34867) + poly (34867) + reltoolbox (34867) + reverter (34867) + undelete (34883) + utilsplugin2 (34867) Last errors/warnings: - W: No configuration settings found. Using hardcoded default values for all pools.
Attachments (2)
Change History (12)
by , 5 years ago
Attachment: | 17333.patch added |
---|
comment:1 by , 5 years ago
comment:3 by , 5 years ago
Please additionally change some translatable strings in this file
@@ -687,5 +687,5 @@ protected AddTagsDialog() { - super(Main.parent, tr("Add value?"), tr("OK"), tr("Cancel")); + super(Main.parent, tr("Add Tag"), tr("OK"), tr("Cancel")); setButtonIcons("ok", "cancel"); setCancelButton(2); configureContextsensitiveHelp("/Dialog/AddValue", true /* show help button */); @@ -712,5 +712,5 @@ - mainPanel.add(new JLabel(tr("Please select a value")), GBC.eol()); + mainPanel.add(new JLabel(tr("Choose a value")), GBC.eol()); values.setEditable(true); mainPanel.add(values, GBC.eop().fill(GBC.HORIZONTAL));
This will reduce the workload for translators because all new strings are already in use in JOSM:
"Add Tag" in source:/josm/trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java#L1089
"Choose a value" in source:/josm/trunk/src/org/openstreetmap/josm/gui/conflict/tags/MultiValueCellEditor.java#L224
by , 5 years ago
Attachment: | 17333-v2.patch added |
---|
comment:4 by , 5 years ago
Milestone: | → 19.03 |
---|
Sorry for the delay. I'll commit v2 after release of 19.2.
comment:5 by , 5 years ago
Owner: | changed from | to
---|
follow-up: 10 comment:8 by , 5 years ago
This is a pretty major change (it is possibly the most used dialog in JOSM). That will be on the startup page of next release.
comment:9 by , 5 years ago
I see it more as a bug fix ;)
I don't see a need documment this change in the Wiki, I think it already describes what is now implemented.
Oops, of course the screen shot is outaged now.
comment:10 by , 5 years ago
Replying to Klumbumbus:
That will be on the startup page of next release.
This is a very minor change, not fit to be listed there.
The patch just changes the behaviour. Maybe the dialog should also be changed to show "Recently used tags" instead of "Recently added tags"?