[Patch] Show actual path to preferences.xml and other directories used by JOSM

[GerdP]

Sometimes we tell users to remove/rename the preferences.xml but some users have difficulties to find the file. It seems JOSM doesn't show the actual path to that file anywhere. Maybe the status report should contain it so that we can tell the user where to search for it.
It would also be good to find that information via Help -> About

[Klumbumbus]

The path is anonymized in the status report by design to protect the users privacy.
A button "Open profile folder" in the status report window or in the about window would be better. I think the statusreport window fits better. (Thats how firefox does it: ​https://www.dev2qa.com/change-firefox-profile-using-webdriver/)

[GerdP]

In Eclipse you find a button "Installation Details" in the "About Eclipse" popup, but it's probably easier to add the info to the status report. I'll try to code that.

[GerdP]

Off topic: Would it be difficult to produce a MacOS package for the "latest" version?

[GerdP]

Hmm, both "Show Status Report" and "Report bug" use the same methods to anonymize the data.
I don't dare to change that. I've also noticed a possible bug: The method
ShowStatusReportAction.paramReplace() is called twice in paramCleanup():

        val = paramReplace(val, envJavaHome, envJavaHomeAlt);
        val = paramReplace(val, envJavaHome, envJavaHomeAlt);

Any idea why?

[GerdP]

Add tab "Installation Detais" to About JOSM popup

[GerdP]

Please try the simple patch on Linux / MacOS. On Windows it looks like this

[Don-vip]

It would be nice to replace this new text field by a table, and in the last column add a new browse button to directly open the related folder.

[Don-vip]

Replying to GerdP:

The method ShowStatusReportAction.paramReplace() is called twice in paramCleanup():

        val = paramReplace(val, envJavaHome, envJavaHomeAlt);
        val = paramReplace(val, envJavaHome, envJavaHomeAlt);

Any idea why?

Introduced in r10138. probably a copy/paste mistake, it looks safe to remove one line. Can you please do it while fixing this ticket?

[GerdP]

Replying to Don-vip:

It would be nice to replace this new text field by a table, and in the last column add a new browse button to directly open the related folder.

Yes, but I have no idea how. The popup was more or less my first self written Java Dialog ;)
Can you point me to an existing example in JOSM?

[simon04]

To get started with Swing tables, you could take a look at org.openstreetmap.josm.gui.preferences.imagery.CacheSettingsPanel and org.openstreetmap.josm.io.remotecontrol.AddTagsDialog. Basically you'll need a DefaultTableModel and a JTable.

[GerdP]

Replying to simon04:

To get started with Swing tables, you could take a look at org.openstreetmap.josm.gui.preferences.imagery.CacheSettingsPanel and org.openstreetmap.josm.io.remotecontrol.AddTagsDialog. Basically you'll need a DefaultTableModel and a JTable.

Thanks, please review my first attempt in 17192-v2.patch.

[simon04]

Looks good. A few remarks or improvement suggestions from my tests on Linux:

• The JFileChooser is somewhat useless. I'd expect a system file-manager to be opened. OpenBrowser.displayUrl("file://" + dir); does the trick (at least on Linux).
• If JAVA_HOME is unset: display "(unset)" in italic, and hide the open directory button

[GerdP]

On Windows OpenBrowser.displayUrl("file://" + dir); doesn't but OpenBrowser.displayUrl(new File(dir).toURI());
I assume that is also OK on Linux?

[GerdP]

17192-v3.patch implements the proposed changes. I'd prefer to be able to use copy with the displayed directory name and open the file in my preferred NC clone Totalcommander. How's that done?

[simon04]

Replying to GerdP:

OpenBrowser.displayUrl(new File(dir).toURI());
I assume that is also OK on Linux?

Yes.

Replying to GerdP:

17192-v3.patch implements the proposed changes. I'd prefer to be able to use copy with the displayed directory name and open the file in my preferred NC clone Totalcommander. How's that done?

You could try JosmTextArea (cf. org.openstreetmap.josm.actions.AboutAction#actionPerformed or an example usage) or UrlLabel.

[Don-vip]

I wouldn't use the "open" icon. Either "...", "Browse", or "Open location" would be better. Some spacing wouldn't hurt neither (increase the left/right insets when you add components)

[GerdP]

Hopefully final version

[simon04]

I like it the way it looks and works. A few details, though:

• please spell addInstLine in full w/o the abbreviation
• (unset) needs to be wrapped in tr()
• optional: visibility of org.openstreetmap.josm.actions.ShowStatusReportAction#paramCleanup(java.lang.String) could be changed to package
• Having JAVA_HOME unset, I get the following NPE:

2019-01-13 12:15:10.352 SEVERE: Handled by bug report queue: java.lang.NullPointerException
java.lang.NullPointerException
	at org.openstreetmap.josm.actions.ShowStatusReportAction.paramReplace(ShowStatusReportAction.java:256)
	at org.openstreetmap.josm.actions.ShowStatusReportAction.paramCleanup(ShowStatusReportAction.java:244)
	at org.openstreetmap.josm.actions.AboutAction.addInstLine(AboutAction.java:184)
	at org.openstreetmap.josm.actions.AboutAction.actionPerformed(AboutAction.java:123)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)

[GerdP]

In 14693/josm:

fix #17192 Add tab with installation details in "About" popup

[simon04]

Very nice, thank you!

[GerdP]

I've started to update the wiki help page and noticed that the implementation in r14693 doesn't work well when josm.pref and josm.userdata point to the same directory :(

I think about a better solution now.

[GerdP]

With 17192-v5.patch it looks like this on Windows:

Maybe I should move the line "Preferences are stored..." to the top?

[GerdP]

In 14701/josm:

fix #17192 Improve about installation details dialog

[stoecker]

You added lots of images, but didn't reference them in the wiki page Help/Action/About. Why? Should the old ones be replaced?

[GerdP]

See comment:21 Working on it...

[GerdP]

Done, please review. I did not yet update the translation screenshot because the corresponding text is not translated yet.
BTW: Who can I contact regarding spotbugs on Jenkins (#17206)?

[stoecker]

Replying to GerdP:

Done, please review. I did not yet update the translation screenshot because the corresponding text is not translated yet.

I removed your double files and replaced the original ones.

[GerdP]

Hmm, these screenshots don't show the new Installation Details tab. That's why I tried to update them.
How do you remove an attached screenshot via Trac?

[stoecker]

Replying to GerdP:

Hmm, these screenshots don't show the new Installation Details tab. That's why I tried to update them.

Try reload!

How do you remove an attached screenshot via Trac?

Files from other users can only be handled by admins. In this case simply attach the new one and mention to Klumbumbus, Vincent or me, that we should replace them. Files from yourself you can replace yourself (with a checkbox on upload).

[GerdP]

OK, reload worked. Thanks for the explanation.

[simon04]

In 14707/josm:

see #17192 - Harmonize "<unset>" with advanced preference

[Don-vip]

Ticket #17212 has been marked as a duplicate of this ticket.