#17050 closed enhancement (fixed)
[Patch] Refactor the GeoImageLayer and related to use a Data class with a selection listener
Reported by: | francois2 | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 18.12 |
Component: | Core image mapping | Version: | |
Keywords: | Cc: |
Description (last modified by )
My goal is to add the ability to select multiple images in the geoimagelayer to be able to move them with the photoadjust plugin.
I started the work by moving the handle of the data to a new class ImageData with a selection listener. Most of the methods of the GeoImageLayer have been moved. The ImageViewerDialog now listen for the selection change. This remove the coupling with the GeoImageLayer.
I also fixed a few bugs with buttons on the ImageViewDialog
Attachments (5)
Change History (16)
by , 5 years ago
Attachment: | refactor_geoimagelayer.patch added |
---|
comment:1 by , 5 years ago
Summary: | Refactor the GeoImageLayer and related to use a Data class with a selection listener → [Patch] Refactor the GeoImageLayer and related to use a Data class with a selection listener |
---|
comment:2 by , 5 years ago
Component: | Core → Core image mapping |
---|
follow-up: 5 comment:3 by , 5 years ago
comment:4 by , 5 years ago
Milestone: | → 18.12 |
---|
comment:5 by , 5 years ago
Replying to Don-vip:
Wow impressive, thanks! Some feedback below:
Thanks!
- Can you please explain this change?
@@ -493,7 +544,7 @@ public final class ImageViewerDialog extends ToggleDialog implements LayerChange * @since 6392 */ public static GeoImageLayer getCurrentLayer() { - return getInstance().currentLayer; + return null; } /**
I forgot to remove it. I fixed that as well as removing some unused methods.
- Did you run
ant checkstyle pmd
to check the code style too?
Nope. I fixed a few warnings.
comment:6 by , 5 years ago
I'm working on a new patch to allow multiple image selection. In the meantime, I saw that the current patch broke the photoadjust plugin.
There is multiple options:
- wait until all patch are ready
- wait until I provide the patch to fix the photoadjust plugin
I prefer the 2. What do you think ?
by , 5 years ago
Attachment: | refactor_geoimagelayer_plugin.patch added |
---|
The patch on the photo adjust plugin
comment:8 by , 5 years ago
I updated the patch to add new methods to update the image and a new callback when the image(s)change.
It introduced a performance problem in the photoadjust plugin, as on each move the image dialog was refreshed. I fixed it by checking the osd update and doing nothing most of the time.
comment:9 by , 5 years ago
Description: | modified (diff) |
---|
Wow impressive, thanks! Some feedback below:
ant checkstyle pmd
to check the code style too?