Modify ↓

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16680 closed enhancement (fixed)

[PATCH] tests: PluginServer: fix for windows

Reported by: ris Owned by: team
Priority: minor Milestone: 18.09
Component: Unit tests Version:
Keywords: appveyor pluginserver ci Cc:

Description

​https://github.com/openstreetmap/josm/pull/33

Turns out that some arcane systems by Microsoft still use backslashes as path separators.

This should fix PluginHandlerJOSMTooOldTest and PluginPreferenceHighLevelTest on windows. Additionally there is a patch which tweaks appveyor.yml to upload the full detailed test results as an artefact on_finish whether tests were successful or not. Very useful.

And with this, appveyor is our first reliably-passing pre-merge CI.

(travis is also reliably-passing to some extent, but I've gone and additionally enabled non-headless mode in its build matrix, which doesn't pass fully, making a first glance at any travis build look like a complete failure...)

Attaching patches...

Change History (6)

by ris, 6 years ago

Attachment: v1-0001-appveyor-attempt-to-push-test-results-on_finish-r.patch​ added

by ris, 6 years ago

Attachment: v1-0002-PluginServer-ensure-jar-relative-path-is-stringif.patch​ added

comment:1 by Don-vip, 6 years ago

Resolution: → fixed
Status: new → closed

In 14179/josm:

fix #16680 - Unit tests: fix for windows (patch by ris)

comment:2 by Don-vip, 6 years ago

Milestone: → 18.09

Thanks!

comment:3 by ris, 6 years ago

Milestone: 18.09

I say reliably, but, still, AddNodeHandler, it would seem...

Version 0, edited 6 years ago by ris (next)

comment:4 by Don-vip, 6 years ago

Milestone: → 18.09

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.