﻿id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
16280	autofix for almost square check for buildings is suboptimal	Klumbumbus	marxin	"==== What steps will reproduce the problem?
1. validate attachment:6_node_building.osm
2. click autofix
3. repeat the above steps 24 times until the validator is finally happy

Even for simple 4 node buildings up to 4 consecutive validation steps are required. (attachment:4_node_building.osm)

The reason is that always only one node is moved. While this makes sense in some cases, more often this creates a new almost rectangular angle. Also it is always only one angle per building flagged by the validator.

The goal should be that after the autofix on a building this warning doesn't appear again and all almost rectangular angles are fixed.

{{{
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-05-09 21:51:30 +0200 (Wed, 09 May 2018)
Build-Date:2018-05-10 01:33:33
Revision:13722
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13722 de) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1709 (16299)
Memory Usage: 1315 MB / 3641 MB (890 MB allocated, but free)
Java version: 1.8.0_171-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest-mehr-RAM.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=1024m,4096m, -Djnlpx.splashport=57455, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found
}}}
"	defect	new	normal		Core validator			template_report building right square angle	marxin
