Opened 3 years ago

Closed 3 years ago

#15524 closed defect (fixed)

[PATCH] building=yes is described as residential building

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 17.12
Component: Internal preset Version:
Keywords: template_report Cc:

Description (last modified by Klumbumbus)

What steps will reproduce the problem?

  1. create way
  2. tag building=yes

What is the expected result?

Not described as residential building

What happens instead?

described as residential building

Please provide any additional information below. Attach a screenshot if possible.

Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-10-30 23:58:23 +0100 (Mon, 30 Oct 2017)
Build-Date:2017-10-31 02:33:18
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13064 en) Linux Ubuntu 16.04.3 LTS
Memory Usage: 934 MB / 934 MB (459 MB allocated, but free)
Java version: 1.8.0_151-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

+ OpeningHoursEditor (33185)
+ buildings_tools (33735)
+ lakewalker (33712)
+ reverter (33572)
+ undelete (33480)

Map paint styles:
- ${HOME}/Documents/install_moje/josm_style_sidewalks/Styles_Sidewalks-style.mapcss

Validator rules:
+ ${HOME}/Documents/install_moje/josm_validator/josm.validator.mapcss

Last errors/warnings:
- E: Socket closed
- W: Read timed out
- W: Read timed out
- W: Read timed out
- W: Read timed out
- W: Read timed out
- W: Read timed out
- W: Read timed out
- W: Read timed out
- W: Read timed out

Attachments (1)

Selection_016.png (4.5 KB) - added by mkoniecz 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by mkoniecz

Attachment: Selection_016.png added

comment:1 Changed 3 years ago by naoliv

Summary: building=yes is described as residential building[PATCH] building=yes is described as residential building

Have the generic building=yes only at the Building preset.
Also roof and farm (farm isn't exactly residential)

  • data/defaultpresets.xml

    67886788                  ru.href=""
    67896789                  uk.href="" />
    67906790            <space />
    6791             <combo key="building" text="Building" values="yes,roof,garage,garages,industrial,school,hangar,commercial,service,train_station,barn,stable,cabin,farm_auxiliary,transportation,greenhouse,office,university,college,hospital,kindergarten,manufacture,warehouse,retail,shed,storage_tank,supermarket,gasometer,silo,cowshed,construction,basilica,cathedral,chapel,church,temple,mosque,synagogue,transformer_tower,public,ruins" values_context="building" default="yes" match="keyvalue!" values_searchable="true" />
     6791            <combo key="building" text="Building" values="yes,roof,garage,garages,industrial,school,hangar,commercial,service,train_station,barn,stable,cabin,farm,farm_auxiliary,transportation,greenhouse,office,university,college,hospital,kindergarten,manufacture,warehouse,retail,shed,storage_tank,supermarket,gasometer,silo,cowshed,construction,basilica,cathedral,chapel,church,temple,mosque,synagogue,transformer_tower,public,ruins" values_context="building" default="yes" match="keyvalue!" values_searchable="true" />
    67926792            <optional>
    67936793                <text key="name" text="Name" />
    67946794                <combo key="building:levels" text="Levels" values="1,2,3,4,5,6,7,8,9,10,11" text_context="building" />
    68116811                  ru.href=""
    68126812                  uk.href="" />
    68136813            <space />
    6814             <combo key="building" text="Building" values="yes,residential,apartments,house,hotel,hut,bungalow,dormitory,terrace,detached,farm,roof" default="residential" match="keyvalue!" values_context="building" values_searchable="true" />
     6814            <combo key="building" text="Building" values="residential,apartments,house,hotel,hut,bungalow,dormitory,terrace,detached" default="residential" match="keyvalue!" values_context="building" values_searchable="true" />
    68156815            <optional>
    68166816                <text key="name" text="Name" />
    68176817                <combo key="building:levels" text="Levels" values="1,2,3,4,5,6,7,8,9,10,11" text_context="building" />
Version 0, edited 3 years ago by naoliv (next)

comment:2 Changed 3 years ago by Klumbumbus

The value "yes" was added to the residential building preset in r9392 to link it in the Tags/Membership dialog on the right, so you can switch from the default value "yes" to an more precise value by clicking the link there. I agree this is not an optimal solution but I think it is better than if only the building preset is linked there and not the residential building preset too. I think with the current match implementation (TaggingPresets) there is no better solution possible.

(However we should remove roof from the residential building preset as this is not the default value.)

comment:3 Changed 3 years ago by Klumbumbus

Description: modified (diff)

comment:4 Changed 3 years ago by Klumbumbus

In 13185/josm:

see #15524 - remove roof from residential preset

comment:5 Changed 3 years ago by Klumbumbus

Milestone: 17.12
Resolution: fixed
Status: newclosed

fixed for "roof"
wontfix for "yes"

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.