[Patch] GPS heat map should also support point clouds

[kidelo]

Disadvantage:
With current implementation of GPS heatmap mode the lines of tracks are highlighted only.
Sometimes it would be better to see the distribution of points instead of lines.

see ticket:13124

[kidelo]

Some news: Here an update for GPS heatmap with enhancements which I had in mind. Please check and give feedback.

NEW: Heat Map mode now supports two difference modes

• line based (for tracks and highways), legacy behavior since version 17.01
• point based (for detection of heat points in small areas), uses point clouds with random distribution for rendering.

NEW: Overlay Gain Adjustment

• value < 0, brightens saturated areas
• value > 0, increase visible structure of low density areas

NEW: Limitation of Visibility

• can be use to hide points with low density, view becomes clearer
• adjustable in range of 0..254

IMPROVED: 2x new color maps

• User -> Renamed to "User Normal"
• User Light, new user defined color mode with inverted color sweep

• Traffic Lights, looks like the traffic lights green-yellow-red

[kidelo]

Some Examples

1. Normal Line Draw mode vs. Point cloud mode - Large Area

2. Normal Line Draw mode vs. Point cloud mode - Small Area

3. Decreased- /Normal- / Increased Gain

4. All Values (draw >0) vs. Limit Level (here draw > 150)

[Don-vip]

In 11566/josm:

fix #14343 - GPS heat map should also support point clouds (modified patch by kidelo)

[Don-vip]

Thanks! :)

[Don-vip]

Why is the parameter abstractProperty not used?

    /**
     * Constructs a new {@code GpxDrawHelper}.
     * @param gpxData GPX data
     * @param abstractProperty The color to draw with
     * @since 10824
     */
    public GpxDrawHelper(GpxData gpxData, AbstractProperty<Color> abstractProperty) {
        data = gpxData;
        setupColors();
    }

[kidelo]

Replying to Don-vip:

Why is the parameter abstractProperty not used?

    /**
     * Constructs a new {@code GpxDrawHelper}.
     * @param gpxData GPX data
     * @param abstractProperty The color to draw with
     * @since 10824
     */
    public GpxDrawHelper(GpxData gpxData, AbstractProperty<Color> abstractProperty) {
        data = gpxData;
        setupColors();
    }

The ctor parameter was introduced in 10824/josm, see #13309 (ticket). I am not sure why the parameter was not used. Looks like original idea was to bring the caching behavior to the GPXLayer. But the GpxLayer forward the paint() requests to GpxDrawHelper where a internal caching mechanism ( based on color, GPX style, current view area ) is used.

… import org.openstreetmap.josm.gui.dialogs.LayerListDialog;
…       …       public class GpxLayer extends Layer { 
96      96          }
97      97      
98      98          @Override
99                  public Color getColor(boolean ignoreCustom) {
100                     return drawHelper.getColor(getName(), ignoreCustom);
        99          protected ColorProperty getBaseColorProperty() {
        100             return GpxDrawHelper.DEFAULT_COLOR;
101     101         }

We should remove this parameter here and all is fine.

[Don-vip]

OK sorry I though it was introduced with color heat map, my mistake :)

[Don-vip]

Parameter removed in r11713.