#14247 closed enhancement (fixed)
Change names in heat map combobox
Reported by: | anonymous | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 17.01 |
Component: | Core | Version: | latest |
Keywords: | template_report gpx heatmap | Cc: | kidelo |
Description
What steps will reproduce the problem?
- Open preferences
- Open combobox for change color schema for heat map.
- The names in combobox is not color names I think.
What is the expected result?
Names that is color names.
Maybe something like what I can see in the code.
Wood -> brown2green
Heat -> red2blue
What happens instead?
Names that is not color names.
Wood is already translated, but in the meaning for material.
Please provide any additional information below. Attach a screenshot if possible.
URL:http://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2017-01-14 21:10:48 +0100 (Sat, 14 Jan 2017) Build-Date:2017-01-15 02:35:18 Revision:11463 Relative:URL: ^/trunk Identification: JOSM/1.5 (11463 en) Windows XP 32-Bit Memory Usage: 231 MB / 247 MB (106 MB allocated, but free) Java version: 1.8.0_111-b14, Oracle Corporation, Java HotSpot(TM) Client VM Screen: \Display0 1152x864 Maximum Screen Size: 1152x864 VM arguments: [-Duser.home=%UserProfile%] Plugins: + BuildingGeneralization (1010) + DxfImport (1008) + Mapillary (v1.3.2) + PicLayer (33088) + ShapeTools (1220) + apache-commons (32994) + apache-http (32699) + areaselector (1478814827) + continuosDownload (53) + junctionchecking (33088) + log4j (32699) + pdfimport (33004) + pt_assistant (33108) + reverter (33088) + tageditor (33021) + todo (30000) + turnlanes-tagging (254) + turnrestrictions (33088) + utilsplugin2 (33088) + wikipedia (33098) Map paint styles: - https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1 Last errors/warnings: - W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$SelectAction@138c01a - W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$AddAction@1a69953 - W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@4eaab4 - W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@e06e61 - W: Unable to get color from '' for color preference 'extrude.main.line' - W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line' - W: Unable to get color from '' for color preference 'make.parallel.helper.line' - W: Unable to get color from '' for color preference 'extrude.main.line' - W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line' - W: Unable to get color from '' for color preference 'make.parallel.helper.line'
Attachments (8)
Change History (19)
by , 7 years ago
Attachment: | Color schema.PNG added |
---|
comment:1 by , 7 years ago
comment:2 by , 7 years ago
Cc: | added |
---|---|
Keywords: | gpx heatmap added |
Milestone: | → 17.01 |
comment:4 by , 7 years ago
Replying to Don-vip:
Where do the names come from exactly?
Inferno + Viridis : Names of well known common color maps
see:
https://cran.r-project.org/web/packages/viridis/vignettes/intro-to-viridis.html
http://bids.github.io/colormap/
Wood + Heat
Name choosen by myself. First impression where I have seen the result.
comment:5 by , 7 years ago
Strava Heat Map use color names.
http://labs.strava.com/heatmap/#6/-120.90000/38.36000/blue/bike
comment:6 by , 7 years ago
OK. Agreed with bastiK, adding a visual indication with an icon should be enough.
by , 7 years ago
Attachment: | josm_ticket_14247_gpx_heat_map_config_by_kidelo_v1.patch added |
---|
Visualize GPX Heat Map Colors by kidelo, version 1
by , 7 years ago
Attachment: | heatmap_cfg_inferno.png added |
---|
by , 7 years ago
Attachment: | heatmap_cfg_user_red.png added |
---|
by , 7 years ago
Attachment: | heatmap_cfg_virdis.png added |
---|
by , 7 years ago
Attachment: | heatmap_cfg_user_cyan.png added |
---|
comment:7 by , 7 years ago
Here comes the solution for that enhancement request, please check if it will work.
- Preview Image (Icon) is generated based on selected heat map
- works for static predefined color maps and for color map based on user defined reference color
- no future effort needed when colors maps are changed, added or removed
See examples:
by , 7 years ago
Attachment: | josm_ticket_14247_gpx_heat_map_config_by_kidelo_v2.patch added |
---|
Visualize GPX Heat Map Colors by kidelo, version 2 - fix
by , 7 years ago
Attachment: | heatmap_cfg_global.png added |
---|
comment:8 by , 7 years ago
comment:9 by , 7 years ago
Great! Did you consider moving the icon(s) into the combobox? Then you could see all of them at once.
I think the names are fine, but it would be nice to have icons that illustrate the corresponding gradient next to the text.