id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
13570	[Patch] Coastline validator doesn't report some problems and is slow	GerdP	team	"==== What steps will reproduce the problem?
1. open file coastlines-samples.osm.zip
2. press Shift+V to run validator

==== What is the expected result?
All but the two ways in the top right box should be flagged

==== What happens instead?
Some ways are not flagged.

==== Please provide any additional information below. Attach a screenshot if possible.
The unpatched code is also rather complex and slow when the data contains lots of coastline ways
as the example for #13385 (y.osm.bz2)
The attached patch fixes the problems and makes the test much faster.

{{{
URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-06 00:16:07 +0200 (Tue, 06 Sep 2016)
Build-Date:2016-09-05 22:21:00
Revision:10966
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10966 en) Windows 10 64-Bit
Memory Usage: 2301 MB / 5461 MB (2032 MB allocated, but free)
Java version: 1.8.0_102-b14, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20160907_163056.jfr]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (32930)
+ apache-commons (32699)
+ buildings_tools (32796)
+ ejml (32680)
+ geotools (32813)
+ jts (32699)
+ o5m (32857)
+ opendata (32898)
+ pbf (32865)
+ poly (32699)
+ reverter (32796)
+ utilsplugin2 (32815)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
}}}
"	defect	closed	normal	16.10	Core validator		fixed	coastline validator, performance