Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11268 closed enhancement (fixed)

[Patch] Preset for Sanitary Dump Stations (portable toilet waste)

Reported by: brycenesbitt Owned by: team
Priority: normal Milestone: 15.04
Component: Internal preset Version:
Keywords: Cc:

Description (last modified by brycenesbitt)

Preset for Sanitary Dump Stations (portable toilet waste).
This is a common feature worldwide, for boaters and RV campers.

See http://wiki.openstreetmap.org/wiki/Key:sanitary_dump_station and linked proposal page.

Attachments (3)

sanitary_dump_station.png (924 bytes) - added by brycenesbitt 4 years ago.
Newly drawn icon 16x16px for JOSM
sanitary_dump_station2.png (942 bytes) - added by brycenesbitt 4 years ago.
Same icon, but with transparent background, in case you prefer this.
sanitary_dump_station.diff (2.8 KB) - added by brycenesbitt 4 years ago.
svn diff

Download all attachments as: .zip

Change History (12)

Changed 4 years ago by brycenesbitt

Attachment: sanitary_dump_station.png added

Newly drawn icon 16x16px for JOSM

comment:1 Changed 4 years ago by brycenesbitt

Description: modified (diff)

Changed 4 years ago by brycenesbitt

Attachment: sanitary_dump_station2.png added

Same icon, but with transparent background, in case you prefer this.

Changed 4 years ago by brycenesbitt

Attachment: sanitary_dump_station.diff added

svn diff

comment:2 Changed 4 years ago by brycenesbitt

Before the question is asked: there are not so many mapped now. But there are hundreds of thousands worldwide that
need to be mapped, thus the internal preset proposal.

comment:3 Changed 4 years ago by Klumbumbus

Milestone: 15.04

Can you provide the icon as svg?

Version 0, edited 4 years ago by Klumbumbus (next)

comment:4 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8188/josm:

fix #11268 - add preset for amenity=sanitary_dump_station (modified patch by brycenesbitt)

comment:5 Changed 4 years ago by Klumbumbus

comment:6 Changed 4 years ago by brycenesbitt

SVG icons optimized for three pixel sizes are at:
https://github.com/gravitystorm/openstreetmap-carto/pull/1466

symbols/toilet-dump-station-12.svg
symbols/toilet-dump-station-18.svg
symbols/toilet-dump-station-24.svg

comment:7 Changed 4 years ago by Klumbumbus

In 8190/josm:

fix #11268 - add mappaint style for amenity=sanitary_dump_station

comment:8 Changed 4 years ago by aceman

This tag currently has ~400 uses worldwide (with both variants). So I am not sure this should be already integrated in JOSM as a preset (similarly to bicycle_repair_station). But of course, it is the decision of the developers :)

But mapping the facility itself is surely useful for map users.

comment:9 Changed 4 years ago by brycenesbitt

@aceman I don't think the number of uses is an the important consideration for a preset. The point of a preset is to help mappers make more of the feature. Here, there are tens of thousands yet unmapped.

A good preset might:

  • Encourage new mappers to join the OSM project.
  • Be useful to map readers.
  • Help the community converge on a single tagging style.
  • Avoid confusion.
  • Be widely distributed (not a special purpose tag).

All that could be true even with zero current uses.

On this particular feature there were DOZENS of tagging styles. Had the preset been introduced earlier, that would never have happened.

Last edited 4 years ago by brycenesbitt (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.