Changes between Version 2 and Version 3 of Ticket #11216, comment 37


Ignore:
Timestamp:
2015-03-26T00:47:54+01:00 (4 years ago)
Author:
bastiK
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11216, comment 37

    v2 v3  
    1 `JCSCacheManager.initialize` does not respect the path set with `JCSCacheManager.setCacheParams`. I end up with both `cache/jcs` and `cache/tms`, but only the first has content.
     1The delay problem is fixed now, thanks!
    22
    3 The delay problem is fixed now, btw.
    4 
     3* `JCSCacheManager` does not respect the path set with `JCSCacheManager.setCacheParams`. I end up with both `cache/jcs` and `cache/tms`, but only the first has content.
    54* You have defined `DOWNLOAD_JOB_DISPATCHER` both in `TMSCachedTileLoaderJob` and `JCSCachedTileLoaderJob`, is that intended? One could use the convenience function `Collections.asLifoQueue` to make a LIFO.
     5* Should we revert the changes related to `JCSCachedTileLoaderJob.CACHE_ACCESS_EXECUTOR` for sake of code clarity? I don't think it is actually needed.
     6Minor stuff:
     7* `ICachedLoaderJob`: Did you plan to use generics for the value? Doc should be cleaned up.
     8* `CacheEntryAttributes` has unused fields