# # ChangeLog for / in josm # # Generated by Trac 1.6 # 2024-04-25T10:53:18+02:00 Thu, 29 Sep 2022 18:51:54 GMT taylor.smock [18565] * trunk/nodist/trans/ca-valencia.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sr-latin.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) i18n update Tue, 27 Sep 2022 19:25:50 GMT Klumbumbus [18564] * trunk/resources/data/validator/deprecated.mapcss (modified) fix #22397 - Warn about temporary image URLs starting with `https://westnordost.de/p/` Tue, 27 Sep 2022 16:34:33 GMT taylor.smock [18563] * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/IRelationEditorActionAccess.java (modified) Fix #22268: Upload of data triggering exception "Primitive cannot be modified in read-only dataset" This occurs during upload, and appears to be a race condition where a dataset is not locked when we check, but becomes locked while the relation copy constructor is running. This attempts to fix the problem by checking to see if any OsmDataLayer objects are in the upload process. Mon, 26 Sep 2022 15:45:59 GMT taylor.smock [18562] * trunk/test/unit/org/openstreetmap/josm/TestUtils.java (modified) See r18555: Fix tests on Windows This occurred due to the changes to TestUtils.assertEqualsNewline assuming that the actual text would include the system dependent newline. This is not always the case. Mon, 26 Sep 2022 15:11:33 GMT taylor.smock [18561] * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) See #22183: NoClassDefFoundError: Could not initialize class org.openstreetmap.josm.actions.SessionSave... Add check after the setting of `contentPanePrivate` to figure out why it might be `null`. Mon, 26 Sep 2022 06:42:14 GMT GerdP [18560] * trunk/src/org/openstreetmap/josm/data/validation/tests/ConditionalKeys.java (modified) fix #19340: Validator complains about maxweightrating:X:conditional - add maxweightrating as valid keyword Sun, 18 Sep 2022 16:03:33 GMT Klumbumbus [18559] * trunk/resources/styles/standard/elemstyles.mapcss (modified) fix #22359 - Change default color of `landuse=railway` and `landuse=quarry` as they were too similar to untagged ways color (#808080) Sun, 18 Sep 2022 15:16:11 GMT Klumbumbus [18558] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) fix #22379 - Warn about `parking=yes`, add `parking=layby` Mon, 12 Sep 2022 18:19:33 GMT Klumbumbus [18557] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) fix #22367, see #11499 - Don't warn anymore about `payment:credit_cards=yes` and `payment:debit_cards=yes`, Reduce warning of `payment:electronic_purses=yes` and `payment:cryptocurrencies=yes` to info level Thu, 08 Sep 2022 20:51:20 GMT taylor.smock [18556] * trunk/src/org/openstreetmap/josm/data/osm/FilterModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/FilterDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/FilterTableModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/MemberTableModel.java (modified) * trunk/src/org/openstreetmap/josm/tools/Utils.java (modified) Fix #22333: Allow delete + move up/down actions in filter dialog to act on all selected filters (patch by Woazboat, modified) This also adds build add/remove methods in FilterModel and FilterTableModel. Thu, 08 Sep 2022 16:22:23 GMT taylor.smock [18555] * trunk/test/unit/org/openstreetmap/josm/TestUtils.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/dialogs/InspectPrimitiveDialogTest.java (modified) Update tests for new UI information See #20716: Search for missing power line support features. This also improves test failure feedback in TestUtils.assertEqualsNewline. This is done by creating arrays and comparing those, which will help narrow down where the actual problem was. Thu, 08 Sep 2022 15:32:45 GMT taylor.smock [18554] * trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (modified) Fix #22309: Add option to merge by default when dragging nodes (patch by Woazboat) This is currently an advanced preference only. It uses the ctrl key to manage merging. Thu, 08 Sep 2022 15:19:20 GMT taylor.smock [18553] * trunk/src/org/openstreetmap/josm/data/osm/Way.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/CrossingWays.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/PowerLines.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/util/ValUtil.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/InspectPrimitiveDataText.java (modified) * trunk/src/org/openstreetmap/josm/tools/Geometry.java (modified) * trunk/src/org/openstreetmap/josm/tools/Utils.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/osm/WayTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/PowerLinesTest.java (added) * trunk/test/unit/org/openstreetmap/josm/tools/UtilsTest.java (modified) Fix #20716: Search for missing power line support features (patch by gaben, modified) Way: * Avoid Arrays.stream in hasIncompleteNodes. This decreases CPU cost by 90%+ and makes it free from a memory allocation standpoint. * Add method to get segment lengths (meters) CrossingWays: * Avoid Node#getEastNorth calls * Add a getSegments call that takes ILatLon PowerLines: * Check for inconsistent support node reference numbering * Check for ways with unusually long segments without node supports * Check for ways where line types might be misused ValUtil: * Avoid unnecessary calls to Node#getEastNorth * Add getSegmentCells for ILatLon InspectPrimitiveDataText: * Add average segment length statistic Geometry: * Add getSegmentSegmentIntersection for ILatLon to avoid new EastNorth objects Utils: * Add getStandardDeviation methods Thu, 08 Sep 2022 13:27:14 GMT taylor.smock [18552] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/highway.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) Fix #21396: Add/ignore popular tags * Ignores * `maxspeed:type` * Ignores in TODO section (now sorted) * `advertising=board` * `amenity=loading_dock` * `amenity=parcel_locker` * `amenity=payment_terminal` * `barrier=sliding_gate` * `boundary=forest_compartment` * `craft=grinding_mill` * `emergency=access_point` * `healthcare:speciality=general` * `hedge=hedge_bank` * `historic=bomb_crater` * `indoor=area` * `leisure=sports_hall` * `man_made=courtyard` * `man_made=gantry` * `military=trench` * `natural=crevasse` * `path=crossing` * `railway=proposed` * `road_marking=solid_stop_line` * `oneway` (`F::oneway`/`S:oneway:`), but indicates that this might need better software support * Issues: * Suggest `paving_stones:length`/`paving_stones:width` for `paving_stones:30` * Indicate `type="turnlanes:turns"` is deprecated * Preset updates * Modify `lit` to be more than yes/no * Add `rock` to surfaces * Add `none` to religions (`other_religions`) * Add `locked` (text="Usually locked" -- there is probably better wording for this) * Add `pavilion` to building * Add `shop` as a possible value for `entrance` * Add `product` as an optional key for `man_made=works`. With all currently documented values. * Add `fuel` to possible values for `vending` Wed, 07 Sep 2022 23:44:00 GMT taylor.smock [18551] * trunk/test/unit/org/openstreetmap/josm/testutils/JOSMTestRules.java (modified) Fix test failures due to StackOverflowError This occurs due to JMockit not cleaning up mocks in JUnit4 vintage. This means that EDTAssertionMocker, WindowlessMapViewStateMocker, and WindowlessNavigatableComponentMocker are all present after a JUnit4 test is run. Wed, 07 Sep 2022 17:55:04 GMT taylor.smock [18550] * trunk/src/org/openstreetmap/josm/tools/bugreport/BugReport.java (modified) Fix CID 1497740: Concurrent data access violations SUPPRESSED_EXCEPTIONS.add was originally not guarded, since the possible exception could be caused by pop, and I wanted to prevent that by keeping multiple threads from calling pop at the same time. Tue, 06 Sep 2022 16:40:21 GMT taylor.smock [18549] * trunk/src/org/openstreetmap/josm/gui/progress/swing/ProgressMonitorExecutor.java (modified) * trunk/src/org/openstreetmap/josm/gui/util/GuiHelper.java (modified) * trunk/src/org/openstreetmap/josm/tools/bugreport/BugReport.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/bugreport/BugReportTest.java (modified) See #22183: NoClassDefFoundError: Could not initialize class org.openstreetmap.josm.actions.SessionSaveAction The root cause is a suppressed NPE whose stack trace is not given in the bug report. This adds a method to BugReport to add suppressed exceptions to a report. In the future, if we keep the code long-term, methods in Logging which take exceptions may assume the exception is suppressed, and add it to the suppressed exceptions. Sun, 04 Sep 2022 21:41:55 GMT Klumbumbus [18548] * trunk/resources/data/defaultpresets.xml (modified) Fix #22310 - Rename "Parking Entrance" preset to "Parking Entrance/Exit" Wed, 31 Aug 2022 18:50:18 GMT Klumbumbus [18547] * trunk/resources/data/validator/unnecessary.mapcss (modified) fix #22338 - Warn about unnecessary `area=yes` on: `boundary`, `indoor`, `office` and `place` (patch by Famlam) Wed, 31 Aug 2022 18:30:24 GMT Klumbumbus [18546] * trunk/resources/data/validator/combinations.mapcss (modified) Fix #22295, see #18374 - Don't warn about "`collection_times` together with `amenity=recycling`. Probably `opening_hours` is meant." for cases when also opening_hours is set. Wed, 31 Aug 2022 18:02:23 GMT Klumbumbus [18545] * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) Fix #22335 - Deprecate `toilet` in favor of `toilets` Wed, 31 Aug 2022 17:50:08 GMT Klumbumbus [18544] * trunk/resources/data/validator/deprecated.mapcss (modified) fix #22336, see #13391 - Autofix `wood=deciduous` to `leaf_cycle=deciduous` Mon, 29 Aug 2022 14:59:00 GMT taylor.smock [18543] * trunk/nodist/trans/de.lang (modified) * trunk/nodist/trans/ko.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sr-latin.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) i18n update Tue, 23 Aug 2022 20:43:45 GMT taylor.smock [18542] * trunk/src/org/openstreetmap/josm/data/osm/DefaultNameFormatter.java (modified) Fix #21046: Add `description` to the default naming tags for relations `description` currently comes before `note`, since `description` is more likely to describe the object well for the mapper. Tue, 23 Aug 2022 20:33:20 GMT taylor.smock [18541] * trunk/src/org/openstreetmap/josm/io/OsmReader.java (modified) * trunk/test/unit/org/openstreetmap/josm/io/OsmReaderTest.java (modified) Fix #22250: Abort on XML error elements Tue, 23 Aug 2022 13:04:23 GMT taylor.smock [18540] * trunk/src/org/openstreetmap/josm/gui/dialogs/NotesDialog.java (modified) Fix #22307: Add popup menu for notes (patch by Woazboat) The popup menu has the following actions: * Comment * Open in Browser * Close * Reopen Tue, 16 Aug 2022 13:50:52 GMT taylor.smock [18539] * trunk/src/org/openstreetmap/josm/command/SplitWayCommand.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/DataSet.java (modified) * trunk/test/unit/org/openstreetmap/josm/command/SplitWayCommandTest.java (modified) Fix #21856: Split way: Wrong position of new member in PTv2 relation splitting a loop Mon, 15 Aug 2022 14:03:51 GMT taylor.smock [18538] * trunk/src/org/openstreetmap/josm/gui/widgets/JosmTextField.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/widgets/JosmTextFieldTest.java (added) JosmTextField: setHint now properly returns the old hint See #21319/r18221. This additionally adds a non-regression test. Sun, 14 Aug 2022 22:31:37 GMT Klumbumbus [18537] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) see #20682 - Use proper name "Arête" instead of "Arete", fix unit test Sat, 13 Aug 2022 16:58:06 GMT Klumbumbus [18536] * trunk/resources/data/validator/geometry.mapcss (modified) see #21836 - Improve error messages (use only key instead of whole tag) Sat, 13 Aug 2022 16:39:30 GMT Klumbumbus [18535] * trunk/resources/data/validator/combinations.mapcss (modified) * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/geometry.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) * trunk/resources/data/validator/numeric.mapcss (modified) see #21836 - Add some power/voltage validation rules: - `voltage:primary/secondary/tertiary` without `transformer` - `voltage:primary/secondary/tertiary` on a way - `voltage:primary/secondary/tertiary` not in correct number format (should be in volts with no units/delimiter/spaces) - don't warn about unknown numeric values of `voltage:primary/secondary/tertiary` - `transformer` together with `voltage` on nodes - `voltage:secondary` is lower than `voltage:primary` on `transformer=generator` - deprecate `voltage-high` and `voltage-low` in favor of `voltage:primary/secondary` Sat, 13 Aug 2022 15:21:12 GMT Klumbumbus [18534] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/images/presets/landmark/arete.svg (copied) * trunk/resources/images/presets/landmark/glacier.svg (added) * trunk/resources/styles/standard/elemstyles.mapcss (modified) fix #20682 - Add `natural=arete`, reuse glacier icon, modify icon for glacier (PD and CC0 licensed), remove `ele` from ridge preset (not useful on linear feature) Sat, 13 Aug 2022 14:26:27 GMT Klumbumbus [18533] * trunk/resources/styles/standard/elemstyles.mapcss (modified) see #22225 - Draw unclosed `leisure=track` `sport=running` without area style Thu, 11 Aug 2022 22:01:15 GMT taylor.smock [18532] * trunk/src/org/openstreetmap/josm/io/OsmApi.java (modified) Fix #22160: Retry on `SocketException: Unexpected end of file from server` This allows additional exceptions to force a retry. Specifically, the following subclasses of `SocketException` were considered: * `BindException` -- shouldn't be thrown, "Signals that an error occurred while attempting to bind a socket to a local address and port. Typically, the port is in use, or the requested local address could not be assigned." This will be raised if it is ever encountered. * `ConnectException`-- replacing that here, "Signals that an error occurred while attempting to connect a socket to a remote address and port. Typically, the connection was refused remotely (e.g., no process is listening on the remote address/port)." * `ConnectionResetException` -- "Thrown to indicate a connection reset" This seems to be a Java internal class. It is rethrown. * `NoRouteToHostException` -- "Signals that an error occurred while attempting to connect a socket to a remote address and port. Typically, the remote host cannot be reached because of an intervening firewall, or if an intermediate router is down." * `PortUnreachableException` -- "Signals that an ICMP Port Unreachable message has been received on a connected datagram." `SocketException` is only thrown in one location in the JDK source code, but just in case someone decided to throw the exception in a library, we additionally check that the message matches that from the JDK source. This is, unfortunately, a bit more fragile than it should be. Mon, 01 Aug 2022 18:38:58 GMT taylor.smock [18531] * trunk/.github/workflows/ant.yml (modified) Fix signtool.exe path location for GitHub Actions At time of writing, signtool.exe is not in the `bin\x64` path that it was previously in. Instead, it is in the following paths: * `C:\Program Files (x86)\Windows Kits\10\App Certification Kit` * `C:\Program Files (x86)\Windows Kits\10\bin\$VERSION\$ARCH`, with the following version matrix: * `VERSION`: * `10.0.17763.0` * `10.0.19041.0` * `10.0.20348.0` * `10.0.22000.0` * `10.0.22621.0` * `ARCH`: * `arm` * `arm64` * `x32` * `x64` This uses `App Certification Kit`, as that will presumably be the most stable path for `signtool.exe`. Mon, 01 Aug 2022 15:06:43 GMT taylor.smock [18530] * trunk/nodist/trans/ar.lang (modified) * trunk/nodist/trans/pt_BR.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sr-latin.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) i18n update Wed, 27 Jul 2022 17:06:02 GMT taylor.smock [18529] * trunk/src/org/openstreetmap/josm/gui/MainMenu.java (modified) MainMenu: Add missing `final` keywords Wed, 27 Jul 2022 14:21:06 GMT taylor.smock [18528] * trunk/resources/data/defaultpresets.xml (modified) Fix #22048: building=construction preset missing some values (patch by skyper, modified) Tue, 26 Jul 2022 21:05:41 GMT taylor.smock [18527] * trunk/resources/data/validator/combinations.mapcss (modified) Fix #22102: Add a warning if surface does not match tracktype (patch by mkoniecz) Tue, 26 Jul 2022 20:44:59 GMT taylor.smock [18526] * trunk/test/unit/org/openstreetmap/josm/actions/mapmode/SelectActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/imagery/WMTSTileSourceTest.java (modified) Fix tests that have been broken on Mac and Windows Mac was due to ctrl -> cmd differences, Windows was path issues ('\' versus '/'). Tue, 26 Jul 2022 17:32:25 GMT taylor.smock [18525] * trunk/native/macosx/macos-jpackage.sh (modified) * trunk/native/windows/win-jpackage.sh (modified) Add module `java.compiler` to Mac and Window packages This should fix #22188. Mon, 25 Jul 2022 14:36:06 GMT taylor.smock [18524] * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) Fix #22120: Add 'school=entrance' to deprecation warnings The number of `school=entrance` tags reached its peak in 2014 (1), and has since started to see a decrease in usage. At its height, there were about 1,700 uses of `school=entrance`. (1) taginfo:tags/school=entrance#chronology Thu, 21 Jul 2022 19:05:32 GMT taylor.smock [18523] * trunk/resources/data/validator/highway.mapcss (modified) Fix #21235: Stop whitelisting footway=*, and add footway=separate to blacklist candidates for sidewalk=* (patch by JeroenHoek) Patch notes by JeroenHoek (modified): * Add a check for `footway=separate`. * Remove special treatment for `footway=none`, `none` is added to the general `footway=*` check. * The whitelist for `footway=*` is removed. Thu, 21 Jul 2022 13:34:58 GMT taylor.smock [18522] * trunk/resources/data/validator/combinations.mapcss (modified) Fix #22166: ignore more barrier types for psv suspicious tag combination Mon, 18 Jul 2022 14:54:44 GMT taylor.smock [18521] * trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java (modified) Fix #22225: Don't warn about sport=running on unclosed ways Thu, 14 Jul 2022 18:22:52 GMT taylor.smock [18520] * trunk/src/org/openstreetmap/josm/data/vector/VectorPrimitive.java (modified) VectorPrimitive: Reduce memory allocations in isTagged Thu, 14 Jul 2022 14:33:31 GMT taylor.smock [18519] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) Fix #21630: Drop the "Riverbank" template (patch by zelonewolf) TagInfo(1) shows that usage of waterway=riverbank has cratered over the past year. As of writing, the total number of objects with waterway=riverbank is less than 5,000 objects, and due to the significant drop in usage, can be considered to be deprecated instead of in use. (1) taginfo:tags/waterway=riverbank#chronology Thu, 14 Jul 2022 14:25:41 GMT taylor.smock [18518] * trunk/src/org/openstreetmap/josm/data/vector/VectorPrimitive.java (modified) Allow VectorPrimitives to be filtered (see r18516) Thu, 14 Jul 2022 14:17:08 GMT taylor.smock [18517] * trunk/resources/data/boundaries.osm (modified) Fix #22176: Add subdivisions for Federated States of Micronesia (patch by westnordost, modified) Wed, 13 Jul 2022 20:00:49 GMT taylor.smock [18516] * trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java (modified) Move OsmPrimitive isDrawable to AbstractPrimitive This should have no effect on binary compatibility (according to japi-compliance-checker), and allows filters to work properly on non-OsmPrimitive objects (like vector primitives). Tue, 12 Jul 2022 17:41:48 GMT taylor.smock [18515] * trunk/native/linux/latest/usr/bin/josm-latest (modified) * trunk/native/linux/tested/usr/bin/josm (modified) Improve josm launchers (patch by sebastic) Patch notes from sebastic, modified. See #22193. * Use `/bin/bash` instead of `/usr/bin/env bash` usrmerge systems have both `/bin/bash` and `/usr/bin/bash`, non-usrmerge systems only have `/bin/bash`. Distributions that have differing behaviors between `/bin/bash` and `/usr/bin/bash` should update/fix their version of bash. * Set `ALTERNATIVE_JDK` only if `/etc/alternatives/java` exists. While not only Debian based distributions use the alternatives system, not all distributions do. * Use 4 spaces for indentation consistently. Some indentation used tabs, others 2 spaces. * Simplify `java_version` function. * Don't use `command -v` to test whether `dpkg` is available. The command may be an alias which results in output like: `dpkg is aliased to 'd*-p*-k*-g*'` * Fix issues reported by `shellcheck`. SC2086 is disabled for `$JAVA_OPTS` because that only works unquoted. Tue, 12 Jul 2022 15:16:14 GMT taylor.smock [18514] * trunk/ivy.xml (modified) * trunk/tools/ivy.xml (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) Dependency updates ivy.xml: * metadata-extractor: 2.17.0 -> 2.18.0 * Full changelog: https://github.com/drewnoakes/metadata- extractor/releases/tag/2.18.0 * spotbugs: 4.6.0 -> 4.7.1 * New detector `ThrowingExceptions` which introduces checks for methods throwing `RuntimeException`, `Exception`, or `Throwable` * Full changelog: https://github.com/spotbugs/spotbugs/releases/tag/4.7.0 (4.7.1 was bugfixes) * wiremock-jre8: 2.33.1 -> 2.33.2 * 2.33.1 was built with Java 11 instead of Java 8, leading to some incompatibilities * classgraph: 4.8.146 -> 4.8.149 * Line number ranges for methods * Several bug fixes tools/ivy.xml * javacc: 7.0.11 -> 7.0.12 * Mostly formatting fixes for generated code * proguard: 7.2.1 -> 7.2.2 * Full changelog: https://github.com/Guardsquare/proguard/releases/tag/v7.2.2 pmd: 6.44.0 -> 6.47.0 * `EmptyControlStatement` (we have a few empty `if` blocks) This replaces `EmptyFinallyBlock`, `EmptyIfStmt`, `EmptyInitializer`, `EmptyStatementBlock`, `EmptySwitchStatements`, `EmptySynchronizedBlock`, `EmptyTryBlock`, and `EmptyWhileStmt` We currently ignore this, since we were previously ignoring `EmptyIfStmt` and `EmptyWhileStmt` Thu, 07 Jul 2022 21:02:39 GMT taylor.smock [18513] * trunk/src/org/openstreetmap/josm/data/osm/Way.java (modified) Way: Fix IAE where getNodePairs would be called on an empty way This fixes #22198 and #22199. Thu, 07 Jul 2022 14:46:16 GMT taylor.smock [18512] * trunk/native/linux/latest/usr/bin/josm-latest (modified) * trunk/native/linux/tested/usr/bin/josm (modified) Fix #22193: /usr/bin/bash is not present on all Debian systems This switches to `/usr/bin/env bash`. Tue, 05 Jul 2022 17:14:22 GMT stoecker [18511] * trunk/nodist/trans/vi.lang (deleted) * trunk/resources/data/vi.lang (deleted) remove vi, see #21720 Tue, 05 Jul 2022 17:13:23 GMT stoecker [18510] * trunk/nodist/trans/es.lang (modified) * trunk/nodist/trans/pt_BR.lang (modified) * trunk/nodist/trans/uk.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sr-latin.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/vi.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) * trunk/src/org/openstreetmap/josm/tools/I18n.java (modified) i18n update, disable vi, fix #21720 Tue, 05 Jul 2022 16:45:52 GMT Klumbumbus [18509] * trunk/resources/data/validator/wikipedia.mapcss (modified) fix #22189 - Update valid wikipedia languages from https://www.wikidata.org/w/api.php?action=sitematrix&formatversion=2&format=json (`sitematrix.*.code`) Tue, 05 Jul 2022 14:22:56 GMT stoecker [18508] * trunk/nodist/trans/ar.lang (modified) * trunk/nodist/trans/be.lang (modified) * trunk/nodist/trans/da.lang (modified) * trunk/nodist/trans/en.lang (modified) * trunk/nodist/trans/es.lang (modified) * trunk/nodist/trans/nl.lang (modified) * trunk/nodist/trans/pt_BR.lang (modified) * trunk/nodist/trans/ru.lang (modified) * trunk/nodist/trans/uk.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sr-latin.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/vi.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) i18n update Mon, 04 Jul 2022 06:25:14 GMT GerdP [18507] * trunk/nodist/data/multipolygon.osm (modified) see #22187, see 21825: Same error code 1708 for two different problems fix unit test Mon, 04 Jul 2022 04:42:13 GMT GerdP [18506] * trunk/src/org/openstreetmap/josm/data/validation/tests/RelationChecker.java (modified) fix #22187, see #21825: Same error code 1708 for two different problems I introduced this annoying bug with r14990 and it probably caused lots of empty relations since users where not warned when they ignored the less important message "Role of relation member does not match template expression" Wed, 29 Jun 2022 19:59:01 GMT Klumbumbus [18505] * trunk/resources/data/validator/ignoretags.cfg (modified) fix #22172 - Don't warn about barrier=berm looks like barrier=kerb Wed, 29 Jun 2022 19:06:12 GMT Klumbumbus [18504] * trunk/resources/data/defaultpresets.xml (modified) fix #22154 - Add `incline`, `surface` and `fee` to `slipway` preset Tue, 28 Jun 2022 21:19:33 GMT taylor.smock [18503] * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageDisplay.java (modified) Fix #22170: AIOOBE in org.openstreetmap.josm.gui.util.imagery.CameraPlane Mon, 27 Jun 2022 16:29:34 GMT taylor.smock [18502] * trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/NodeElement.java (modified) Fix #22139: Significantly reduce allocations in NodeElement This significantly reduces the cost for painting nodes. In testing (Mesa County, Colorado, downloaded via overpass), this reduces the cost for painting nodes (no paintstyle) by 66% (memory allocations) and ~17% (CPU allocations). This comes out to about 7% of CPU cycles during map paint and ~20% of memory allocations during map paint. Mon, 27 Jun 2022 16:22:12 GMT taylor.smock [18501] * trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/AbstractMapRenderer.java (modified) Fix #22140: Significantly reduce allocations in AbstractMapRenderer#drawVirtualNodes This reduces MapViewState#getViewArea from ~56.5% of memory allocations to ~4.2%. This also reduced the CPU samples for that method from 5.1% to 2.9%. The profiling occurred with Mesa County, Colorado downloaded (via overpass). Fri, 24 Jun 2022 16:45:59 GMT taylor.smock [18500] * trunk/native/linux/latest/usr/bin/josm-latest (modified) See #22088: use hardcoded josm.dir.name to avoid casing issues Wed, 22 Jun 2022 22:47:56 GMT taylor.smock [18499] * trunk/native/linux/latest/usr/bin/josm-latest (modified) Sync josm-latest with josm for linux start scripts The differences were for the server side instance of checkbashisms (there exists differences between some versions of checkbashisms). Wed, 22 Jun 2022 22:07:10 GMT taylor.smock [18498] * trunk/native/linux/latest/usr/bin/josm-latest (modified) * trunk/native/linux/tested/usr/bin/josm (modified) Fix issues from checkbashisms introduced in r18497 Wed, 22 Jun 2022 20:49:42 GMT taylor.smock [18497] * trunk/native/linux/latest/usr/bin/josm-latest (modified) * trunk/native/linux/tested/usr/bin/josm (modified) Fix #22088: Debian start script does not properly check if a path does not exist or is not executable This also fixes #22157: java options from start script not passed #22157 had two issues: 1. The start script fell back to `/bin/java`, which did not allow for version information (we were using the path to `java` to get the version information) 2. `#!/bin/bash` was not working properly (1) was fixed in the patch for #22088, while (2) was a single-line change. #22088 largely made the start scripts more portable, and some variables can be overridden via environment variables. * `JAVAFX_HOME` (defaults to `/usr/share/openjfx/lib`) * `JOSM_PATH` (defaults to `/usr/share/${JOSM_VERSION}/${JOSM_VERSION}.jar`, with `JOSM_VERSION` being one of `josm` or `josm-latest`) * `JAVA_VERSION` is now parsed from `$JAVACMD -version` instead of the binary path * The `JAVACMD` should now always be executable * `dpkg` is no longer required, although it is still checked for, which allows us to prioritize specific Java versions * The differences between the `josm-latest` and `josm` binaries is 2 lines Tue, 21 Jun 2022 16:31:54 GMT taylor.smock [18496] * trunk/src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/osm/search/SearchCompilerTest.java (modified) Fix #22156: ArithmeticException: / by zero in org.openstreetmap.josm.data.osm.search.SearchCompiler$Nth.match This was caused by `nth%: 0`, as `x % 0` will throw a divide by 0 exception. Wed, 15 Jun 2022 18:01:29 GMT taylor.smock [18495] * trunk/src/org/openstreetmap/josm/data/coor/ILatLon.java (modified) * trunk/src/org/openstreetmap/josm/data/coor/LatLon.java (modified) Fix since xxx Wed, 15 Jun 2022 17:27:05 GMT taylor.smock [18494] * trunk/src/org/openstreetmap/josm/actions/AddNodeAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/CopyCoordinatesAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/CreateCircleAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/DownloadAlongAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/DrawSnapHelper.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/ParallelWayAction.java (modified) * trunk/src/org/openstreetmap/josm/command/MoveCommand.java (modified) * trunk/src/org/openstreetmap/josm/data/coor/ILatLon.java (modified) * trunk/src/org/openstreetmap/josm/data/coor/LatLon.java (modified) * trunk/src/org/openstreetmap/josm/data/gpx/GpxImageCorrelation.java (modified) * trunk/src/org/openstreetmap/josm/data/gpx/GpxTrackSegment.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/Node.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/Way.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java (modified) * trunk/src/org/openstreetmap/josm/data/projection/CustomProjection.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/Addresses.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/LongSegment.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/UnconnectedWays.java (modified) * trunk/src/org/openstreetmap/josm/gui/MapStatus.java (modified) * trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java (modified) * trunk/src/org/openstreetmap/josm/gui/bbox/SlippyMapBBoxChooser.java (modified) * trunk/src/org/openstreetmap/josm/gui/history/CoordinateInfoViewer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/gpx/GpxDrawHelper.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/RenderingCLI.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/Selector.java (modified) * trunk/src/org/openstreetmap/josm/io/GeoJSONWriter.java (modified) * trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/AddNodeHandler.java (modified) * trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/AddWayHandler.java (modified) * trunk/src/org/openstreetmap/josm/io/session/SessionReader.java (modified) * trunk/src/org/openstreetmap/josm/tools/Geometry.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/cache/JCSCacheManagerTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/coor/LatLonTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/gpx/GpxDataTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/projection/ProjectionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/mappaint/RenderingCLIAreaTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/GeometryTest.java (modified) Fix #22115: Extract methods from LatLon into ILatLon where they are generally applicable This also removes calls to `Node#getCoor` where possible, which reduces the number of memory allocations in `SearchCompiler#match`, and overall allocations due to `Node#getCoor` Wed, 15 Jun 2022 14:59:17 GMT taylor.smock [18493] * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) PMD/Checkstyle: `if(` -> `if (` Tue, 14 Jun 2022 06:46:54 GMT stoecker [18492] * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) fix #22109 - fix IPv6 detection, as api.openstreetmap.org fails in Java.isReachable() nowadays Mon, 13 Jun 2022 21:40:17 GMT taylor.smock [18491] * trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/UploadTextComponentValidator.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/io/UploadTextComponentValidatorTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/BasicPreferences.java (modified) Fix #20823: Reject uploads that do not follow either comment policy or source policy (patch by ljdelight) This fixes an issue where a the length of the comment or source was checked first, and a warning instead of a rejection was generated when the upload policy would have otherwise rejected the comment or source. This also performs the validation check first, prior to the user being able to make changes in the upload dialog UI, so that the initial dialog state matches the upload policy. Mon, 13 Jun 2022 17:55:33 GMT Don-vip [18490] * trunk/.github/workflows/ant.yml (modified) JavaFX 17.0.3 binaries not yet available on github, keep 17.0.2 Mon, 13 Jun 2022 17:38:59 GMT Don-vip [18489] * trunk/src/org/openstreetmap/josm/gui/conflict/pair/properties/PropertiesMergeModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/Functions.java (modified) see #22104 - fix deprecation warnings Mon, 13 Jun 2022 16:53:37 GMT Don-vip [18488] * trunk/.github/workflows/ant-test.yml (modified) * trunk/.github/workflows/ant.yml (modified) * trunk/build.xml (modified) see #21005 - java 18 support Mon, 13 Jun 2022 15:59:52 GMT taylor.smock [18487] * trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/CopyActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/DeleteLayerActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/PurgeActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/UnJoinNodeWayActionTest.java (modified) PMD/Checkstyle fixes for r18485 Mon, 13 Jun 2022 13:42:34 GMT taylor.smock [18486] * trunk/src/org/openstreetmap/josm/tools/PatternUtils.java (modified) Fix CID 1489883: Dereference null return value This was introduced in r18475, but it was unlikely to ever be a problem, as the constructor used sets the default element attributes to a non- null value. Thu, 09 Jun 2022 17:22:55 GMT taylor.smock [18485] * trunk/src/org/openstreetmap/josm/actions/SessionSaveAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/vectortile/mapbox/Feature.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/CopyActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/DeleteLayerActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/PurgeActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/UnJoinNodeWayActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/UploadActionTest.java (modified) SonarLint: Fix most recent code smells This also fixes some tests so that the JOSMTestRules is more accurate for them. Thu, 09 Jun 2022 13:52:24 GMT taylor.smock [18484] * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) MainApplication: Fix CORRECTNESS NP_NULL_PARAM_DEREF This is mostly due to a false positive (the only way for mainJOSM to be called with null is if `new ProgramArguments` throws an exception, but we exit the program in that case using Lifecycle.exitJosm). In any case, moving `mainJOSM` into the `try-catch` block should be marginally clearer, in so far as it is easier to tell that we don't run `mainJOSM` if we cannot parse the program arguments. Thu, 09 Jun 2022 13:44:34 GMT taylor.smock [18483] * trunk/src/org/openstreetmap/josm/gui/dialogs/NotesDialog.java (modified) NotesDialog: Fix test broken in r18479, see #21600 The test ensures that updates to the dialog do not cause a IOOBE, which often only occurs when a note is closed and the user is filtering for open notes. Thu, 09 Jun 2022 13:00:28 GMT taylor.smock [18482] * trunk/src/org/openstreetmap/josm/data/vector/VectorDataSet.java (modified) VectorDataSet: Fix MT_CORRECTNESS issues This was most likely caused by using Collections.synchronizedCollection initially, and then switching to a ConcurrentHashMap. Thu, 09 Jun 2022 12:33:40 GMT taylor.smock [18481] * trunk/src/org/openstreetmap/josm/actions/SessionSaveAction.java (modified) i18n: \r ->
Wed, 08 Jun 2022 21:16:08 GMT taylor.smock [18480] * trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java (modified) Fix JOSM #21422: Tile cache stats unreadable in debug mode (patch by gaben) This also changes the organization of stats a bit. Wed, 08 Jun 2022 21:03:12 GMT taylor.smock [18479] * trunk/src/org/openstreetmap/josm/data/notes/Note.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/NotesDialog.java (modified) Fix #21600: When setting/updating notes, fire selectionChanged events (patch by gaben) Wed, 08 Jun 2022 20:20:53 GMT taylor.smock [18478] * trunk/src/org/openstreetmap/josm/data/imagery/vectortile/mapbox/MVTTile.java (modified) * trunk/src/org/openstreetmap/josm/data/vector/VectorDataStore.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/vector/VectorDataSetTest.java (modified) Really fix failing tests in VectorDataSetTest The test failed ~50% of the time (it depended upon the HashSet ordering). We now use an ArrayList instead, and a the optimization that caused the failure is not as significant anymore (node search is significantly cheaper since r18465). Wed, 08 Jun 2022 18:21:41 GMT taylor.smock [18477] * trunk/src/org/openstreetmap/josm/data/vector/VectorDataStore.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/vector/VectorDataSetTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/vector/VectorNodeTest.java (modified) Fix tests broken in r18473, see #22032 This was caused by vector tiles not always having points, then ways, then polygons. The code now ensures that we add points first, followed by ways, and finally by polygons. Wed, 08 Jun 2022 17:24:17 GMT taylor.smock [18476] * trunk/native/macosx/macos-jpackage.sh (modified) Fix #21727: Make MacOS local builds possible without signature (patch by Stereo) Wed, 08 Jun 2022 17:09:15 GMT taylor.smock [18475] * trunk/src/org/openstreetmap/josm/tools/PatternUtils.java (added) * trunk/src/org/openstreetmap/josm/tools/Tag2Link.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/Tag2LinkTest.java (modified) Fix #21794: Allow for cases where tags can be URL or key values in Tag2Link This also adds a Pattern cache (memory only) to avoid many allocations for the same pattern in Tag2Link. Wed, 08 Jun 2022 15:54:29 GMT taylor.smock [18474] * trunk/src/org/openstreetmap/josm/data/osm/Tagged.java (modified) Replace @since xxx Wed, 08 Jun 2022 15:48:47 GMT taylor.smock [18473] * trunk/src/org/openstreetmap/josm/data/imagery/vectortile/mapbox/Feature.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/vectortile/mapbox/Geometry.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/vectortile/mapbox/GeometryTypes.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/vectortile/mapbox/Layer.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/vectortile/mapbox/MVTTile.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/Tagged.java (modified) * trunk/src/org/openstreetmap/josm/data/protobuf/ProtobufPacked.java (modified) * trunk/src/org/openstreetmap/josm/data/protobuf/ProtobufParser.java (modified) * trunk/src/org/openstreetmap/josm/data/protobuf/ProtobufRecord.java (modified) * trunk/src/org/openstreetmap/josm/data/vector/VectorDataStore.java (modified) * trunk/src/org/openstreetmap/josm/data/vector/VectorPrimitive.java (modified) * trunk/src/org/openstreetmap/josm/data/vector/VectorRelation.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/protobuf/ProtobufRecordTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/protobuf/ProtobufTest.java (modified) Fix #22032: Various memory enhancements for MVT tiles There is about a 88% decrease in memory allocations due to MVT tiles. The majority of changes came from the following: 1. Avoiding ArrayList#grow calls by using a `ByteArrayOutputStream` that gets passed around 2. Caching nodes to avoid `QuadBuckets#search` calls This additionally fixes a bug where `VectorRelation#setMembers` does not work properly and adds a `putAll` method in `Tagged` (there is a default method). Wed, 08 Jun 2022 15:33:09 GMT taylor.smock [18472] * trunk/src/org/openstreetmap/josm/actions/SessionSaveAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java (modified) Fix some coverity warnings * CID 1489777: FB.RV_RETURN_VALUE_IGNORED_BAD_PRACTICE Fixed by using Files.deleteIfExists instead of File.delete. We do catch the security exception and print a message for the user. * CID 1489773: FORWARD_NULL Fixed by synchronizing around the potential null object. Shouldn't be too expensive, as it is mostly UI loop. Wed, 08 Jun 2022 13:35:08 GMT stoecker [18471] * trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java (modified) fix dead code Tue, 07 Jun 2022 15:54:52 GMT taylor.smock [18470] * trunk/src/org/openstreetmap/josm/data/osm/Way.java (modified) Reduce memory allocations and CPU calls in Way#getNodePairs This reduces memory allocations and CPU calls by ~33% for the method call by setting the size of the list at construction time. See #20716 comment:68. Tue, 07 Jun 2022 14:28:49 GMT taylor.smock [18469] * trunk/resources/data/defaultpresets.xml (modified) Fix #21997: Add a general preset for power=generator (patch by skyper) Mon, 06 Jun 2022 18:35:45 GMT taylor.smock [18468] * trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (modified) * trunk/src/org/openstreetmap/josm/data/coor/EastNorth.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/DataSet.java (modified) Fix #21893: Align movement of objects when the last selected way has two nodes and the ctrl/meta modifier is pressed (patch by cmuelle8, modified) Mon, 06 Jun 2022 17:16:28 GMT taylor.smock [18467] * trunk/src/org/openstreetmap/josm/actions/UploadAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java (modified) Fix #20025, #22080: Notify users when changeset tags are programmatically modified This only works for non-late upload hooks. Mon, 06 Jun 2022 17:07:05 GMT taylor.smock [18466] * trunk/src/org/openstreetmap/josm/actions/SessionLoadAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/SessionSaveAction.java (added) * trunk/src/org/openstreetmap/josm/actions/SessionSaveAsAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainMenu.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/SaveLayersDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/LayerManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/gpx/ConvertToDataLayerAction.java (modified) * trunk/src/org/openstreetmap/josm/io/session/GenericSessionExporter.java (modified) * trunk/src/org/openstreetmap/josm/io/session/GpxTracksSessionExporter.java (modified) * trunk/src/org/openstreetmap/josm/io/session/GpxTracksSessionImporter.java (modified) * trunk/src/org/openstreetmap/josm/io/session/MarkerSessionExporter.java (modified) * trunk/src/org/openstreetmap/josm/io/session/MarkerSessionImporter.java (modified) * trunk/src/org/openstreetmap/josm/io/session/SessionReader.java (modified) * trunk/src/org/openstreetmap/josm/io/session/SessionWriter.java (modified) * trunk/src/org/openstreetmap/josm/tools/ListenerList.java (modified) * trunk/test/data/sessions/gpx_markers_combined.jos (added) * trunk/test/unit/org/openstreetmap/josm/actions/SessionSaveActionTest.java (added) * trunk/test/unit/org/openstreetmap/josm/actions/SessionSaveAsActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/io/session/SessionWriterTest.java (modified) Fix #21813: Improve marker handling in sessions and #21923: Improve session workflow/Add "save session" (patch by Bjoeni) * Allow saving a previously saved session * Add "File" -> "Save Session" * Add shortcuts for saving sessions * Add warning if a layer in a session is being removed when saving over the session * Improve GPX marker handling