# # ChangeLog for / in josm # # Generated by Trac 1.6 # 2024-04-25T00:44:07+02:00 Tue, 19 Jan 2021 13:46:51 GMT GerdP [17473] * trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (modified) see #17184: Memory leaks - clear also virtual ways when exiting SelectMode Tue, 19 Jan 2021 11:52:25 GMT stoecker [17472] * trunk/nodist/trans/de.lang (modified) * trunk/nodist/trans/sr-latin.lang (modified) * trunk/nodist/trans/zh_CN.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sr-latin.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/vi.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) fix #20402, I18n update Tue, 19 Jan 2021 06:27:13 GMT GerdP [17471] * trunk/src/org/openstreetmap/josm/data/osm/RelationMemberData.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/history/HistoryDataSet.java (modified) * trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserDialogManager.java (modified) see #17184: Memory leaks - use `String.intern()` for field `role` in `RelationMemberData` constructor. - clear `HistoryDataSet` when last `HistoryBrowserDialog` instance is closed We have route relations with +1000 members and +1000 versions. It's probably not a good idea to create all the `RelationMemberData` instances in advance. Will open a separate ticket for that. Mon, 18 Jan 2021 15:27:10 GMT Klumbumbus [17470] * trunk/resources/images/presets/barrier/cycle_barrier.svg (added) fix #20286 - Improve barrier=cycle_barrier icon (self created, idea of previous icon, PD and CC0 licensed) Mon, 18 Jan 2021 14:23:58 GMT Klumbumbus [17469] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) fix #20392 - Add shoulder=* to major roads presets and warn about shoulder=none Mon, 18 Jan 2021 13:54:18 GMT Klumbumbus [17468] * trunk/nodist/images/presets/embassy.svg (moved) * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) * trunk/resources/images/presets/office/diplomatic.svg (added) * trunk/resources/styles/standard/elemstyles.mapcss (modified) fix #20338 - Deprecate amenity=embassy in favor of office=diplomatic (icon derived from office=government and amenity=embassy icons, PD and CC0 licensed) Mon, 18 Jan 2021 13:01:22 GMT Klumbumbus [17467] * trunk/resources/data/validator/ignoretags.cfg (modified) fix #20351 - Don't warn about "Value urology for key healthcare:speciality is unknown, maybe biology is meant" Mon, 18 Jan 2021 12:47:54 GMT Klumbumbus [17466] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/LabelCompositionStrategy.java (modified) fix #20326 - Support railway:position instead of distance for railway=milestone Sun, 17 Jan 2021 14:16:47 GMT GerdP [17465] * trunk/src/org/openstreetmap/josm/tools/GeoPropertyIndex.java (modified) fix #20345: Corrupted GeoPropertyIndex due to wrong rounding? - remove method index(), iterate over real BBox instances instead to avoid edge cases Sat, 16 Jan 2021 20:50:09 GMT GerdP [17464] * trunk/src/org/openstreetmap/josm/data/osm/DataSet.java (modified) see #17184: Memory leaks - clear also refs to Conflicts which refer to OSM data in DataSet Sat, 16 Jan 2021 00:03:08 GMT Don-vip [17463] * trunk/native/linux/latest/DEBIAN/control (modified) * trunk/native/linux/tested/DEBIAN/control (modified) fix #20332 - add required `fonts-noto` ubuntu package Fri, 15 Jan 2021 10:31:42 GMT GerdP [17462] * trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java (modified) see #17184: Memory leaks - clear refs to OSM objects in popup memu of PropertiesDialog Fri, 15 Jan 2021 09:51:12 GMT GerdP [17461] * trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (modified) see #17184: Memory leaks - clear refs to OSM objects when Extrude Mode is ended Thu, 14 Jan 2021 20:35:17 GMT Don-vip [17460] * trunk/src/org/openstreetmap/josm/data/ImageData.java (modified) see #20363 - fix NPE Thu, 14 Jan 2021 18:18:03 GMT Don-vip [17459] * trunk/src/org/openstreetmap/josm/data/IQuadBucketType.java (added) * trunk/src/org/openstreetmap/josm/data/ImageData.java (modified) * trunk/src/org/openstreetmap/josm/data/gpx/GpxImageEntry.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/IPrimitive.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/QuadBuckets.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/GeoImageLayer.java (modified) fix #20363 - Extract necessary method for QuadBuckets into separate interface (patch by taylor.smock, modified) Wed, 13 Jan 2021 14:26:08 GMT GerdP [17458] * trunk/src/org/openstreetmap/josm/actions/OrthogonalizeAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/relation/AbstractRelationAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/LayerListDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/layer/ActivateLayerAction.java (modified) see #17184: Memory leaks - clear collection rememberMovements in OrthogonalizeAction when no edit layer exits - clear refs to layers which may disturb GC, maybe because of the complex cyclic deps Tue, 12 Jan 2021 05:47:40 GMT GerdP [17457] * trunk/resources/data/validator/combinations.mapcss (modified) fix #20318: Asking to tag segregated=no on highway=footway bicycle=yes is pointless - only complain about missing segregated tag if way is designated for bicycle AND foot Mon, 11 Jan 2021 13:58:01 GMT GerdP [17456] * trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java (modified) see #20313: Relation editor: Changes of "uninteresting" tags in mapview not recognized. and #12599: Added/deleted "uninteresting" tags are "reverted" by downloading area again (twice) - let method `hasEqualSemanticAttributes` compare all tags by default (as the javadoc states) Mon, 11 Jan 2021 10:54:27 GMT GerdP [17455] * trunk/src/org/openstreetmap/josm/gui/dialogs/InspectPrimitiveDialog.java (modified) see #17184: Memory leaks - don't keep ref to primitives, it isn't needed anywhere Sun, 10 Jan 2021 23:39:15 GMT Don-vip [17454] * trunk/scripts/SyncEditorLayerIndex.java (modified) filter empty WMS params Sun, 10 Jan 2021 21:25:27 GMT Don-vip [17453] * trunk/scripts/SyncEditorLayerIndex.java (modified) better comparison of WMS entries Sun, 10 Jan 2021 17:48:04 GMT GerdP [17452] * trunk/src/org/openstreetmap/josm/gui/MapView.java (modified) checkstyle Sat, 09 Jan 2021 16:11:18 GMT Don-vip [17451] * trunk/resources/data/validator/ignoretags.cfg (modified) ignore `house=detached` Sat, 09 Jan 2021 16:08:43 GMT Don-vip [17450] * trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java (modified) fix #20188 - NPE Sat, 09 Jan 2021 15:54:30 GMT Don-vip [17449] * trunk/src/org/openstreetmap/josm/gui/SplashScreen.java (modified) fix #20360 - fix splash screen scrolling (patch by DevCharly) Fri, 08 Jan 2021 17:45:56 GMT Klumbumbus [17448] * trunk/resources/data/validator/combinations.mapcss (modified) Avoid some false positive combination warnings with place=plot, see https://github.com/osm-fr/osmose-backend/issues/1088 Thu, 07 Jan 2021 10:05:39 GMT GerdP [17447] * trunk/src/org/openstreetmap/josm/data/validation/tests/CrossingWays.java (modified) fix #20352: Incorrect validation warning on waterway crossing of adjacent water areas Commit 20352.patch to - treat waterway=riverbank as water area - ignore crossing waterways and water areas Wed, 06 Jan 2021 15:47:43 GMT GerdP [17446] * trunk/src/org/openstreetmap/josm/actions/DownloadAlongWayAction.java (modified) fix #20311: NPE at josm.actions.DownloadAlongAction.actionPerformed() - have to install the adapters so that a change in the selection is actually recognized - reverts r17431 which assumed that the adapters are installed Wed, 06 Jan 2021 13:58:44 GMT GerdP [17445] * trunk/src/org/openstreetmap/josm/gui/MapView.java (modified) see #20272: Confusing handling of native scale layer and "zoom to download" - if imageary layer is removed which was enabled for "scale follows native resolution ..." set the native scale layer to null. An alternative might be to check if another layer could be enabled, but that would requure more logic and a history. Tue, 05 Jan 2021 09:31:16 GMT GerdP [17444] * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/RefreshAction.java (modified) see #20313: Relation editor: Changes of "uninteresting" tags in mapview not recognized. - don't ignore "uninteresting" tags when comparing relation in editor with that the original Mon, 04 Jan 2021 21:15:07 GMT Don-vip [17443] * trunk/resources/data/validator/ignoretags.cfg (modified) ignore `house=semi-detached`, popular only in England/Ireland and we already ignore `building=semidetached_house` Mon, 04 Jan 2021 21:01:28 GMT Don-vip [17442] * trunk/test/unit/org/openstreetmap/josm/tools/GeoPropertyIndexTest.java (added) * trunk/test/unit/org/openstreetmap/josm/tools/GeoUrlToBoundsTest.java (modified) see #20345 - add unit test Mon, 04 Jan 2021 17:18:56 GMT Klumbumbus [17441] * trunk/resources/data/validator/combinations.mapcss (modified) Don't warn about missing name for place=* if noname=yes is present (similar to all other rules with [!name]) (from https://github.com /osm-fr/osmose-backend/issues/1081) Mon, 04 Jan 2021 16:06:18 GMT GerdP [17440] * trunk/src/org/openstreetmap/josm/actions/mapmode/ImproveWayAccuracyAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/DeleteFromRelationConfirmationDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/LayerListDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/SavingAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java (modified) see #17184: Memory leaks - remove more listeners in destroy() - reset fields which might reference OSM objects - call data.clearSelection when data layer is destroyed so that fewer actions keep references on OSM elements in that layer My goal here: When a layer is closed JOSM should really allow to GC all OSM data and GPX data that was loaded before. Mon, 04 Jan 2021 15:51:24 GMT GerdP [17439] * trunk/src/org/openstreetmap/josm/data/gpx/GpxData.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/GpxLayer.java (modified) see #17184: Memory leaks - implement method clear() in GpxData and call it when the GpxLayer is destroyed Reduces memory leak when GPX layers are merged. Without this change GC seems to be unable to free the memory for WayPoints Mon, 04 Jan 2021 15:44:08 GMT GerdP [17438] * trunk/src/org/openstreetmap/josm/gui/dialogs/PropertiesMembershipChoiceDialog.java (modified) fix #20289: Unglue Node shows confusing "Where should the tags of the node be put" for node with converted_by=* tag - check isTagged() instead of hasKeys() like in other methods Mon, 04 Jan 2021 11:12:03 GMT GerdP [17437] * trunk/src/org/openstreetmap/josm/gui/dialogs/validator/ValidatorTreePanel.java (modified) fix #20342: Validator results not cleared - add code to make sure that invalidation listeners are called when buildTree is called even if the tree is empty The new method buildTreeInternal() is not strictly needed but I think it was too easy to add a return statement somewhere without looking at the very end of the complex method and thus skipping the line `invalidationListeners.fireEvent(Runnable::run);` Mon, 04 Jan 2021 10:54:31 GMT GerdP [17436] * trunk/src/org/openstreetmap/josm/actions/upload/ValidateUploadHook.java (modified) see #20342: Validator results not cleared - make sure that validator tree is rebuild even if all found errors are ignored (regression from r13893) Sun, 03 Jan 2021 22:41:13 GMT Don-vip [17435] * trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetCacheTableRowSorter.java (modified) fix #20335 - NPE in changeset manager when sorting open changesets Sun, 03 Jan 2021 22:17:33 GMT Don-vip [17434] * trunk/src/org/openstreetmap/josm/data/validation/tests/ConditionalKeys.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/ConditionalKeysTest.java (modified) fix #20337 - support `dog:conditional` Sun, 03 Jan 2021 22:09:00 GMT Don-vip [17433] * trunk/resources/data/defaultpresets.xml (modified) fix #20339 - see #19672 - distinguish context for gender values, as "mixed" is also used for leaf_type Sat, 02 Jan 2021 15:14:00 GMT GerdP [17432] * trunk/src/org/openstreetmap/josm/gui/draw/MapViewPath.java (modified) fix #20253: Weird area shading at a corner - use `closePath()` instead of `lineTo(first)` (Patch by michael2402) Sat, 02 Jan 2021 08:44:39 GMT GerdP [17431] * trunk/src/org/openstreetmap/josm/actions/DownloadAlongWayAction.java (modified) fix #20311: NPE at josm.actions.DownloadAlongAction.actionPerformed() - call updateEnabledState() in constructor Sat, 02 Jan 2021 08:37:50 GMT GerdP [17430] * trunk/src/org/openstreetmap/josm/data/validation/tests/CrossingWays.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/CrossingWaysTest.java (modified) fix #20330: Crossing landuse=residential and natural=water should not produce a warning - ignore crossing ways when one is landuse=residential and the other is natural=water or landuse=reservoir (both should be implemented in mapcss rules if wanted) - add unit test Wed, 30 Dec 2020 10:52:34 GMT GerdP [17429] * trunk/src/org/openstreetmap/josm/actions/CreateMultipolygonAction.java (modified) * trunk/test/data/regress/20325 (added) * trunk/test/data/regress/20325/data.osm (added) * trunk/test/data/regress/20325/invalid-new-upldate.osm (added) * trunk/test/data/regress/20325/no-change-new.osm (added) * trunk/test/data/regress/20325/no-change-old.osm (added) * trunk/test/data/regress/20325/update-no-command-warning.osm (added) * trunk/test/data/upd-multipolygon-cases (added) * trunk/test/unit/org/openstreetmap/josm/actions/CreateMultipolygonActionTest.java (modified) fix #20325: Update Multipolygon removes tags instead of moving them to relation - rewrite handling of update multipolygon cases - let `removeTagsFromWaysIfNeeded()` check if `getDataset()` returns null instead of checking `isNew()`. I assume it was always meant to work like this. JoinAreasAction works fine with that and I hope no plugin relies on the old behaviour. - add regression unit test and more unit tests to improve coverage Mon, 28 Dec 2020 21:03:23 GMT Klumbumbus [17428] * trunk/resources/data/validator/ignoretags.cfg (modified) fix #20307 - Don't warn about unknown values for keys ending with :maxstay Mon, 28 Dec 2020 15:45:21 GMT GerdP [17427] * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java (modified) fix #20304: Missing small button to invoke list of recent relations - call super.dispose() earlier so that recent relation list is properly filled Sun, 27 Dec 2020 19:15:27 GMT simon04 [17426] * trunk/nodist/trans/zh_TW.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/vi.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) I18n update Wed, 23 Dec 2020 07:02:18 GMT GerdP [17425] * trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java (modified) fix #20031: area:highway validation produces false positive "Overlapping ways" - add area:highway to the list of tags that describe an area so that it is ignored by the OverlappingWays test Wed, 23 Dec 2020 06:19:48 GMT GerdP [17424] * trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceTabbedPane.java (modified) fix #20123: "null" Preference Tab - log error and ignore preference is a TabPreferenceSetting which doesn't provide an icon Tue, 22 Dec 2020 08:28:39 GMT GerdP [17423] * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/MemberTableModel.java (modified) see #20228: JOSM hangs when downloading children relations - partly revert r17206 (don't wait) , this should fix the hanging situation - register / unregister listeners to avoid EDT violations when relation editor doesn't show the "Tags and Members" dialog tab Mon, 21 Dec 2020 09:09:58 GMT GerdP [17422] * trunk/src/org/openstreetmap/josm/gui/dialogs/RelationListDialog.java (modified) see #17184: Memory leaks - reset selection in selectRelationAction (not a real problem, but makes it harder to find real leaks) Mon, 21 Dec 2020 05:49:02 GMT GerdP [17421] * trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java (modified) see #17184: Memory leaks - reset field `lastUsedNode` in draw mode (not a real problem, but makes it harder to find real leaks) Mon, 21 Dec 2020 05:46:53 GMT GerdP [17420] * trunk/src/org/openstreetmap/josm/data/validation/tests/UnconnectedWays.java (modified) see #17184: Memory leaks - don't keep list of OSM data in validator tests (not a real problem, but makes it harder to find real leaks) Fri, 18 Dec 2020 10:41:23 GMT GerdP [17419] * trunk/src/org/openstreetmap/josm/actions/DownloadAlongAction.java (modified) see #19296: Actions should avoid to install listeners which are not needed - DownloadAlongAction doesn't use the listeners but is created for each right click on a GPX layer, stores a ref to GpxData and blocks GC Fri, 18 Dec 2020 06:34:27 GMT GerdP [17418] * trunk/src/org/openstreetmap/josm/gui/dialogs/LayerListDialog.java (modified) see #17184: Memory leaks - remove listener when layer is removed (regression of r13608) Thu, 17 Dec 2020 21:24:45 GMT Don-vip [17417] * trunk/src/org/openstreetmap/josm/io/imagery/ImageryReader.java (modified) fix #20262 - make ImageryReader robust to the fact imagery layers sometimes can't be created successfuly Thu, 17 Dec 2020 14:02:40 GMT GerdP [17416] * trunk/src/org/openstreetmap/josm/actions/AlignInCircleAction.java (modified) i18n: use "Nothing changed" instead of "nothing changed" as in CreateMultipolygonAction Thu, 17 Dec 2020 13:46:46 GMT GerdP [17415] * trunk/src/org/openstreetmap/josm/data/validation/tests/DirectionNodes.java (modified) see #20019: Warn about direction=forward/backward on invalid nodes. - use tag key + "=forward|backward" in messages so that we don't get separate messages for each direction Thu, 17 Dec 2020 13:37:44 GMT GerdP [17414] * trunk/src/org/openstreetmap/josm/actions/UploadNotesAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/AddNoteAction.java (modified) see #19296: Actions should avoid to install listeners which are not needed - both Note actions don't use SelectionChangeListener or LayerChangeListener Thu, 17 Dec 2020 08:43:16 GMT GerdP [17413] * trunk/nodist/data/direction-nodes.osm (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/DirectionNodes.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/DirectionNodesTest.java (modified) see #20019: Warn about direction=forward/backward on invalid nodes. - revert changes in DirectionNodes.java from 17412 - improve test coverage (nodes with positive ids) Thu, 17 Dec 2020 08:05:00 GMT GerdP [17412] * trunk/nodist/data/direction-nodes.osm (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/DirectionNodes.java (modified) see #20019: Warn about direction=forward/backward on invalid nodes. - simplify source - improve test coverage Thu, 17 Dec 2020 07:27:26 GMT GerdP [17411] * trunk/nodist/data/direction-nodes.osm (added) * trunk/src/org/openstreetmap/josm/data/validation/tests/DirectionNodes.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/Highways.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/DirectionNodesTest.java (added) fix #20019: Warn about direction=forward/backward on invalid nodes. - show error for unconnected node `Unconnected node with {0}. Use angle or cardinal direction` - show warning for node that is connected, but not to a suitable way `Node with {0} should be connected to a linear way` - show information for `Node with {0} on end of way` and `Node with {0} on a connection of multiple ways`, both in group `Disputed usage of direction on node` - special handling for highways: if there is a major highway as defined in `Highways.CLASSIFIED_HIGHWAYS`, ignore minor ways like `footway`, `path` to reduce false positives at traffic lights. Mon, 14 Dec 2020 17:34:04 GMT Klumbumbus [17410] * trunk/resources/data/validator/combinations.mapcss (modified) fix #20241 - Don't warn about icao and iata tags on aerodrome=heliport Mon, 14 Dec 2020 13:24:17 GMT Klumbumbus [17409] * trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java (modified) fix #20234 - Don't warn about unclosed natural=mountain_range Mon, 14 Dec 2020 10:52:24 GMT GerdP [17408] * trunk/src/org/openstreetmap/josm/actions/CreateMultipolygonAction.java (modified) * trunk/test/data/regress/20238 (added) * trunk/test/data/regress/20238/data.osm (added) * trunk/test/unit/org/openstreetmap/josm/actions/CreateMultipolygonActionTest.java (modified) fix #20238: update multipolygon on old-style multipolygon action cannot be fully undone - make sure that a command to update the relation is generated - add unit test Sun, 13 Dec 2020 16:44:41 GMT Don-vip [17407] * trunk/src/org/openstreetmap/josm/data/validation/routines/DomainValidator.java (modified) remove TLD from IANA Sun, 13 Dec 2020 15:04:00 GMT GerdP [17406] * trunk/src/org/openstreetmap/josm/actions/CreateMultipolygonAction.java (modified) * trunk/test/data/regress/20230 (added) * trunk/test/data/regress/20230/data.osm (added) * trunk/test/unit/org/openstreetmap/josm/actions/CreateMultipolygonActionTest.java (modified) fix #20230: update multipolygon action removes tags from ways without adding them to relation - create `ChangeCommand` if tags of updated relation were changed Todo: refactoring to remove class `CreateUpdateMultipolygonTask` Sat, 12 Dec 2020 20:39:37 GMT GerdP [17405] * trunk/src/org/openstreetmap/josm/data/validation/tests/RightAngleBuildingTest.java (modified) fix #20038: Autofix in RightAngleBuildingTest should be removed - remove code which creates a rather useless move command Sat, 12 Dec 2020 14:07:10 GMT GerdP [17404] * trunk/src/org/openstreetmap/josm/plugins/ReadLocalPluginInformationTask.java (modified) fix #19006: Incorrect plugins path used revert r3130, only scan directory returned by `Preferences.main().getPluginsDirectory()` Sat, 12 Dec 2020 13:40:42 GMT Don-vip [17403] * trunk/build.xml (modified) see #16567 - JUnit 5: enable parallel execution mode with command line parameters See https://junit.org/junit5/docs/snapshot/user-guide/index.html #writing-tests-parallel-execution Sat, 12 Dec 2020 10:31:51 GMT wiktorn [17402] * trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java (modified) Refuse to download tiles if the tileset is too large Use TileSet in overloadTiles and move decision whether to load the tileset or not to loadAllTiles. Closes: #20207 Fri, 11 Dec 2020 17:17:48 GMT GerdP [17401] * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/SavingAction.java (modified) fix #20222: Relation editor: Changes in member order are lost when updates are applied - correct logic which decides what type of command is needed, regression from r17358 Thu, 10 Dec 2020 16:38:18 GMT GerdP [17400] * trunk/src/org/openstreetmap/josm/data/validation/tests/CrossingWays.java (modified) * trunk/test/data/crossingWays.osm (added) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/CrossingWaysTest.java (modified) fix #20121: Confusing handling of water objects in CrossingWays - report all self crossing ways with the same message - ignore corssing water areas because they are reported by mapcss geometry tests - don't ignore crossing between water areas and highway, railway, barrier, or building - remove redundant and missleading checks in CrossingWays.Ways.ignoreWaySegmentCombination() - add unit test for coverage and test of these changes - fix @since Wed, 09 Dec 2020 07:27:45 GMT GerdP [17399] * trunk/src/org/openstreetmap/josm/data/UndoRedoHandler.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/CommandStackDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/AsynchronousUploadPrimitivesTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java (modified) fix #20213: Command stack: Edits in relation editor are listed in wrong stack and lead to exception - revert changes for #17196, this approach was too simple because relation editor may save changes for an inactive edit layer Wed, 09 Dec 2020 00:56:52 GMT Don-vip [17398] * trunk/test/unit/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreferenceTestIT.java (modified) see #16073 - prefix test name by country code, if any Tue, 08 Dec 2020 10:03:48 GMT GerdP [17397] * trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (modified) see #19885: memory leak with "temporary" objects in validator and actions - always call way.setNodes(null) Mon, 07 Dec 2020 14:40:50 GMT Don-vip [17396] * trunk/src/org/openstreetmap/josm/actions/RestartAction.java (modified) fix #20143 - make restart work with new macOS package built with jpackage Mon, 07 Dec 2020 11:40:06 GMT GerdP [17395] * trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (modified) see #19098: Unable to update plugin after crash of plugin - restore and document old behaviour to return null in case of errors in public method loadLocallyAvailablePluginInformation() Mon, 07 Dec 2020 11:38:14 GMT GerdP [17394] * trunk/test/unit/org/openstreetmap/josm/actions/AlignInCircleActionTest.java (modified) fix checkstyle issue Mon, 07 Dec 2020 10:52:15 GMT GerdP [17393] * trunk/src/org/openstreetmap/josm/actions/AlignInCircleAction.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/CrossingWays.java (modified) * trunk/test/data/alignCircleCases.osm (added) * trunk/test/data/regress/20041 (added) * trunk/test/data/regress/20041/circle-action.osm (added) * trunk/test/unit/org/openstreetmap/josm/actions/AlignInCircleActionTest.java (modified) see #10205: Strange align nodes in circle behavior - allow to define center node also when a single unclosed way is selected - add robustness and more unit tests for evaluation of valid selections - if only nodes and no way are selected, order the nodes using the angle to the agv. east-north position. This should produce a predictable result - if way(s) are selected the order the nodes is determined by the occurence in the way(s). Self-Intersecting polygons are rejected if no center node is given - don't throw InvalidSelection when selection is valid but no point was moved, let buildCommand() return null instead With a selection that gives a center point and way(s) which are not even close to a circular shape the result might still be surprising. Sometimes the way nodes are arranged around the center node, sometimes they are moved so that a circle arc with nearly the same length is produced. The result changes significantly when the way nodes are also selected. Subject to further improvements. Mon, 07 Dec 2020 09:58:03 GMT GerdP [17392] * trunk/src/org/openstreetmap/josm/gui/bugreport/BugReportDialog.java (modified) * trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (modified) fix #19098: Unable to update plugin after crash of plugin - wait for completion of threads - don't start `PluginHandler.updateOrdisablePluginAfterException(e)` in EDT tested with old buildings_tool.jar version 34113 which causes an immediate crash when a new data layer is created. TODO: Why didn't any unit test find this obvious bug? Seems we are mocking too much? Sun, 06 Dec 2020 17:00:26 GMT Don-vip [17391] * trunk/src/org/openstreetmap/josm/actions/RestartAction.java (modified) see #13784 - restart robustness Sun, 06 Dec 2020 15:56:46 GMT Don-vip [17390] * trunk/src/org/openstreetmap/josm/actions/RestartAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) * trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (modified) fix #13784 - restart robustness Sat, 05 Dec 2020 17:40:30 GMT Klumbumbus [17389] * trunk/resources/data/defaultpresets.xml (modified) Add water=basin Sat, 05 Dec 2020 17:30:10 GMT Klumbumbus [17388] * trunk/resources/data/validator/highway.mapcss (modified) fix #20117 - Warn about abbreviated street names: - Bnd for Bend - Cv for Cove - Trl for Trail - Xing for Crossing - Vw for View Sat, 05 Dec 2020 17:03:49 GMT Klumbumbus [17387] * trunk/resources/data/validator/geometry.mapcss (modified) fix #20193 - Warn about transformer=* on ways Wed, 02 Dec 2020 15:43:36 GMT GerdP [17386] * trunk/src/org/openstreetmap/josm/actions/AlignInCircleAction.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/SelfIntersectingWay.java (modified) * trunk/test/data/alignCircleAfter1.osm (added) * trunk/test/data/alignCircleAfter2.osm (added) * trunk/test/data/alignCircleBefore.osm (added) * trunk/test/data/alignCircleTwoWaysAfter.osm (added) * trunk/test/data/alignCircleTwoWaysBefore.osm (added) * trunk/test/unit/org/openstreetmap/josm/actions/AlignInCircleActionTest.java (added) fix #20041: Align nodes in Circle creates Command which changes nothing - only create move command if node is visibly moved - reject a self-intersecting way - reject old nodes outside of download area (the original code only shows an info and continues) - add some unit tests to improve coverage Wed, 02 Dec 2020 13:09:37 GMT GerdP [17385] * trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java (modified) fix #20187: Invalid warning: unclosed natural=earth_bank - add earth_bank to exclude list Wed, 02 Dec 2020 07:30:13 GMT GerdP [17384] * trunk/src/org/openstreetmap/josm/data/validation/tests/ConnectivityRelations.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/ConnectivityRelationsTest.java (modified) fix #20182: NumberFormatException in ConnectivityRelations.parseConnectivityTag - fix crash with invalid `connectivity=right_turn` or a single number like `connectivity=1` - remove code which looks for "bw" after "bw" was replaced by -1000. - some more cleanup and code simplifications - use JOSMTestRules() instead of JOSMFixture I don't like that method `parseConnectivityTag()` is public but didn't change it so far. It seems a bit strange to return an empty map for different kinds of problems found in the `connectivity` tag. Tue, 01 Dec 2020 19:59:49 GMT Don-vip [17383] * trunk/test/unit/org/openstreetmap/josm/gui/preferences/validator/ValidatorTagCheckerRulesPreferenceTestIT.java (modified) * trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerTestIT.java (modified) see #16567 - better assertion error messages for rules/plugins integration tests Tue, 01 Dec 2020 18:07:34 GMT GerdP [17382] * trunk/src/org/openstreetmap/josm/data/validation/tests/LongSegment.java (modified) fix #20174: Exclude administrative borders, especially national administrative borders from "very long segment" - exclude ways with `boundary=*` from test `LongSegment` Tue, 01 Dec 2020 17:49:30 GMT GerdP [17381] * trunk/test/unit/org/openstreetmap/josm/data/validation/routines/UrlValidatorTest.java (modified) fix checkstyle issue Mon, 30 Nov 2020 16:18:42 GMT stoecker [17380] * trunk/src/org/openstreetmap/josm/tools/bugreport/ReportedException.java (modified) missing counter increase, fix #CID1437607 Mon, 30 Nov 2020 15:33:56 GMT GerdP [17379] * trunk/src/org/openstreetmap/josm/data/UndoRedoHandler.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/AsynchronousUploadPrimitivesTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java (modified) see #17196 Undo/Redo may change data in inactive layer - fix sonar issue: Make UndoRedoHandler.clean(Dataset dataset) static Mon, 30 Nov 2020 15:22:13 GMT GerdP [17378] * trunk/src/org/openstreetmap/josm/data/UndoRedoHandler.java (modified) fix #17196 Undo/Redo may change data in inactive layer - fix case when there are two layers with changes and one layer is closed. The undo stack for the other layer disappeared. Mon, 30 Nov 2020 10:04:32 GMT GerdP [17377] * trunk/src/org/openstreetmap/josm/data/validation/tests/DuplicateNode.java (modified) fix javadoc Mon, 30 Nov 2020 09:57:50 GMT GerdP [17376] * trunk/src/org/openstreetmap/josm/data/validation/tests/DuplicateNode.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/DuplicateNodeTest.java (modified) fix issues reported by sonar / coverity, simplify code, add unit tests to improve coverage Sun, 29 Nov 2020 09:57:33 GMT GerdP [17375] * trunk/src/org/openstreetmap/josm/command/SplitWayCommand.java (modified) * trunk/test/data/regress/20163 (added) * trunk/test/data/regress/20163/data-20163.osm (added) * trunk/test/unit/org/openstreetmap/josm/command/SplitWayCommandTest.java (modified) fix #20163: Split way corrupts relation when splitting via way - if via way in turn restriction is split we have to insert new member Sun, 29 Nov 2020 09:33:58 GMT GerdP [17374] * trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (modified) * trunk/src/org/openstreetmap/josm/data/cache/HostLimitQueue.java (modified) * trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2GridShiftFile.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/routines/UrlValidator.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/ConnectivityRelations.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/DuplicateNode.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/SimilarNamedWays.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/CommandStackDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/DialogsPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/placement/CompletelyInsideAreaStrategy.java (modified) * trunk/src/org/openstreetmap/josm/tools/ListenerList.java (modified) * trunk/src/org/openstreetmap/josm/tools/Utils.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/routines/DomainValidatorTestIT.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/routines/EmailValidatorTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/routines/UrlValidatorTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/conflict/pair/nodes/NodeListMergeModelTest.java (modified) see #20167: [patch] Improve code readability by replacing indexed loops with foreach Patch by gaben, slightly modified I removed the changes for - GpxImageCorrelation.java, they introduce a TODO - ConnectivityRelations.java (no improvement in readability)