source: josm

fix #20335 - NPE in changeset manager when sorting open changesets

fix #20339 - see #19672 - distinguish context for gender values, as "mixed" is also used for leaf_type

fix #20311: NPE at josm.actions.DownloadAlongAction.actionPerformed()

• call updateEnabledState() in constructor

fix #20325: Update Multipolygon removes tags instead of moving them to relation

• rewrite handling of update multipolygon cases
• let removeTagsFromWaysIfNeeded() check if getDataset() returns null instead of checking isNew(). I assume it was always meant to work like this. JoinAreasAction works fine with that and I hope no plugin relies on the old behaviour.
• add regression unit test and more unit tests to improve coverage

fix #20304: Missing small button to invoke list of recent relations

• call super.dispose() earlier so that recent relation list is properly filled

fix #20031: area:highway validation produces false positive "Overlapping ways"

• add area:highway to the list of tags that describe an area so that it is ignored by the OverlappingWays test

see #20228: JOSM hangs when downloading children relations

• partly revert r17206 (don't wait) , this should fix the hanging situation
• register / unregister listeners to avoid EDT violations when relation editor doesn't show the "Tags and Members" dialog tab

see #17184: Memory leaks

• reset field lastUsedNode in draw mode (not a real problem, but makes it harder to find real leaks)

see #19296: Actions should avoid to install listeners which are not needed

• DownloadAlongAction doesn't use the listeners but is created for each right click on a GPX layer, stores a ref to GpxData and blocks GC

fix #20262 - make ImageryReader robust to the fact imagery layers sometimes can't be created successfuly

see #20019: Warn about direction=forward/backward on invalid nodes.

• use tag key + "=forward|backward" in messages so that we don't get separate messages for each direction

see #20019: Warn about direction=forward/backward on invalid nodes.

• revert changes in DirectionNodes.java from 17412
• improve test coverage (nodes with positive ids)

fix #20019: Warn about direction=forward/backward on invalid nodes.

• show error for unconnected node Unconnected node with {0}. Use angle or cardinal direction
• show warning for node that is connected, but not to a suitable way Node with {0} should be connected to a linear way
• show information for Node with {0} on end of way and Node with {0} on a connection of multiple ways, both in group Disputed usage of direction on node
• special handling for highways: if there is a major highway as defined in Highways.CLASSIFIED_HIGHWAYS, ignore minor ways like footway, path to reduce false positives at traffic lights.

fix #20234 - Don't warn about unclosed natural=mountain_range

remove TLD from IANA

fix #20038: Autofix in RightAngleBuildingTest should be removed

• remove code which creates a rather useless move command

see #16567 - JUnit 5: enable parallel execution mode with command line parameters

See ​https://junit.org/junit5/docs/snapshot/user-guide/index.html#writing-tests-parallel-execution

fix #20222: Relation editor: Changes in member order are lost when updates are applied

• correct logic which decides what type of command is needed, regression from r17358

fix #20213: Command stack: Edits in relation editor are listed in wrong stack and lead to exception

• revert changes for #17196, this approach was too simple because relation editor may save changes for an inactive edit layer

see #19885: memory leak with "temporary" objects in validator and actions

• always call way.setNodes(null)

see #19098: Unable to update plugin after crash of plugin

• restore and document old behaviour to return null in case of errors in public method loadLocallyAvailablePluginInformation()

see #10205: Strange align nodes in circle behavior

• allow to define center node also when a single unclosed way is selected
• add robustness and more unit tests for evaluation of valid selections
• if only nodes and no way are selected, order the nodes using the angle to the agv. east-north position. This should produce a predictable result
• if way(s) are selected the order the nodes is determined by the occurence in the way(s). Self-Intersecting polygons are rejected if no center node is given
• don't throw InvalidSelection when selection is valid but no point was moved, let buildCommand() return null instead

With a selection that gives a center point and way(s) which are not even close to a circular shape the result might still be surprising. Sometimes the way nodes are arranged around the center node, sometimes they are moved so that a circle arc with nearly the same length is produced. The result changes significantly when the way nodes are also selected. Subject to further improvements.

see #13784 - restart robustness

Add water=basin

fix #20193 - Warn about transformer=* on ways

fix #20187: Invalid warning: unclosed natural=earth_bank

• add earth_bank to exclude list

see #16567 - better assertion error messages for rules/plugins integration tests

fix checkstyle issue

see #17196 Undo/Redo may change data in inactive layer

• fix sonar issue: Make UndoRedoHandler.clean(Dataset dataset) static

fix javadoc

fix #20163: Split way corrupts relation when splitting via way

• if via way in turn restriction is split we have to insert new member

see #20146 - Improvements to macOS build and github actions (patch by Stereo)

From ​https://github.com/openstreetmap/josm/pull/67:

• Separate the create-release github action to pass the release url to all subsequent jobs, to be able to...
• Upload .jar artefacts from all runs, and a separate .app for all java versions for macOS
• Better caching for ant/junit
• Support for the release workflow from #20146
• A few cosmetic fixes, more readable syntax, etc.

fix #18533: changeset manager: tags tab: width of column (almost) not changeable

• use ReadOnlyTableModel as in PropertiesDialog to allow resizing of column width
• don't allow reordering of column headers in Changeset dialogs (because content doesn't match header if allowed)

see #20141 - Revert "ImageProvider: cache rendered SVG images using JCS"

see #19885: memory leak with "temporary" objects in validator and actions

• simplify code in SplitWayCommand, no need to create a way when we only need to know the nodes

see #19885: memory leak with "temporary" objects in validator and actions

• revert fix of counter of relations, it is used in a popup and should in fact count all relations

see #20141 - Extract BufferedImageCacheEntry.pngEncoded

Fix #18372: Notes description does not fit in box (sometimes)

• increase magic number to 20 as proposed by mnalis

see #19885: memory leak with "temporary" objects in validator and actions

• revert changes made in r17358 in SplitWayCommand , they break a unit test and I do not yet see why

see #19885: memory leak with "temporary" objects in validator and actions
Minor changes:

• add hint regarding memory leak in javadoc to copy constructors for Way and Relation
• decrease memory footprint of incomplete ways

presets refactoring

fix #12536: Conflict window completely hides relation 'conflicts' while doing a "Replace Geometry"

• improve calculation of divider location

When resizing the dialog the refreshed result is still poor but I hope that's less annoying.

fix sonar issue

see #20019: Warn about direction=forward/backward on invalid nodes.

• implement new test DirectionNodes which uses error codes 4000-4099

TODO: unit test

fix #17196: Undo/Redo may change data in inactive layer

• use separate stacks for each edit layer
• show empty undo/redo stack when active layer isn't an edit layer

fix #20142 - Fix josm.dir.name in man pages

fix #20110: "Update multipolygon" strips natural=coastline from member ways

• fix and unit test

fix #20091: Downloading incomplete, deleted members leads to data inconsitency

• changes the logic of "download members" so that all non-new members of all selected relations are downloaded. It doesn't recurse down on child relations. The old code did a download of members using the relation id, so the server returned the members of the version as known by the server. Disadvantage: The new code is slower.
• changes and simplifies DataSetMerger to fix the wrong handling of deleted objects in the source
• additional unit tests to cover more branches in mergeById()
• also fixes #19783

​https://errorprone.info/bugpattern/StringSplitter

ShowStatusReportAction: migrate to PrintWriter